Fix rubocop warnings

[chef.git] / cookbooks / osmosis / recipes / default.rb

diff --git a/cookbooks/osmosis/recipes/default.rb b/cookbooks/osmosis/recipes/default.rb
index 707ebe62018036bf30ed5755884cf63250f51331..b5b0b60b60a650c3ca8d5328ab16cc711daf3a86 100644 (file)
--- a/cookbooks/osmosis/recipes/default.rb
+++ b/cookbooks/osmosis/recipes/default.rb
@@ -1,8 +1,8 @@
 #
 #

-# Cookbook Name:: osmosis
+# Cookbook:: osmosis

 # Recipe:: default
 #
 # Recipe:: default
 #

-# Copyright 2013, OpenStreetMap Foundation
+# Copyright:: 2013, OpenStreetMap Foundation

 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.


@@ -19,14 +19,16 @@
 
 include_recipe "chef"
 
 
 include_recipe "chef"
 

-package "unzip"

 package "default-jre"
 
 package "default-jre"
 

-osmosis_package = "osmosis-#{node[:osmosis][:version]}.zip"
-osmosis_directory = "/opt/osmosis-#{node[:osmosis][:version]}"
+cache_dir = Chef::Config[:file_cache_path]

 
 

-Dir.glob("/var/cache/chef/osmosis-*.zip").each do |zip|
-  next if zip == "/var/cache/chef/#{osmosis_package}"
+osmosis_version = node[:osmosis][:version]
+osmosis_package = "osmosis-#{osmosis_version}.zip"
+osmosis_directory = "/opt/osmosis-#{osmosis_version}"
+
+Dir.glob("#{cache_dir}/osmosis-*.zip").each do |zip|
+  next if zip == "#{cache_dir}/#{osmosis_package}"

 
   file zip do
     action :delete
 
   file zip do
     action :delete


@@ -37,25 +39,25 @@ end
 directory osmosis_directory do
   owner "root"
   group "root"
 directory osmosis_directory do
   owner "root"
   group "root"

-  mode 0o755
+  mode "755"

 end
 
 end
 

-execute "/var/cache/chef/#{osmosis_package}" do
-  action :nothing
-  command "unzip -q /var/cache/chef/#{osmosis_package}"
-  cwd osmosis_directory
-  user "root"
+remote_file "#{cache_dir}/#{osmosis_package}" do
+  action :create_if_missing
+  source "https://github.com/openstreetmap/osmosis/releases/download/#{osmosis_version}/osmosis-#{osmosis_version}.zip"
+  owner "root"

   group "root"
   group "root"

+  mode "644"
+  backup false

 end
 
 end
 

-remote_file "/var/cache/chef/#{osmosis_package}" do
-  action :create_if_missing
-  source "https://bretth.dev.openstreetmap.org/osmosis-build/#{osmosis_package}"
+archive_file "#{cache_dir}/#{osmosis_package}" do
+  action :nothing
+  destination osmosis_directory
+  overwrite true

   owner "root"
   group "root"
   owner "root"
   group "root"

-  mode 0o644
-  backup false
-  notifies :run, "execute[/var/cache/chef/#{osmosis_package}]"
+  subscribes :extract, "remote_file[#{cache_dir}/#{osmosis_package}]"

 end
 
 link "/usr/local/bin/osmosis" do
 end
 
 link "/usr/local/bin/osmosis" do