Use multipackage installs throughout

[chef.git] / cookbooks / hardware / recipes / default.rb

diff --git a/cookbooks/hardware/recipes/default.rb b/cookbooks/hardware/recipes/default.rb
index 0120827893e94a4fca57a6660ce608abfbad86db..41eae5a5b63c245888978d7fcbb9df6487c87ab9 100644 (file)
--- a/cookbooks/hardware/recipes/default.rb
+++ b/cookbooks/hardware/recipes/default.rb
@@ -55,11 +55,8 @@ case manufacturer
 when "HP"
   package "hponcfg"
 
 when "HP"
   package "hponcfg"
 

-  # Downgrade hp-health to 10.0.0.1.3-4. as 10.40-1815.49 has issues with reliable startup

   package "hp-health" do
     action :install
   package "hp-health" do
     action :install

-    version "10.0.0.1.3-4."
-    options "--force-yes"

     notifies :restart, "service[hp-health]"
   end
 
     notifies :restart, "service[hp-health]"
   end
 


@@ -86,7 +83,7 @@ end
 
 # Remove legacy HP G4 support which breaks modern hp-health 10.4
 if manufacturer == "HP"
 
 # Remove legacy HP G4 support which breaks modern hp-health 10.4
 if manufacturer == "HP"

-  %w(/opt/hp/hp-health/bin/hpasmd /usr/lib/libhpasmintrfc.so.3.0 %/usr/lib/libhpasmintrfc.so.3 /usr/lib/libhpasmintrfc.so).each do |filename|
+  %w[/opt/hp/hp-health/bin/hpasmd /usr/lib/libhpasmintrfc.so.3.0 %/usr/lib/libhpasmintrfc.so.3 /usr/lib/libhpasmintrfc.so].each do |filename|

     file filename do
       action :delete
     end
     file filename do
       action :delete
     end


@@ -203,16 +200,32 @@ service "lldpd" do
   supports :status => true, :restart => true, :reload => true
 end
 
   supports :status => true, :restart => true, :reload => true
 end
 

+package "mcelog"
+
+%w[bus cache dimm iomca page socket-memory unknown].each do |trigger|
+  template "/etc/mcelog/#{trigger}-error-trigger.local" do
+    source "mcelog-trigger.erb"
+    owner "root"
+    group "root"
+    mode 0o755
+  end
+end
+
+service "mcelog" do
+  action [:start, :enable]
+  supports :status => true, :restart => true, :reload => false
+end
+

 tools_packages = []
 status_packages = {}
 
 node[:kernel][:modules].each_key do |modname|
   case modname
   when "cciss"
 tools_packages = []
 status_packages = {}
 
 node[:kernel][:modules].each_key do |modname|
   case modname
   when "cciss"

-    tools_packages << "hpssacli"
+    tools_packages << "ssacli"

     status_packages["cciss-vol-status"] ||= []
   when "hpsa"
     status_packages["cciss-vol-status"] ||= []
   when "hpsa"

-    tools_packages << "hpssacli"
+    tools_packages << "ssacli"

     status_packages["cciss-vol-status"] ||= []
   when "mptsas"
     tools_packages << "lsiutil"
     status_packages["cciss-vol-status"] ||= []
   when "mptsas"
     tools_packages << "lsiutil"


@@ -246,7 +259,7 @@ node[:block_device].each do |name, attributes|
   end
 end
 
   end
 end
 

-%w(hpssacli lsiutil sas2ircu megactl megacli arcconf).each do |tools_package|
+%w[ssacli lsiutil sas2ircu megactl megacli arcconf].each do |tools_package|

   if tools_packages.include?(tools_package)
     package tools_package
   else
   if tools_packages.include?(tools_package)
     package tools_package
   else


@@ -318,30 +331,22 @@ intel_nvmes = nvmes.select { |pci| pci[:vendor_name] == "Intel Corporation" }
 
 if !intel_ssds.empty? || !intel_nvmes.empty?
   package "unzip"
 
 if !intel_ssds.empty? || !intel_nvmes.empty?
   package "unzip"

-  package "alien"
-
-  remote_file "#{Chef::Config[:file_cache_path]}/DataCenterTool_3_0_0_Linux.zip" do
-    source "https://downloadmirror.intel.com/23931/eng/DataCenterTool_3_0_0_Linux.zip"
-  end

 
 

-  execute "unzip-DataCenterTool" do
-    command "unzip DataCenterTool_3_0_0_Linux.zip isdct-3.0.0.400-15.x86_64.rpm"
-    cwd Chef::Config[:file_cache_path]
-    user "root"
-    group "root"
-    not_if { File.exist?("#{Chef::Config[:file_cache_path]}/isdct-3.0.0.400-15.x86_64.rpm") }
+  remote_file "#{Chef::Config[:file_cache_path]}/Intel_SSD_Data_Center_Tool_3.0.7_Linux.zip" do
+    source "https://downloadmirror.intel.com/27144/eng/Intel_SSD_Data_Center_Tool_3.0.7_Linux.zip"

   end
 
   end
 

-  execute "alien-isdct" do
-    command "alien --to-deb isdct-3.0.0.400-15.x86_64.rpm"
+  execute "#{Chef::Config[:file_cache_path]}/Intel_SSD_Data_Center_Tool_3.0.7_Linux.zip" do
+    command "unzip Intel_SSD_Data_Center_Tool_3.0.7_Linux.zip isdct_3.0.7.401-17_amd64.deb"

     cwd Chef::Config[:file_cache_path]
     user "root"
     group "root"
     cwd Chef::Config[:file_cache_path]
     user "root"
     group "root"

-    not_if { File.exist?("#{Chef::Config[:file_cache_path]}/isdct_3.0.0.400-16_amd64.deb") }
+    not_if { File.exist?("#{Chef::Config[:file_cache_path]}/isdct_3.0.7.401-17_amd64.deb") }

   end
 
   dpkg_package "isdct" do
   end
 
   dpkg_package "isdct" do

-    source "#{Chef::Config[:file_cache_path]}/isdct_3.0.0.400-16_amd64.deb"
+    version "3.0.7.401-17"
+    source "#{Chef::Config[:file_cache_path]}/isdct_3.0.7.401-17_amd64.deb"

   end
 end
 
   end
 end
 


@@ -384,7 +389,7 @@ smartd_service = if node[:lsb][:release].to_f >= 16.04
 
 disks = disks.compact
 
 
 disks = disks.compact
 

-if disks.count > 0
+if disks.count.positive?

   package "smartmontools"
 
   template "/usr/local/bin/smartd-mailer" do
   package "smartmontools"
 
   template "/usr/local/bin/smartd-mailer" do


@@ -419,7 +424,7 @@ if disks.count > 0
   # an Areca controller as they only allow one thing to
   # talk to the controller at a time and smartd will
   # throw errors if it clashes with munin
   # an Areca controller as they only allow one thing to
   # talk to the controller at a time and smartd will
   # throw errors if it clashes with munin

-  disks = disks.reject { |disk| disk[:smart] && disk[:smart].start_with?("areca,") }
+  disks = disks.reject { |disk| disk[:smart]&.start_with?("areca,") }

 
   disks.each do |disk|
     munin_plugin "smart_#{disk[:munin]}" do
 
   disks.each do |disk|
     munin_plugin "smart_#{disk[:munin]}" do


@@ -434,7 +439,7 @@ else
   end
 end
 
   end
 end
 

-if disks.count > 0
+if disks.count.positive?

   munin_plugin "hddtemp_smartctl" do
     conf "munin.hddtemp.erb"
     conf_variables :disks => disks
   munin_plugin "hddtemp_smartctl" do
     conf "munin.hddtemp.erb"
     conf_variables :disks => disks