Yet more rubucop cleanups

[chef.git] / cookbooks / munin / recipes / default.rb

diff --git a/cookbooks/munin/recipes/default.rb b/cookbooks/munin/recipes/default.rb
index eac718fc004b2c23ab1e50be8246a53f334f449c..79c58df5800f5123ab21bd622e6a79405f371490 100644 (file)
--- a/cookbooks/munin/recipes/default.rb
+++ b/cookbooks/munin/recipes/default.rb
@@ -22,7 +22,10 @@ include_recipe "networking"
 package "munin-node"
 
 service "munin-node" do
 package "munin-node"
 
 service "munin-node" do

-  action [ :enable, :start ]
+  if node[:lsb][:release].to_f >= 14.04
+    provider Chef::Provider::Service::Upstart
+  end
+  action [:enable, :start]

   supports :status => true, :restart => true, :reload => true
 end
 
   supports :status => true, :restart => true, :reload => true
 end
 


@@ -50,7 +53,7 @@ template "/etc/munin/munin-node.conf" do
   group "root"
   mode 0644
   variables :servers => servers
   group "root"
   mode 0644
   variables :servers => servers

-  notifies :restart, resources(:service => "munin-node")
+  notifies :restart, "service[munin-node]"

 end
 
 remote_directory "/usr/local/share/munin/plugins" do
 end
 
 remote_directory "/usr/local/share/munin/plugins" do


@@ -73,7 +76,7 @@ remote_directory "/etc/munin/plugin-conf.d" do
   files_group "root"
   files_mode 0644
   purge false
   files_group "root"
   files_mode 0644
   purge false

-  notifies :restart, resources(:service => "munin-node")
+  notifies :restart, "service[munin-node]"

 end
 
 if Dir.glob("/proc/acpi/thermal_zone/*/temperature").empty?
 end
 
 if Dir.glob("/proc/acpi/thermal_zone/*/temperature").empty?


@@ -87,7 +90,7 @@ end
 # apcpdu_
 munin_plugin "cpu"
 
 # apcpdu_
 munin_plugin "cpu"
 

-if File.exists?("/sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state")
+if File.exist?("/sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state")

   munin_plugin "cpuspeed"
 else
   munin_plugin "cpuspeed" do
   munin_plugin "cpuspeed"
 else
   munin_plugin "cpuspeed" do


@@ -102,6 +105,8 @@ munin_plugin "entropy"
 munin_plugin "forks"
 
 if node[:kernel][:modules].include?("nf_conntrack")
 munin_plugin "forks"
 
 if node[:kernel][:modules].include?("nf_conntrack")

+  package "conntrack"
+

   munin_plugin "fw_conntrack"
   munin_plugin "fw_forwarded_local"
 else
   munin_plugin "fw_conntrack"
   munin_plugin "fw_forwarded_local"
 else


@@ -114,7 +119,7 @@ else
   end
 end
 
   end
 end
 

-if %x{sysctl -n net.ipv4.ip_forward}.chomp == "1"
+if File.read("/proc/sys/net/ipv4/ip_forward").chomp == "1"

   munin_plugin "fw_packets"
 else
   munin_plugin "fw_packets" do
   munin_plugin "fw_packets"
 else
   munin_plugin "fw_packets" do


@@ -122,43 +127,67 @@ else
   end
 end
 
   end
 end
 

-# hddtemp_smartctl
+disks = node[:block_device].select do |_, attributes|
+  ["ATA", "FUJITSU", "SEAGATE", "DELL", "COMPAQ", "IBM-ESXS"].include?(attributes[:vendor])
+end
+
+if disks.empty?
+  munin_plugin "hddtemp_smartctl" do
+    action :delete
+  end
+else
+  munin_plugin "hddtemp_smartctl" do
+    conf "hddtemp.erb"
+    conf_variables :disks => disks
+  end
+end
+
+if File.exist?("/sbin/hpasmcli")
+  munin_plugin "hpasmcli2_temp" do
+    target "hpasmcli2_"
+  end

 
 

-if File.exists?("/sbin/hpasmcli")
-  munin_plugin "hpasmcli_temp"
-  munin_plugin "hpasmcli_fans"
+  munin_plugin "hpasmcli2_fans" do
+    target "hpasmcli2_"
+  end

 else
 else

-  munin_plugin "hpasmcli_temp" do
+  munin_plugin "hpasmcli2_temp" do

     action :delete
   end
 
     action :delete
   end
 

-  munin_plugin "hpasmcli_fans" do
+  munin_plugin "hpasmcli2_fans" do

     action :delete
   end
 end
 
     action :delete
   end
 end
 

+munin_plugin "hpasmcli_temp" do
+  action :delete
+end
+
+munin_plugin "hpasmcli_fans" do
+  action :delete
+end
+

 munin_plugin "http_loadtime" do
   action :delete
 end
 
 munin_plugin "http_loadtime" do
   action :delete
 end
 

-node[:network][:interfaces].each do |ifname,ifattr|
-  if ifname =~ /^eth\d+$/
-    if ifattr[:flags] and ifattr[:flags].include?("UP")
-      munin_plugin "if_err_#{ifname}" do
-        target "if_err_"
-      end
+node[:network][:interfaces].each do |ifname, ifattr|
+  if ifattr[:encapsulation] == "Ethernet" && ifattr[:state] == "up"
+    munin_plugin "if_err_#{ifname}" do
+      target "if_err_"
+    end

 
 

-      munin_plugin "if_#{ifname}" do
-        target "if_"
-      end
-    else
-      munin_plugin "if_err_#{ifname}" do
-        action :delete
-      end
+    munin_plugin "if_#{ifname}" do
+      target "if_"
+    end
+  else
+    munin_plugin "if_err_#{ifname}" do
+      action :delete
+    end

 
 

-      munin_plugin "if_#{ifname}" do
-        action :delete
-      end
+    munin_plugin "if_#{ifname}" do
+      action :delete

     end
   end
 end
     end
   end
 end


@@ -175,6 +204,11 @@ if Dir.glob("/dev/ipmi*").empty?
   munin_plugin "ipmi_temp" do
     action :delete
   end
   munin_plugin "ipmi_temp" do
     action :delete
   end

+
+  munin_plugin "ipmi_power" do
+    action :delete
+    only_if { node[:lsb][:release].to_f >= 14.04 }
+  end

 else
   munin_plugin "ipmi_fans" do
     target "ipmi_"
 else
   munin_plugin "ipmi_fans" do
     target "ipmi_"


@@ -183,31 +217,27 @@ else
   munin_plugin "ipmi_temp" do
     target "ipmi_"
   end
   munin_plugin "ipmi_temp" do
     target "ipmi_"
   end

-end
-
-munin_plugin "irqstats"

 
 

-Dir.new("/sys/block").each do |device|
-  if device.match(/^sd/)
-    munin_plugin "linux_diskstat_iops_#{device}" do
-      target "linux_diskstat_"
-    end
-
-    munin_plugin "linux_diskstat_latency_#{device}" do
-      target "linux_diskstat_"
-    end
-
-    munin_plugin "linux_diskstat_throughput_#{device}" do
-      target "linux_diskstat_"
-    end
+  munin_plugin "ipmi_power" do
+    target "ipmi_"
+    only_if { node[:lsb][:release].to_f >= 14.04 }

   end
 end
 
   end
 end
 

+munin_plugin "irqstats"

 munin_plugin "load"
 munin_plugin "memory"
 munin_plugin "netstat"
 
 munin_plugin "load"
 munin_plugin "memory"
 munin_plugin "netstat"
 

-if File.exists?("/proc/net/rpc/nfs")
+if node[:kernel][:modules].include?("nfsv3")
+  munin_plugin "nfs_client"
+else
+  munin_plugin "nfs_client" do
+    action :delete
+  end
+end
+
+if node[:kernel][:modules].include?("nfsv4")

   munin_plugin "nfs4_client"
 else
   munin_plugin "nfs4_client" do
   munin_plugin "nfs4_client"
 else
   munin_plugin "nfs4_client" do


@@ -215,7 +245,7 @@ else
   end
 end
 
   end
 end
 

-if File.exists?("/proc/net/rpc/nfsd")
+if node[:kernel][:modules].include?("nfsd")

   munin_plugin "nfsd"
   munin_plugin "nfsd4"
 else
   munin_plugin "nfsd"
   munin_plugin "nfsd4"
 else


@@ -247,15 +277,17 @@ sensors_temp = false
 sensors_volt = false
 
 Dir.glob("/sys/class/hwmon/hwmon*").each do |hwmon|
 sensors_volt = false
 
 Dir.glob("/sys/class/hwmon/hwmon*").each do |hwmon|

-  package "lm-sensors"
-
-  hwmon = "#{hwmon}/device" unless File.exists?("#{hwmon}/name")
+  hwmon = "#{hwmon}/device" unless File.exist?("#{hwmon}/name")

 
   sensors_fan = true unless Dir.glob("#{hwmon}/fan*_input").empty?
   sensors_temp = true unless Dir.glob("#{hwmon}/temp*_input").empty?
   sensors_volt = true unless Dir.glob("#{hwmon}/in*_input").empty?
 end
 
 
   sensors_fan = true unless Dir.glob("#{hwmon}/fan*_input").empty?
   sensors_temp = true unless Dir.glob("#{hwmon}/temp*_input").empty?
   sensors_volt = true unless Dir.glob("#{hwmon}/in*_input").empty?
 end
 

+if sensors_fan || sensors_temp || sensors_volt
+  package "lm-sensors"
+end
+

 if sensors_fan
   munin_plugin "sensors_fan" do
     target "sensors_"
 if sensors_fan
   munin_plugin "sensors_fan" do
     target "sensors_"


@@ -279,6 +311,7 @@ end
 if sensors_volt
   munin_plugin "sensors_volt" do
     target "sensors_"
 if sensors_volt
   munin_plugin "sensors_volt" do
     target "sensors_"

+    conf "sensors_volt.erb"

   end
 else
   munin_plugin "sensors_volt" do
   end
 else
   munin_plugin "sensors_volt" do


@@ -286,8 +319,22 @@ else
   end
 end
 
   end
 end
 

-# smart_
+node[:block_device].each do |name, attributes|
+  if attributes[:vendor] == "ATA"
+    munin_plugin "smart_#{name}" do
+      target "smart_"
+      conf "smart.erb"
+      conf_variables :disk => name
+    end
+  else
+    munin_plugin "smart_#{name}" do
+      action :delete
+    end
+  end
+end
+

 munin_plugin "swap"
 munin_plugin "swap"

+munin_plugin "tcp"

 munin_plugin "threads"
 munin_plugin "uptime"
 munin_plugin "users"
 munin_plugin "threads"
 munin_plugin "uptime"
 munin_plugin "users"