Reduce sensitivity of render rate alarm

[chef.git] / hooks / pre-commit

diff --git a/hooks/pre-commit b/hooks/pre-commit
index 55d23300cee8c20ff844da2a421821cd7bd7da7b..60d6659326ff7908b9cf25fa8f9d1553c42523e5 100755 (executable)
--- a/hooks/pre-commit
+++ b/hooks/pre-commit
@@ -3,7 +3,7 @@
 ok = true
 
 if IO.popen(["git", "ls-files", "--unmerged"]).read.empty?
-  need_stash = IO.popen(%w(git diff)).read.length > 0
+  need_stash = !IO.popen(%w[git diff]).read.empty?
 
   system("git", "stash", "save", "--keep-index", "--quiet") if need_stash
 
@@ -12,14 +12,14 @@ if IO.popen(["git", "ls-files", "--unmerged"]).read.empty?
   end.compact
 
   ruby_files = files.select do |file|
-    file =~ /\.rb$/ || `file --brief --mime-type #{file}` == "text/x-ruby\n"
+    file =~ /\.rb$/ || (file !~ /\.erb$/ && %x(file --brief --mime-type #{file}) == "text/x-ruby\n")
   end
 
-  ok &&= system("rubocop", *ruby_files) unless ruby_files.empty?
+  ok &&= system("bundle", "exec", "rubocop", *ruby_files) unless ruby_files.empty?
 
   cookbooks = files.grep(%r{(cookbooks/[^/]+)/}) { Regexp.last_match(1) }.uniq
 
-  ok &&= system("foodcritic", "-f", "any", *cookbooks) unless cookbooks.empty?
+  ok &&= system("bundle", "exec", "foodcritic", *cookbooks) unless cookbooks.empty?
 
   system("git", "stash", "pop", "--quiet") if need_stash
 else