Use declare_resource to avoid need for template_source wart

[chef.git] / cookbooks / munin / recipes / default.rb

diff --git a/cookbooks/munin/recipes/default.rb b/cookbooks/munin/recipes/default.rb
index ac6c4d843558183e7bfba4de5fcd914a09ffbad2..9a6b6e696cff818797c4a17309ec0db5f1f4255e 100644 (file)
--- a/cookbooks/munin/recipes/default.rb
+++ b/cookbooks/munin/recipes/default.rb
@@ -17,32 +17,25 @@
 # limitations under the License.
 #
 
 # limitations under the License.
 #
 

-include_recipe "networking"
-

 package "munin-node"
 
 service "munin-node" do
 package "munin-node"
 
 service "munin-node" do

-  if node[:lsb][:release].to_f >= 14.04
-    provider Chef::Provider::Service::Upstart
-  end
-  action [ :enable, :start ]
+  action [:enable, :start]

   supports :status => true, :restart => true, :reload => true
 end
 
   supports :status => true, :restart => true, :reload => true
 end
 

-servers = search(:node, "recipes:munin\\:\\:server")
+servers = search(:node, "recipes:munin\\:\\:server") # ~FC010

 
 servers.each do |server|
   server.interfaces(:role => :external) do |interface|
 
 servers.each do |server|
   server.interfaces(:role => :external) do |interface|

-    if interface[:zone]
-      firewall_rule "accept-munin-#{server}" do
-        action :accept
-        family interface[:family]
-        source "#{interface[:zone]}:#{interface[:address]}"
-        dest "fw"
-        proto "tcp:syn"
-        dest_ports "munin"
-        source_ports "1024:"
-      end
+    firewall_rule "accept-munin-#{server}" do
+      action :accept
+      family interface[:family]
+      source "#{interface[:zone]}:#{interface[:address]}"
+      dest "fw"
+      proto "tcp:syn"
+      dest_ports "munin"
+      source_ports "1024:"

     end
   end
 end
     end
   end
 end


@@ -51,7 +44,7 @@ template "/etc/munin/munin-node.conf" do
   source "munin-node.conf.erb"
   owner "root"
   group "root"
   source "munin-node.conf.erb"
   owner "root"
   group "root"

-  mode 0644
+  mode 0o644

   variables :servers => servers
   notifies :restart, "service[munin-node]"
 end
   variables :servers => servers
   notifies :restart, "service[munin-node]"
 end


@@ -60,10 +53,10 @@ remote_directory "/usr/local/share/munin/plugins" do
   source "plugins"
   owner "root"
   group "root"
   source "plugins"
   owner "root"
   group "root"

-  mode 0755
+  mode 0o755

   files_owner "root"
   files_group "root"
   files_owner "root"
   files_group "root"

-  files_mode 0755
+  files_mode 0o755

   purge true
 end
 
   purge true
 end
 


@@ -71,10 +64,10 @@ remote_directory "/etc/munin/plugin-conf.d" do
   source "plugin-conf.d"
   owner "root"
   group "munin"
   source "plugin-conf.d"
   owner "root"
   group "munin"

-  mode 0750
+  mode 0o750

   files_owner "root"
   files_group "root"
   files_owner "root"
   files_group "root"

-  files_mode 0644
+  files_mode 0o644

   purge false
   notifies :restart, "service[munin-node]"
 end
   purge false
   notifies :restart, "service[munin-node]"
 end


@@ -90,7 +83,7 @@ end
 # apcpdu_
 munin_plugin "cpu"
 
 # apcpdu_
 munin_plugin "cpu"
 

-if File.exists?("/sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state")
+if File.exist?("/sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state")

   munin_plugin "cpuspeed"
 else
   munin_plugin "cpuspeed" do
   munin_plugin "cpuspeed"
 else
   munin_plugin "cpuspeed" do


@@ -98,8 +91,13 @@ else
   end
 end
 
   end
 end
 

+munin_plugin_conf "df" do
+  template "df.erb"
+end
+

 munin_plugin "df"
 munin_plugin "df_inode"
 munin_plugin "df"
 munin_plugin "df_inode"

+

 munin_plugin "diskstats"
 munin_plugin "entropy"
 munin_plugin "forks"
 munin_plugin "diskstats"
 munin_plugin "entropy"
 munin_plugin "forks"


@@ -127,22 +125,7 @@ else
   end
 end
 
   end
 end
 

-disks = node[:block_device].select do |name,attributes|
-  [ "ATA", "FUJITSU", "SEAGATE", "DELL", "COMPAQ", "IBM-ESXS" ].include?(attributes[:vendor])
-end
-
-if disks.empty?
-  munin_plugin "hddtemp_smartctl" do
-    action :delete
-  end
-else
-  munin_plugin "hddtemp_smartctl" do
-    conf "hddtemp.erb"
-    conf_variables :disks => disks
-  end
-end
-
-if File.exists?("/sbin/hpasmcli")
+if File.exist?("/sbin/hpasmcli")

   munin_plugin "hpasmcli2_temp" do
     target "hpasmcli2_"
   end
   munin_plugin "hpasmcli2_temp" do
     target "hpasmcli2_"
   end


@@ -160,7 +143,7 @@ else
   end
 end
 
   end
 end
 

-munin_plugin "hpasmcli_temp" do
+munin_plugin "hpasmcli_temp" do # ~FC005

   action :delete
 end
 
   action :delete
 end
 


@@ -172,8 +155,21 @@ munin_plugin "http_loadtime" do
   action :delete
 end
 
   action :delete
 end
 

-node[:network][:interfaces].each do |ifname,ifattr|
-  if ifattr[:encapsulation] == "Ethernet" and ifattr[:state] == "up"
+node[:network][:interfaces].each do |ifname, ifattr|
+  if ifattr[:encapsulation] == "Ethernet" && ifattr[:state] == "up"
+    if node[:hardware] &&
+       node[:hardware][:network] &&
+       node[:hardware][:network][ifname][:device] =~ /^virtio/
+      munin_plugin_conf "if_#{ifname}" do
+        template "if.erb"
+        variables :ifname => ifname
+      end
+    else
+      munin_plugin_conf "if_#{ifname}" do
+        action :delete
+      end
+    end
+

     munin_plugin "if_err_#{ifname}" do
       target "if_err_"
     end
     munin_plugin "if_err_#{ifname}" do
       target "if_err_"
     end


@@ -197,6 +193,10 @@ munin_plugin "iostat"
 munin_plugin "iostat_ios"
 
 if Dir.glob("/dev/ipmi*").empty?
 munin_plugin "iostat_ios"
 
 if Dir.glob("/dev/ipmi*").empty?

+  munin_plugin_conf "ipmi" do
+    action :delete
+  end
+

   munin_plugin "ipmi_fans" do
     action :delete
   end
   munin_plugin "ipmi_fans" do
     action :delete
   end


@@ -207,9 +207,12 @@ if Dir.glob("/dev/ipmi*").empty?
 
   munin_plugin "ipmi_power" do
     action :delete
 
   munin_plugin "ipmi_power" do
     action :delete

-    only_if { node[:lsb][:release].to_f >= 14.04 }

   end
 else
   end
 else

+  munin_plugin_conf "ipmi" do
+    template "ipmi.erb"
+  end
+

   munin_plugin "ipmi_fans" do
     target "ipmi_"
   end
   munin_plugin "ipmi_fans" do
     target "ipmi_"
   end


@@ -220,7 +223,6 @@ else
 
   munin_plugin "ipmi_power" do
     target "ipmi_"
 
   munin_plugin "ipmi_power" do
     target "ipmi_"

-    only_if { node[:lsb][:release].to_f >= 14.04 }

   end
 end
 
   end
 end
 


@@ -277,16 +279,14 @@ sensors_temp = false
 sensors_volt = false
 
 Dir.glob("/sys/class/hwmon/hwmon*").each do |hwmon|
 sensors_volt = false
 
 Dir.glob("/sys/class/hwmon/hwmon*").each do |hwmon|

-  hwmon = "#{hwmon}/device" unless File.exists?("#{hwmon}/name")
+  hwmon = "#{hwmon}/device" unless File.exist?("#{hwmon}/name")

 
   sensors_fan = true unless Dir.glob("#{hwmon}/fan*_input").empty?
   sensors_temp = true unless Dir.glob("#{hwmon}/temp*_input").empty?
   sensors_volt = true unless Dir.glob("#{hwmon}/in*_input").empty?
 end
 
 
   sensors_fan = true unless Dir.glob("#{hwmon}/fan*_input").empty?
   sensors_temp = true unless Dir.glob("#{hwmon}/temp*_input").empty?
   sensors_volt = true unless Dir.glob("#{hwmon}/in*_input").empty?
 end
 

-if sensors_fan || sensors_temp || sensors_volt
-  package "lm-sensors"
-end
+package "lm-sensors" if sensors_fan || sensors_temp || sensors_volt

 
 if sensors_fan
   munin_plugin "sensors_fan" do
 
 if sensors_fan
   munin_plugin "sensors_fan" do


@@ -319,20 +319,6 @@ else
   end
 end
 
   end
 end
 

-node[:block_device].each do |name,attributes|
-  if attributes[:vendor] == "ATA"
-    munin_plugin "smart_#{name}" do
-      target "smart_"
-      conf "smart.erb"
-      conf_variables :disk => name
-    end
-  else
-    munin_plugin "smart_#{name}" do
-      action :delete
-    end
-  end
-end
-

 munin_plugin "swap"
 munin_plugin "tcp"
 munin_plugin "threads"
 munin_plugin "swap"
 munin_plugin "tcp"
 munin_plugin "threads"