Update rubocop configuration for COP renames

[chef.git] / cookbooks / planet / files / default / replication-bin / replicate-changesets

diff --git a/cookbooks/planet/files/default/replication-bin/replicate-changesets b/cookbooks/planet/files/default/replication-bin/replicate-changesets
old mode 100644 (file)
new mode 100755 (executable)
index 455fcbc..29131b2
--- a/cookbooks/planet/files/default/replication-bin/replicate-changesets
+++ b/cookbooks/planet/files/default/replication-bin/replicate-changesets
@@ -100,7 +100,7 @@ class ChangesetBuilder
     xml["comments_count"] = res.num_tuples.to_s
 
     # early return if there aren't any comments
     xml["comments_count"] = res.num_tuples.to_s
 
     # early return if there aren't any comments

-    return unless res.num_tuples > 0
+    return unless res.num_tuples.positive?

 
     discussion = XML::Node.new("discussion")
     res.each do |row|
 
     discussion = XML::Node.new("discussion")
     res.each do |row|


@@ -141,9 +141,9 @@ end
 # replicated to a file.
 class Replicator
   def initialize(config)
 # replicated to a file.
 class Replicator
   def initialize(config)

-    @config = YAML.load(File.read(config))
-    @state = YAML.load(File.read(@config["state_file"]))
-    @conn = PGconn.connect(@config["db"])
+    @config = YAML.safe_load(File.read(config))
+    @state = YAML.safe_load(File.read(@config["state_file"]), [Time])
+    @conn = PG::Connection.connect(@config["db"])

     # get current time from the database rather than the current system
     @now = @conn.exec("select now() as now").map { |row| Time.parse(row["now"]) }[0]
   end
     # get current time from the database rather than the current system
     @now = @conn.exec("select now() as now").map { |row| Time.parse(row["now"]) }[0]
   end


@@ -167,7 +167,7 @@ class Replicator
     new_ids = @conn
               .exec("select distinct changeset_id from changeset_comments where created_at >= '#{last_run}' and created_at < '#{@now}' and visible")
               .map { |row| row["changeset_id"].to_i }
     new_ids = @conn
               .exec("select distinct changeset_id from changeset_comments where created_at >= '#{last_run}' and created_at < '#{@now}' and visible")
               .map { |row| row["changeset_id"].to_i }

-              .select { |c_id| !cs_ids.include?(c_id) }
+              .reject { |c_id| cs_ids.include?(c_id) }

 
     new_ids.each do |id|
       @conn
 
     new_ids.each do |id|
       @conn


@@ -187,8 +187,8 @@ class Replicator
     { "version" => "0.6",
       "generator" => "replicate_changesets.rb",
       "copyright" => "OpenStreetMap and contributors",
     { "version" => "0.6",
       "generator" => "replicate_changesets.rb",
       "copyright" => "OpenStreetMap and contributors",

-      "attribution" => "http://www.openstreetmap.org/copyright",
-      "license" => "http://opendatacommons.org/licenses/odbl/1-0/" }
+      "attribution" => "https://www.openstreetmap.org/copyright",
+      "license" => "https://opendatacommons.org/licenses/odbl/1-0/" }

       .each { |k, v| doc.root[k] = v }
 
     builder = ChangesetBuilder.new(@now, @conn)
       .each { |k, v| doc.root[k] = v }
 
     builder = ChangesetBuilder.new(@now, @conn)


@@ -268,18 +268,17 @@ class Replicator
       # move them into place later, to avoid in-progress
       # clashes, or people seeing incomplete files.
       begin
       # move them into place later, to avoid in-progress
       # clashes, or people seeing incomplete files.
       begin

+        changesets = open_changesets

         @state["sequence"] = sequence
         @state["last_run"] = @now
         @state["sequence"] = sequence
         @state["last_run"] = @now

-        changesets = open_changesets

 
         write_tmp_files!(changesets)
 
         move_tmp_files_into_place!
 
         fl.flock(File::LOCK_UN)
 
         write_tmp_files!(changesets)
 
         move_tmp_files_into_place!
 
         fl.flock(File::LOCK_UN)

-
-      rescue
-        STDERR.puts("Error! Couldn't update state.")
+      rescue StandardError
+        warn "Error! Couldn't update state."

         fl.flock(File::LOCK_UN)
         raise
       end
         fl.flock(File::LOCK_UN)
         raise
       end


@@ -291,6 +290,6 @@ begin
   rep = Replicator.new(ARGV[0])
   rep.save!
 rescue StandardError => e
   rep = Replicator.new(ARGV[0])
   rep.save!
 rescue StandardError => e

-  STDERR.puts "ERROR: #{e.message}"
+  warn "ERROR: #{e.message}"

   exit 1
 end
   exit 1
 end