nftables: allow 169.254.169.0/24 and set log level to notice

[chef.git] / cookbooks / networking / templates / default / nftables.conf.erb

diff --git a/cookbooks/networking/templates/default/nftables.conf.erb b/cookbooks/networking/templates/default/nftables.conf.erb
index 05984ac3ef5b9b08847d3fdc871b5521d9c26215..1ef38da7f544d85b39a4453a602d889ac0d5466f 100644 (file)
--- a/cookbooks/networking/templates/default/nftables.conf.erb
+++ b/cookbooks/networking/templates/default/nftables.conf.erb
@@ -1,10 +1,10 @@
 #!/usr/sbin/nft -f
 
-<%- unless @interfaces.empty? %>
+<% unless @interfaces.empty? -%>
 define external-interfaces = { <%= @interfaces.sort.uniq.join(", ") %> }
-<%- end %>
-
-define ip-private-addresses = { 0.0.0.0, 10.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, 172.16.0.0/12, 192.0.2.0/24, 192.168.0.0/16 }
+<% end -%>
+# Exclude 169.254.169.0/24 from ip-private-addresses as is widely by cloud providers.
+define ip-private-addresses = { 0.0.0.0, 10.0.0.0/8, 127.0.0.0/8, 169.254.0.0-169.254.168.255, 169.254.170.0-169.254.255.255, 172.16.0.0/12, 192.0.2.0/24, 192.168.0.0/16 }
 define ip-multicast-addresses = { 224.0.0.0/4 }
 define ip6-private-addresses = { 2001:db8::/32, fc00::/7 }
 define ip6-multicast-addresses = { ff00::/8 }
@@ -12,16 +12,16 @@ define ip6-multicast-addresses = { ff00::/8 }
 table inet chef-filter {
   set ip-osm-addresses {
     type ipv4_addr
-<%- unless Array(@hosts["inet"]).empty? %>
-    elements = { <%= Array(@hosts["inet"]).sort.join(", ") %> }
-<%- end %>
+<% unless Array(@hosts[:inet]).empty? -%>
+    elements = { <%= Array(@hosts[:inet]).sort.join(", ") %> }
+<% end -%>
   }
 
   set ip6-osm-addresses {
     type ipv6_addr
-<%- unless Array(@hosts["inet"]).empty? %>
-    elements = { <%= Array(@hosts["inet6"]).sort.join(", ") %> }
-<%- end %>
+<% unless Array(@hosts[:inet6]).empty? -%>
+    elements = { <%= Array(@hosts[:inet6]).sort.join(", ") %> }
+<% end -%>
   }
 
   set ip-blocklist {
@@ -46,43 +46,41 @@ table inet chef-filter {
     timeout 120s
   }
 
-<%- node[:networking][:firewall][:sets].each do |set| %>
-  set <%= set %> {
-<%- if set.end_with?("-ip") %>
-    type ipv4_addr
-<%- elsif set.end_with?("-ip6") %>
-    type ipv6_addr
-<%- end %>
-    flags dynamic
-<%- unless set.start_with?("connlimit-") %>
-    timeout 120s
-<%- end %>
+<% node[:networking][:firewall][:sets].each do |set| -%>
+  set <%= set[:name] %> {
+    type <%= set[:type] %>
+<% if set[:flags] -%>
+    flags <%= set[:flags].join(", ") %>
+<% end -%>
+<% if set[:timeout] -%>
+    timeout <%= set[:timeout] %>s
+<% end -%>
   }
 
-<%- end %>
+<% end -%>
 
-<%- node[:networking][:firewall][:helpers].each do |helper| %>
+<% node[:networking][:firewall][:helpers].each do |helper| -%>
   ct helper <%= helper[:name] %> {
     type "<%= helper[:helper] %>" protocol <%= helper[:protocol] %>
   }
 
-<%- end %>
+<% end -%>
   chain log-and-drop {
-    limit rate 1/second log
+    limit rate 1/second log level notice
     drop
   }
 
   chain log-and-reject {
-    limit rate 1/second log
+    limit rate 1/second log level notice
     reject
   }
 
   chain incoming {
-<%- if node[:networking][:firewall][:allowlist].empty? %>
+<% if node[:networking][:firewall][:allowlist].empty? -%>
     ip saddr { $ip-private-addresses, $ip-multicast-addresses } jump log-and-drop
-<%- else %>
+<% else -%>
     ip saddr { $ip-private-addresses, $ip-multicast-addresses } ip saddr != { <%= node[:networking][:firewall][:allowlist].sort.join(", ") %> } jump log-and-drop
-<%- end %>
+<% end -%>
     ip6 saddr { $ip6-private-addresses, $ip6-multicast-addresses } jump log-and-drop
 
     ip saddr @ip-blocklist jump log-and-drop
@@ -107,24 +105,24 @@ table inet chef-filter {
     tcp flags & (fin|psh|ack) == fin|psh jump log-and-drop
     tcp sport 0 tcp flags & (fin|syn|rst|ack) == syn jump log-and-drop
 
-<%- node[:networking][:firewall][:incoming].uniq.each do |rule| %>
+<% node[:networking][:firewall][:incoming].uniq.each do |rule| -%>
     <%= rule %>
-<%- end %>
+<% end -%>
 
     jump log-and-drop
   }
 
   chain outgoing {
-<%- if node[:networking][:firewall][:allowlist].empty? %>
+<% if node[:networking][:firewall][:allowlist].empty? -%>
     ip daddr { $ip-private-addresses } jump log-and-drop
-<%- else %>
+<% else -%>
     ip daddr { $ip-private-addresses } ip daddr != { <%= node[:networking][:firewall][:allowlist].sort.join(", ") %> } jump log-and-drop
-<%- end %>
+<% end -%>
     ip6 daddr { $ip6-private-addresses } jump log-and-drop
 
-<%- node[:networking][:firewall][:outgoing].each do |rule| %>
+<% node[:networking][:firewall][:outgoing].each do |rule| -%>
     <%= rule %>
-<%- end %>
+<% end -%>
 
     accept
   }
@@ -132,9 +130,9 @@ table inet chef-filter {
   chain input {
     type filter hook input priority filter;
 
-<%- unless @interfaces.empty? %>
+<% unless @interfaces.empty? -%>
     iifname { $external-interfaces } jump incoming
-<%- end %>
+<% end -%>
 
     accept
   }
@@ -142,10 +140,10 @@ table inet chef-filter {
   chain forward {
     type filter hook forward priority filter;
 
-<%- unless @interfaces.empty? %>
+<% unless @interfaces.empty? -%>
     iifname { $external-interfaces } jump incoming
     oifname { $external-interfaces } jump outgoing
-<%- end %>
+<% end -%>
 
     accept
   }
@@ -153,24 +151,24 @@ table inet chef-filter {
   chain output {
     type filter hook output priority filter;
 
-<%- unless @interfaces.empty? %>
+<% unless @interfaces.empty? -%>
     oifname { $external-interfaces } jump outgoing
-<%- end %>
+<% end -%>
 
     accept
   }
 }
-<%- if node[:roles].include?("gateway") %>
+<% if node[:roles].include?("gateway") -%>
 
 table ip chef-nat {
   chain postrouting {
     type nat hook postrouting priority srcnat;
 
-<%- node.interfaces(:role => :external, :family => :inet).each do |external| %>
-<%- node.interfaces(:role => :internal, :family => :inet).each do |internal| %>
-    oifname { <%= external[:interface] %> } ip saddr { <%= internal[:network] %>/<%= internal[:prefix] %> } snat <%= external[:address] %>
-<%- end %>
-<%- end %>
+<% node.interfaces(:role => :external).each do |external| -%>
+<% node.ipaddresses(:role => :internal, :family => :inet).each do |internal| -%>
+    oifname { <%= external[:interface] %> } ip saddr { <%= internal.subnet %> } snat <%= external[:inet][:address] %>
+<% end -%>
+<% end -%>
   }
 }
-<%- end %>
+<% end -%>