Fix new rubocop warnings

[chef.git] / cookbooks / tilelog / recipes / default.rb

diff --git a/cookbooks/tilelog/recipes/default.rb b/cookbooks/tilelog/recipes/default.rb
index f87a45af09df0a4fd03d071bd628159767d66521..8b4f91690ec6bcc01e94fd501570ef86407a7920 100644 (file)
--- a/cookbooks/tilelog/recipes/default.rb
+++ b/cookbooks/tilelog/recipes/default.rb
@@ -1,14 +1,14 @@
 #
-# Cookbook Name:: tilelog
+# Cookbook:: tilelog
 # Recipe:: default
 #
-# Copyright 2014, OpenStreetMap Foundation
+# Copyright:: 2014, OpenStreetMap Foundation
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
-#     http://www.apache.org/licenses/LICENSE-2.0
+#     https://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ -17,15 +17,19 @@
 # limitations under the License.
 #
 
+include_recipe "git"
 include_recipe "tools"
 
-package "gcc"
-package "make"
-package "autoconf"
-package "automake"
-package "libboost-filesystem-dev"
-package "libboost-system-dev"
-package "libboost-program-options-dev"
+package %w[
+  gcc
+  g++
+  make
+  autoconf
+  automake
+  libboost-filesystem-dev
+  libboost-program-options-dev
+  libboost-system-dev
+]
 
 tilelog_source_directory = node[:tilelog][:source_directory]
 tilelog_input_directory = node[:tilelog][:input_directory]
@@ -38,25 +42,25 @@ git tilelog_source_directory do
   revision "live"
   user "root"
   group "root"
-  notifies :run, "execute[tilelog-autogen]", :immediate
+  notifies :run, "execute[tilelog-autogen]", :immediately
 end
 
 execute "tilelog-autogen" do
   action :nothing
-  command "./autogen.sh"
+  command "autoreconf -i"
   cwd tilelog_source_directory
   user "root"
   group "root"
-  notifies :run, "execute[tilelog-configure]", :immediate
+  notifies :run, "execute[tilelog-configure]", :immediately
 end
 
 execute "tilelog-configure" do
   action :nothing
-  command "./configure --with-boost-libdir=/usr/lib"
+  command "./configure --with-boost-libdir=/usr/lib/x86_64-linux-gnu"
   cwd tilelog_source_directory
   user "root"
   group "root"
-  notifies :run, "execute[tilelog-build]", :immediate
+  notifies :run, "execute[tilelog-build]", :immediately
 end
 
 execute "tilelog-build" do
@@ -72,26 +76,25 @@ template "/usr/local/bin/tilelog" do
   source "tilelog.erb"
   owner "root"
   group "root"
-  mode 0755
-  variables {
-    :analyze_bin => "#{tilelog_source_directory}/openstreetmap-tile-analyze",
-    :input_dir => tilelog_input_directory,
-    :output_dir => tilelog_output_directory
-  }
+  mode "755"
+  variables :analyze_bin => "#{tilelog_source_directory}/openstreetmap-tile-analyze",
+            :input_dir => tilelog_input_directory,
+            :output_dir => tilelog_output_directory
 end
 
-template "/etc/cron.d/tilelog" do
-  source "tileog.cron.erb"
-  owner "root"
-  group "root"
-  mode 0644
+cron_d "tilelog" do
+  minute "17"
+  hour "22"
+  user "www-data"
+  command "/usr/local/bin/tilelog"
+  mailto "zerebubuth@gmail.com"
 end
 
 # resources related to the output of the analysis and where it
 # can be publicly downloaded.
 directory tilelog_output_directory do
-  action :create
   user "www-data"
   group "www-data"
-  mode 0755
+  mode "755"
+  recursive true
 end