hardware: do not fail if node[:hardware][:pci] is undefined (tests)

[chef.git] / cookbooks / munin / files / default / plugins / api_waits_

diff --git a/cookbooks/munin/files/default/plugins/api_waits_ b/cookbooks/munin/files/default/plugins/api_waits_
index 741f190f0f38123e575af404764f5063032a692d..3d511ec8cb5bc0582f54281c6cb5c9a5859b6567 100755 (executable)
--- a/cookbooks/munin/files/default/plugins/api_waits_
+++ b/cookbooks/munin/files/default/plugins/api_waits_
@@ -1,20 +1,20 @@
 #!/usr/bin/ruby
 
 #!/usr/bin/ruby
 

-require 'rubygems'
-require 'date'
-require 'hpricot'
-require 'open-uri'
+require "rubygems"
+require "date"
+require "hpricot"
+require "open-uri"

 
 def uri_and_times_from_status(server)
   file = open("http://#{server}/server-status").read
   doc = Hpricot.parse(file)
 
 def uri_and_times_from_status(server)
   file = open("http://#{server}/server-status").read
   doc = Hpricot.parse(file)

-  tables = doc / 'table'
-  rows = (tables[0] / 'tr')[1..-1]
-  data = rows.collect {|r| (r  / 'td').collect {|x| x.inner_html} }
+  tables = doc / "table"
+  rows = (tables[1] / "tr")[1..-1]
+  data = rows.collect { |r| (r / "td").collect(&:inner_html) }

   # filter where the PID is numeric, status is 'W' and host matches the server
   # filter where the PID is numeric, status is 'W' and host matches the server

-  matching_data = data.select {|r| (r[1].to_i > 0) && r[3].match(/W/) && r[11].match(server)}
+  matching_data = data.select { |r| r[1].to_i.positive? && r[3].match(/W/) && r[12].match(server) }

   # return URI and number of seconds processing for each request
   # return URI and number of seconds processing for each request

-  matching_data.collect {|r| [r[12], r[5].to_i]}
+  matching_data.collect { |r| [r[13], r[5].to_i] }

 end
 
 CALL_TYPES = {
 end
 
 CALL_TYPES = {


@@ -26,47 +26,46 @@ CALL_TYPES = {
   :trkpts => "GPX trackpoints calls",
   :web => "Web site traffic",
   :other => "Other API calls"
   :trkpts => "GPX trackpoints calls",
   :web => "Web site traffic",
   :other => "Other API calls"

-}
+}.freeze

 
 def categorise_uri(line)
   uri = line.split(" ")[1]
 
   case uri
 
 def categorise_uri(line)
   uri = line.split(" ")[1]
 
   case uri

-  when /api\/0\.6\/map/ then :map
-  when /api\/0\.6\/changeset\/[0-9]*\/upload/ then :upload
-  when /api\/0\.6\/amf/ then :amf
-  when /api\/0\.6\/(node|way|relation)\/[0-9]*\/history/ then :history
-  when /api\/0\.6\/(node|way|relation)\/[0-9]*\/full/ then :full
-  when /api\/0\.6\/trackpoints/ then :trkpts
-  when /api\/0\.6\// then :other
+  when %r{api/0\.6/map} then :map
+  when %r{api/0\.6/changeset/[0-9]*/upload/} then :upload
+  when %r{api/0\.6/amf} then :amf
+  when %r{api/0\.6/(node|way|relation)/[0-9]*/history} then :history
+  when %r{api/0\.6/(node|way|relation)/[0-9]*/full} then :full
+  when %r{api/0\.6/trackpoints} then :trkpts
+  when %r{api/0\.6/} then :other

   else :web
   end
 end
 
   else :web
   end
 end
 

-server = $0.match("api_waits_(.*)")[1]
+server = $PROGRAM_NAME.match("api_waits_(.*)")[1]

 
 

-if ARGV[0] == 'config'
+if ARGV[0] == "config"

   puts "graph_title Wait times for active requests"
   puts "graph_vlabel Average time of requests"
   puts "graph_category api"
   CALL_TYPES.each { |k, v| puts "#{k}.label #{v}" }
 
 else
   puts "graph_title Wait times for active requests"
   puts "graph_vlabel Average time of requests"
   puts "graph_category api"
   CALL_TYPES.each { |k, v| puts "#{k}.label #{v}" }
 
 else

-  counts = uri_and_times_from_status(server).
-      collect {|x,y| [categorise_uri(x), y]}.
-      inject(Hash.new) do |h, e|
+  counts = uri_and_times_from_status(server)
+           .collect { |x, y| [categorise_uri(x), y] }
+           .each_with_object({}) do |e, h|

     category, time = e
     category, time = e

-    if h.has_key? category
+    if h.key? category

       h[category] += [time]
     else
       h[category] = [time]
     end
       h[category] += [time]
     else
       h[category] = [time]
     end

-    h

   end
 
   end
 

-  CALL_TYPES.keys.each do |type|
+  CALL_TYPES.each_key do |type|

     count = counts[type] || [0]
     count = counts[type] || [0]

-    avg = count.inject(0){|x,y|x+y} / (1.0 * count.length)
+    avg = count.inject(0) { |acc, elem| acc + elem } / (1.0 * count.length)

     puts "#{type}.value #{avg}"
   end
 end
     puts "#{type}.value #{avg}"
   end
 end