X-Git-Url: https://git.openstreetmap.org./chef.git/blobdiff_plain/fb1f1d56e8d8a6a86b79c71546e6c114fec2640c..388a527fdf388cd5383b978d0cb5406d787b8661:/cookbooks/rsyncd/recipes/default.rb

diff --git a/cookbooks/rsyncd/recipes/default.rb b/cookbooks/rsyncd/recipes/default.rb
index 18eb23082..b14e2f405 100644
--- a/cookbooks/rsyncd/recipes/default.rb
+++ b/cookbooks/rsyncd/recipes/default.rb
@@ -25,15 +25,19 @@ hosts_deny = {}
 node[:rsyncd][:modules].each do |name, details|
   hosts_allow[name] = details[:hosts_allow] || []
 
-  hosts_allow[name] |= search(:node, details[:nodes_allow]).collect do |n|
-    n.ipaddresses(:role => :external)
-  end.flatten if details[:nodes_allow]
+  if details[:nodes_allow]
+    hosts_allow[name] |= search(:node, details[:nodes_allow]).collect do |n|
+      n.ipaddresses(:role => :external)
+    end.flatten
+  end
 
   hosts_deny[name] = details[:hosts_deny] || []
 
+  next unless details[:nodes_deny]
+
   hosts_deny[name] |= search(:node, details[:nodes_deny]).collect do |n|
     n.ipaddresses(:role => :external)
-  end.flatten if details[:nodes_deny]
+  end.flatten
 end
 
 package "rsync"
@@ -47,7 +51,7 @@ template "/etc/default/rsync" do
   source "rsync.erb"
   owner "root"
   group "root"
-  mode 0644
+  mode 0o644
   notifies :restart, "service[rsync]"
 end
 
@@ -55,7 +59,7 @@ template "/etc/rsyncd.conf" do
   source "rsyncd.conf.erb"
   owner "root"
   group "root"
-  mode 0644
+  mode 0o644
   variables :hosts_allow => hosts_allow, :hosts_deny => hosts_deny
 end