From: Tom Hughes <tom@compton.nu>
Date: Wed, 31 Dec 2014 13:58:13 +0000 (+0000)
Subject: Only mail the planetdump output if it is non-empty
X-Git-Url: https://git.openstreetmap.org./chef.git/commitdiff_plain/55169c67be099715946e075ec7645286741042e3

Only mail the planetdump output if it is non-empty
---

diff --git a/cookbooks/planet/templates/default/planetdump.erb b/cookbooks/planet/templates/default/planetdump.erb
index dff206b35..3670c72a0 100644
--- a/cookbooks/planet/templates/default/planetdump.erb
+++ b/cookbooks/planet/templates/default/planetdump.erb
@@ -19,10 +19,10 @@ date="${year:2:2}${BASH_REMATCH[2]}${BASH_REMATCH[3]}"
 # Check the lock
 if [ -f /tmp/planetdump.lock ]; then
     if [ "$(ps -p `cat /tmp/planetdump.lock` | wc -l)" -gt 1 ]; then
-	echo "Error: Another planetdump is running"
-	exit 1
+        echo "Error: Another planetdump is running"
+        exit 1
     else
-	rm /tmp/planetdump.lock
+        rm /tmp/planetdump.lock
     fi
 fi
 
@@ -31,18 +31,25 @@ fi
 # and incron doesn't yet support MAILTO like cron does. The
 # command below appears to work in bash as well as dash.
 logfile="/tmp/planetdump.log.$$"
-exec > $logfile 2>&1
+exec > "${logfile}" 2>&1
 
-# Create Lock
+# Create lock file
 echo $$ > /tmp/planetdump.lock
 
 # Define cleanup function
 function cleanup {
+    # Remove the lock file
     rm /tmp/planetdump.lock
+
     # Send an email with the output, since incron doesn't yet
-    # support doing this in the incrontab.
-    /usr/bin/mailx -s "Planet dump output: ${file}" zerebubuth@gmail.com < $logfile
-    rm $logfile
+    # support doing this in the incrontab
+    if [[ -s "$logfile" ]]
+    then
+        mailx -s "Planet dump output: ${file}" zerebubuth@gmail.com < "${logfile}"
+    fi
+
+    # Remove the log file
+    rm -f "${logfile}"
 }
 
 # Remove lock on exit