From: Tom Hughes <tom@compton.nu>
Date: Thu, 14 Nov 2024 09:02:24 +0000 (+0000)
Subject: Disable collection of bgwriter statistics for postgres 17
X-Git-Url: https://git.openstreetmap.org./chef.git/commitdiff_plain/da3e292dc325b96df2c805d729427c8bf6741b81?hp=1fdcbdc3d4f9fa8b6f371053d36c10a21e27005d

Disable collection of bgwriter statistics for postgres 17

https://github.com/prometheus-community/postgres_exporter/issues/1060
---

diff --git a/cookbooks/postgresql/recipes/default.rb b/cookbooks/postgresql/recipes/default.rb
index eae492f16..742941ee9 100644
--- a/cookbooks/postgresql/recipes/default.rb
+++ b/cookbooks/postgresql/recipes/default.rb
@@ -124,20 +124,24 @@ clusters.each do |name, details|
     not_if { ::File.exist?("/var/lib/postgresql/#{name}/standby.signal") }
   end
 
+  exporter_options = %w[
+    --collector.database_wraparound
+    --collector.long_running_transactions
+    --collector.process_idle
+    --collector.stat_activity_autovacuum
+    --collector.stat_wal_receiver
+    --collector.statio_user_indexes
+  ]
+
+  exporter_options << "--no-collector.stat_bgwriter" if details[:version] >= 17
+
   prometheus_exporter "postgres" do
     port 10000 + details[:port].to_i
     service "postgres-#{prometheus_suffix}"
     labels "cluster" => name
     scrape_interval "1m"
     scrape_timeout "1m"
-    options %w[
-      --collector.database_wraparound
-      --collector.long_running_transactions
-      --collector.process_idle
-      --collector.stat_activity_autovacuum
-      --collector.stat_wal_receiver
-      --collector.statio_user_indexes
-    ]
+    options exporter_options
     environment "DATA_SOURCE_NAME" => "postgres:///#{prometheus_database}?host=/run/postgresql&port=#{details[:port]}&user=prometheus&password=#{passwords['prometheus']}"
     restrict_address_families "AF_UNIX"
     subscribes :restart, "template[/etc/prometheus/exporters/postgres_queries.yml]"