"yarn test" should run "yarn build" first to avoid outdated bundle (#147)

[nominatim-ui.git] / CONTRIBUTE.md

diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md
index e8c56e3b08d4c10c8be20cfe0ecdd3ecaa4344d0..7ef727d4c31156f26520a1ef0cbe6224682c81b5 100644 (file)
--- a/CONTRIBUTE.md
+++ b/CONTRIBUTE.md
@@ -4,14 +4,15 @@
 
 ## Background
 
 
 ## Background
 

+Uses [Svelte](https://svelte.dev/) framework,
+[Leaflet](https://leafletjs.com/) for map interaction,
+[Bootstrap](https://getbootstrap.com/) for layout styling.
+

 The user interface used to be included in the geocoder. Thus the
 The user interface used to be included in the geocoder. Thus the

-first version avoid being a redesign and still uses some of the
+first version avoided being a redesign and still uses some of the

 same configuration values. Version 2 was a full refactor using
 Svelte. Version 3 added theme and easier configuration.
 
 same configuration values. Version 2 was a full refactor using
 Svelte. Version 3 added theme and easier configuration.
 

-Uses [svelte](https://svelte.dev/) framework,
-[leaflet](https://leafletjs.com/) for map interaction,
-[bootstrap](https://getbootstrap.com/) for layout styling.

 
 
 ## Building the frontend
 
 
 ## Building the frontend


@@ -28,26 +29,35 @@ Uses [svelte](https://svelte.dev/) framework,
    yarn dev
    ```
    which will start a webserver on port 9880 and auto-reloads
    yarn dev
    ```
    which will start a webserver on port 9880 and auto-reloads

-   whenever you edit files.
+   whenever you edit files. Configuration in `rollup.config.js`.

 
 ## Testing
 
 
 ## Testing
 

-* Run syntax linter
+The `test/` setup uses [Mocha](https://mochajs.org/) to run tests. Tests use [Puppeteer](https://pptr.dev/) to control a Google Chrome headless browser and evaluate with [Assert](https://nodejs.org/api/assert.html).
+
+
+* Run integration test suite (configuration in `.mocharc.js`)
+
+   ```
+   yarn test
+   ```
+
+* Run syntax linter (configuration in `.eslint.js`)

 
    ```
    yarn lint
    ```
 
 
    ```
    yarn lint
    ```
 

+

 ## Prepare a release
 
 1. Update version number in `package.json` file
 
 2. Update `CHANGES.md` file
 
 ## Prepare a release
 
 1. Update version number in `package.json` file
 
 2. Update `CHANGES.md` file
 

-3. Run `yarn build` to make sure the `dist/build/` files don't contain lifereload.js
-
-4. Commit your changes: `git add... `, `git commit ...`, `git push ...` etc
+3. Commit your changes: `git add... `, `git commit ...`, `git push ...` etc

 
 

-5. Tag release: `git tag THE_VERSION_NUMBER`, `git push --tags`
+4. Tag release: `git tag THE_VERSION_NUMBER`, `git push --tags`

 
 

-6. Upload release
\ No newline at end of file
+5. Create release on https://github.com/osm-search/nominatim-ui/releases
+   This (a triggered Github Action) will run `yarn build` and add the `dist/build/bundle.*` files.