Merge remote-tracking branch 'upstream/master'

[nominatim-ui.git] / test / details.js

diff --git a/test/details.js b/test/details.js
index f2f8eb6347a7c937cc7902d62d7d909b702490e7..2d1094d78f3cf59372c4287434de0c238a6b6910 100644 (file)
--- a/test/details.js
+++ b/test/details.js
@@ -1,4 +1,6 @@
-const assert = require('assert');
+import assert from 'assert';
+
+const reverse_only = !!process.env.REVERSE_ONLY;
 
 describe('Details Page', function () {
   let page;
@@ -22,7 +24,7 @@ describe('Details Page', function () {
     before(async function () {
       page = await browser.newPage();
       await page.goto('http://localhost:9999/details.html');
-      await page.type('input[type=edit]', 'n3');
+      await page.type('input[type=edit]', 'N6');
       await page.click('button[type=submit]');
       await page.waitForSelector('#api-request');
     });
@@ -39,58 +41,57 @@ describe('Details Page', function () {
     });
   });
 
-  describe('With search - Eiffel Tower', function () {
+  describe('With search - Vaduz (Liechtenstein)', function () {
     before(async function () {
       page = await browser.newPage();
       await page.goto('http://localhost:9999/details.html');
-      await page.type('input[type=edit]', 'W5013364');
+      await page.type('input[type=edit]', 'R1155956');
       await page.click('button[type=submit]');
-      await page.waitForSelector('.container .row');
+      await page.waitForSelector('table#address');
     });
 
     after(async function () {
       await page.close();
     });
 
-    it('should have header title as Eiffel Tower', async function () {
+    it('should have header title', async function () {
       let page_header = await page.$eval('.container h1', el => el.textContent);
 
-      assert.ok(page_header.includes('Eiffel Tower'));
+      assert.ok(page_header.includes('Vaduz'));
     });
 
-    it('should have link to https://www.openstreetmap.org/way/5013364', async function () {
+    it('should have OSM link', async function () {
+      const url = 'https://www.openstreetmap.org/relation/1155956';
 
-      assert.strictEqual((await page.$$('a[href="https://www.openstreetmap.org/way/5013364"]')).length, 1);
+      assert.strictEqual((await page.$$eval(`a[href="${url}"]`, (links) => links.length)), 2);
     });
 
-    it('should change page url and add new header on clicking display keywords', async function () {
-      let current_url;
-      let display_headers;
-      let [display_keywords_btn] = await page.$x("//a[contains(text(), 'display keywords')]");
+    // Reverse-only installation have no search index, therefore no keywords
+    if (!reverse_only) {
+      it('should change url and add new header on clicking display keywords', async function () {
+        let current_url;
+        let display_headers;
+        let [display_keywords_btn] = await page.$$(
+          "xpath/.//a[contains(text(), 'display keywords')]"
+        );
 
-      await display_keywords_btn.click();
-      await page.waitForNavigation();
+        await display_keywords_btn.evaluate(node => node.click());
+        await page.waitForNavigation();
 
-      current_url = new URL(await page.url());
-      assert.strictEqual(current_url.searchParams.get('keywords'), '1');
+        current_url = new URL(await page.url());
+        assert.strictEqual(current_url.searchParams.get('keywords'), '1');
 
-      await page.waitForSelector('h3');
-      display_headers = await page.$$eval('h3', elements => elements.map(el => el.textContent));
-      assert.deepStrictEqual(display_headers, ['Name Keywords', 'Address Keywords']);
-    });
-
-    it('should change page url on clicking display child places', async function () {
-      let current_url;
-      let [child_places_btn] = await page.$x("//a[contains(text(), 'display child places')]");
+        await page.waitForSelector('h3');
+        display_headers = await page.$$eval('h3', elements => elements.map(el => el.textContent));
+        assert.deepStrictEqual(display_headers, ['Name Keywords', 'Address Keywords']);
 
-      await child_places_btn.click();
-      await page.waitForNavigation();
+        let page_content = await page.$eval('body', el => el.textContent);
+        assert.ok(page_content.includes('vadouz')); // one of the name keywords
+      });
+    }
 
-      current_url = new URL(await page.url());
-      assert.strictEqual(current_url.searchParams.get('hierarchy'), '1');
-    });
 
-    it('should have case-insenstive input and can navigate to other details', async function () {
+    it('should support case-insensitive search, can navigate to new page', async function () {
       let input_field = await page.$('input[type=edit]');
       await input_field.click({ clickCount: 3 });
       await input_field.type('w375257537');
@@ -101,6 +102,38 @@ describe('Details Page', function () {
     });
   });
 
+  describe('With street search - a place that is parent of buildings', function () {
+    before(async function () {
+      page = await browser.newPage();
+      await page.goto('http://localhost:9999/details.html?osmtype=W&osmid=32703083');
+      await page.waitForSelector('.container .row');
+    });
+
+    after(async function () {
+      await page.close();
+    });
+
+    it('should change page url on clicking display child places', async function () {
+      let page_content = await page.$eval('body', el => el.textContent);
+      assert.ok(page_content.includes('Gafleistrasse'));
+
+      let current_url;
+      let [child_places_btn] = await page.$$(
+        "xpath/.//a[contains(text(), 'display child places')]"
+      );
+
+      await child_places_btn.evaluate(node => node.click());
+      await page.waitForNavigation();
+      await page.waitForSelector('table#address');
+
+      current_url = new URL(await page.url());
+      assert.strictEqual(current_url.searchParams.get('hierarchy'), '1');
+
+      page_content = await page.$eval('body', el => el.textContent);
+      assert.ok(page_content.includes('bus_stop')); // parent of several bus stops
+    });
+  });
+
   describe('Place without name, keywords, hierarchy', function () {
     // e.g. a numeric house number
     before(async function () {
@@ -117,7 +150,9 @@ describe('Details Page', function () {
       let page_content = await page.$eval('body', el => el.textContent);
 
       assert.ok(page_content.includes('Name No Name'));
-      assert.ok(page_content.includes('Place has no keywords'));
+      if (!process.env.REVERSE_ONLY) {
+        assert.ok(page_content.includes('Place has no keywords'));
+      }
       assert.ok(page_content.includes('Place is not parent of other places'));
     });
   });