cut lines at 100, spacing changes for linter

[nominatim-ui.git] / src / lib / api_utils.js

diff --git a/src/lib/api_utils.js b/src/lib/api_utils.js
index 9dff8771818f23955d240a952cd0326c5f7b4f02..defaf25f5f2edc7161e6f80e2da1ab652bc39f96 100644 (file)
--- a/src/lib/api_utils.js
+++ b/src/lib/api_utils.js
@@ -10,17 +10,46 @@ function api_request_progress(status) {
 export async function fetch_from_api(endpoint_name, params, callback) {
   var api_url = generate_nominatim_api_url(endpoint_name, params);
 
 export async function fetch_from_api(endpoint_name, params, callback) {
   var api_url = generate_nominatim_api_url(endpoint_name, params);
 

+  // For the test suite:
+  // If mock_http_status URL parameter is set we call an external webservice. First
+  // https://httpbin.org/#/Status_codes but we saw timeouts. Now beeceptor.com
+  // If that turns out unreliable or expensive (only 50/day free) we might have to
+  // start running a local webserver for the test suite
+  var tmp_params = new URLSearchParams(window.location.search);
+  if (tmp_params && tmp_params.get('mock_http_status')) {
+    api_url = 'https://nominatim-ui.free.beeceptor.com/status/' + parseInt(tmp_params.get('mock_http_status'), 10);
+  }
+

   api_request_progress('start');
   if (endpoint_name !== 'status') last_api_request_url_store.set(null);
 
   try {
   api_request_progress('start');
   if (endpoint_name !== 'status') last_api_request_url_store.set(null);
 
   try {

-    await fetch(api_url)
-      .then(response => response.json())
-      .then(data => {
-        if (data.error) {
-          error_store.set(data.error.message);
+    await fetch(api_url, { headers: Nominatim_Config.Nominatim_API_Endpoint_Headers || {} })
+      .then(async (response) => {
+        if (!((response.status >= 200 && response.status < 300) || response.status === 404)) {
+          error_store.set(`Error fetching data from ${api_url} (${response.statusText})`);
+          return undefined;
+        }
+
+        // Parse JSON here instead of returning a promise so we can catch possible
+        // errors.
+        var data;
+        try {
+          data = await response.json();
+        } catch (err) {
+          // e.g. 'JSON.parse: unexpected non-whitespace character after JSON data at line 1'
+          error_store.set(`Error parsing JSON data from ${api_url} (${err})`);
+          return undefined;
+        }
+        return data;
+      })
+      .then((data) => {
+        if (data) {
+          if (data.error) {
+            error_store.set(data.error.message);
+          }
+          callback(data);

         }
         }

-        callback(data);

         api_request_progress('finish');
       });
   } catch (error) {
         api_request_progress('finish');
       });
   } catch (error) {


@@ -47,7 +76,7 @@ export async function fetch_content_into_element(url, dom_element) {
     await fetch(url)
       .then(response => response.text())
       .then(html => {
     await fetch(url)
       .then(response => response.text())
       .then(html => {

-        html = html.replace('Nominatim_API_Endpoint', Nominatim_Config.Nominatim_API_Endpoint);
+        html = html.replace('Nominatim_API_Endpoint', generate_nominatim_endpoint_url());

         dom_element.innerHTML = html;
         fetch_content_cache[url] = html;
       });
         dom_element.innerHTML = html;
         fetch_content_cache[url] = html;
       });


@@ -56,13 +85,36 @@ export async function fetch_content_into_element(url, dom_element) {
   }
 }
 
   }
 }
 

+function generate_nominatim_endpoint_url(endpoint_name) {
+  var conf_endpoint = Nominatim_Config.Nominatim_API_Endpoint;
+
+  if (typeof conf_endpoint === 'function') {
+    return conf_endpoint(endpoint_name);
+  }
+
+  if (!endpoint_name) return conf_endpoint;
+
+  return conf_endpoint + endpoint_name + '.php';
+}
+

 function generate_nominatim_api_url(endpoint_name, params) {
 function generate_nominatim_api_url(endpoint_name, params) {

-  return Nominatim_Config.Nominatim_API_Endpoint + endpoint_name + '.php?'
+  // default value for /search
+  if (params.dedupe === 1) delete params.dedupe;
+
+  extend_parameters(params, Nominatim_Config.Nominatim_API_Endpoint_Params);
+  return generate_nominatim_endpoint_url(endpoint_name)
+         + '?'

          + Object.keys(clean_up_parameters(params)).map((k) => {
            return encodeURIComponent(k) + '=' + encodeURIComponent(params[k]);
          }).join('&');
 }
 
          + Object.keys(clean_up_parameters(params)).map((k) => {
            return encodeURIComponent(k) + '=' + encodeURIComponent(params[k]);
          }).join('&');
 }
 

+function extend_parameters(params, params2) {
+  var param_names = Object.keys(params2);
+  for (var i = 0; i < param_names.length; i += 1) {
+    params[param_names[i]] = params2[param_names[i]];
+  }
+}

 
 function clean_up_parameters(params) {
   // `&a=&b=&c=1` => '&c=1'
 
 function clean_up_parameters(params) {
   // `&a=&b=&c=1` => '&c=1'