From: marc tobias <mtmail@gmx.net>
Date: Mon, 26 Jun 2023 22:14:00 +0000 (+0200)
Subject: fix Svelte accessibily linter warnings, no more autofocus
X-Git-Url: https://git.openstreetmap.org./nominatim-ui.git/commitdiff_plain/51dab2d73981ff460f7ddc4408df9767ce81ce7a?ds=sidebyside

fix Svelte accessibily linter warnings, no more autofocus
---

diff --git a/src/components/Map.svelte b/src/components/Map.svelte
index dd2a1ae..37166f6 100644
--- a/src/components/Map.svelte
+++ b/src/components/Map.svelte
@@ -184,9 +184,9 @@
 
 <MapPosition />
 <div id="map" use:mapAction />
-<div id="show-map-position" class="leaflet-bar btn btn-sm btn-outline-secondary"
+<button id="show-map-position" class="leaflet-bar btn btn-sm btn-outline-secondary"
       on:click|stopPropagation={show_map_position_click}
->show map bounds</div>
+>show map bounds</button>
 
 <style>
   #map {
diff --git a/src/components/ResultsList.svelte b/src/components/ResultsList.svelte
index 3b6c713..0e6b144 100644
--- a/src/components/ResultsList.svelte
+++ b/src/components/ResultsList.svelte
@@ -59,7 +59,8 @@
       <div class="result"
            class:highlight={iResNum === iHighlightNum}
            data-position="{iResNum}"
-           on:click|stopPropagation={handleClick}>
+           on:click|stopPropagation={handleClick}
+           on:keypress|stopPropagation={handleClick}>
         <div style="float:right">
           <MapIcon aPlace={aResult} />
         </div>
diff --git a/src/components/SearchSection.svelte b/src/components/SearchSection.svelte
index a43ad75..efffc0f 100644
--- a/src/components/SearchSection.svelte
+++ b/src/components/SearchSection.svelte
@@ -99,8 +99,7 @@
                type="text"
                class="form-control form-control-sm"
                placeholder="Search"
-               value="{api_request_params.q || ''}"
-               autofocus />
+               value="{api_request_params.q || ''}" />
       </div>
       <div class="col-auto">
         <button type="submit" class="btn btn-primary btn-sm mx-1">Search</button>
diff --git a/src/components/SearchSectionDetails.svelte b/src/components/SearchSectionDetails.svelte
index 276b56a..def8873 100644
--- a/src/components/SearchSectionDetails.svelte
+++ b/src/components/SearchSectionDetails.svelte
@@ -30,8 +30,7 @@
       <input type="edit"
              class="form-control form-control-sm me-1"
              pattern="^[NWRnwr]?[0-9]+$|.*openstreetmap.*"
-             value="{api_request_params.osmtype || ''}{api_request_params.osmid || ''}{api_request_params.place_id || ''}"
-             autofocus />
+             value="{api_request_params.osmtype || ''}{api_request_params.osmid || ''}{api_request_params.place_id || ''}" />
       </div>
     <div class="col-auto">
       <button type="submit" class="btn btn-primary btn-sm">Show</button>
diff --git a/src/components/SearchSectionReverse.svelte b/src/components/SearchSectionReverse.svelte
index 2f53f39..46bb2b9 100644
--- a/src/components/SearchSectionReverse.svelte
+++ b/src/components/SearchSectionReverse.svelte
@@ -49,15 +49,14 @@
            class="form-control form-control-sm d-inline"
            placeholder="latitude"
            pattern="^-?\d+(\.\d+)?$"
-           autofocus
            bind:value={lat}
            on:change={maybeSplitLatitude} />
   </div>
   <div class="col-auto">
-    <a id="switch-coords"
+    <button id="switch-coords"
        on:click|preventDefault|stopPropagation={() => gotoCoordinates(lon, lat)}
        class="btn btn-outline-secondary btn-sm"
-       title="switch lat and lon">&lt;&gt;</a>
+       title="switch lat and lon">&lt;&gt;</button>
   </div>
   <div class="col-auto">
     <label for="reverse-lon">lon</label>