From: Marc Tobias Metten <mtmail@gmx.net>
Date: Thu, 8 Mar 2018 21:06:57 +0000 (+0100)
Subject: cleanup API request URL from unset parameters
X-Git-Url: https://git.openstreetmap.org./nominatim-ui.git/commitdiff_plain/6c0089dd99c1fc9b4d7d9d9772a6825f6c3b3bf3?ds=inline;hp=--cc

cleanup API request URL from unset parameters
---

6c0089dd99c1fc9b4d7d9d9772a6825f6c3b3bf3
diff --git a/TODO.md b/TODO.md
index 22d3fd4..346e664 100644
--- a/TODO.md
+++ b/TODO.md
@@ -34,7 +34,6 @@ http://localhost:8000/reverse.html?format=html&lat=52.3755991766591&lon=7.646484
 
 ## Nice-to-have
 
-* don't show unset parameters in URL, e.g. `&a=&b=&c=1` => '&c='
 * different content for official OSM, e.g. github urls
 * set HTML title
 * cache `update_data_date` result
diff --git a/src/assets/js/base.js b/src/assets/js/base.js
index 02c228a..2aed93b 100644
--- a/src/assets/js/base.js
+++ b/src/assets/js/base.js
@@ -46,6 +46,12 @@ function map_viewbox_as_string() {
 *********************************************************/
 
 function fetch_from_api(endpoint_name, params, callback) {
+
+    // `&a=&b=&c=1` => '&c='
+    for(var k in params) {
+        if (typeof(params[k]) === 'undefined' || params[k] === '' || params[k] === null ) delete params[k];
+    }
+
     var api_url = get_config_value('Nominatim_API_Endpoint') + endpoint_name + '.php?' + $.param(params);
     if (endpoint_name !== 'status') {
         $('#api-request-link').attr('href', api_url);