From: marc tobias <mtmail@gmx.net>
Date: Mon, 10 Aug 2020 13:56:11 +0000 (+0200)
Subject: Add a &debug=1 API link in the header instead of redirecting
X-Git-Url: https://git.openstreetmap.org./nominatim-ui.git/commitdiff_plain/8af0564fcfd167565cdb6488fe30a2cfdb0740e0

Add a &debug=1 API link in the header instead of redirecting
---

diff --git a/dist/assets/css/common.css b/dist/assets/css/common.css
index ab814d7..1141b33 100755
--- a/dist/assets/css/common.css
+++ b/dist/assets/css/common.css
@@ -32,6 +32,7 @@ header #last-updated {
   font-size: 0.7em;
   white-space: nowrap;
   text-align: center;
+  display: none;
 }
 
 header .dropdown-menu {
diff --git a/dist/assets/js/nominatim-ui.js b/dist/assets/js/nominatim-ui.js
index e36e866..406cf23 100644
--- a/dist/assets/js/nominatim-ui.js
+++ b/dist/assets/js/nominatim-ui.js
@@ -96,18 +96,36 @@ function generate_full_api_url(endpoint_name, params) {
   return api_url;
 }
 
-function fetch_from_api(endpoint_name, params, callback) {
+function update_last_updated(endpoint_name, params) {
+  if (endpoint_name === 'status') return;
+
   var api_url = generate_full_api_url(endpoint_name, params);
-  if (endpoint_name !== 'status') {
-    $('#api-request-link').attr('href', api_url);
+  $('#last-updated').show();
+
+  $('#api-request a').attr('href', api_url);
+  $('#api-request').show();
+
+  if (endpoint_name === 'search' || endpoint_name === 'reverse') {
+    $('#api-request-debug a').attr('href', api_url + '&debug=1');
+    $('#api-request-debug').show();
+  } else {
+    $('#api-request-debug').hide();
   }
+}
+
+function fetch_from_api(endpoint_name, params, callback) {
+  var api_url = generate_full_api_url(endpoint_name, params);
   $.get(api_url, function (data) {
+    if (endpoint_name !== 'status') {
+      update_last_updated(endpoint_name, params);
+    }
     callback(data);
   });
 }
 
 function update_data_date() {
   fetch_from_api('status', { format: 'json' }, function (data) {
+    $('#last-updated').show();
     $('#data-date').text(data.data_updated);
   });
 }
@@ -586,11 +604,6 @@ function search_page_load() {
       format: 'jsonv2'
     };
 
-    if (search_params.get('debug') === '1') {
-      window.location.href = generate_full_api_url('reverse', api_request_params);
-      return;
-    }
-
     context = {
       // aPlace: aPlace,
       fLat: api_request_params.lat,
@@ -655,11 +668,6 @@ function search_page_load() {
       format: 'jsonv2'
     };
 
-    if (search_params.get('debug') === '1') {
-      window.location.href = generate_full_api_url('search', api_request_params);
-      return;
-    }
-
     context = {
       sQuery: api_request_params.q,
       sViewBox: search_params.get('viewbox'),
@@ -792,6 +800,7 @@ jQuery(document).ready(function () {
 
   function is_relative_url(url) {
     if (!url) return false;
+    if (url.match(/debug=1/)) return false;
     if (url.indexOf('?') === 0) return true;
     if (url.indexOf('/') === 0) return true;
     if (url.indexOf('#') === 0) return false;
diff --git a/dist/deletable.html b/dist/deletable.html
index e323dcc..ac074d3 100644
--- a/dist/deletable.html
+++ b/dist/deletable.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">
diff --git a/dist/details.html b/dist/details.html
index e323dcc..ac074d3 100644
--- a/dist/details.html
+++ b/dist/details.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">
diff --git a/dist/polygons.html b/dist/polygons.html
index e323dcc..ac074d3 100644
--- a/dist/polygons.html
+++ b/dist/polygons.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">
diff --git a/dist/reverse.html b/dist/reverse.html
index e323dcc..ac074d3 100644
--- a/dist/reverse.html
+++ b/dist/reverse.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">
diff --git a/dist/search.html b/dist/search.html
index e323dcc..ac074d3 100644
--- a/dist/search.html
+++ b/dist/search.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">
diff --git a/src/assets/css/common.css b/src/assets/css/common.css
index ab814d7..1141b33 100755
--- a/src/assets/css/common.css
+++ b/src/assets/css/common.css
@@ -32,6 +32,7 @@ header #last-updated {
   font-size: 0.7em;
   white-space: nowrap;
   text-align: center;
+  display: none;
 }
 
 header .dropdown-menu {
diff --git a/src/assets/js/base.js b/src/assets/js/base.js
index 0a5b2c8..0be31f4 100644
--- a/src/assets/js/base.js
+++ b/src/assets/js/base.js
@@ -96,18 +96,36 @@ function generate_full_api_url(endpoint_name, params) {
   return api_url;
 }
 
-function fetch_from_api(endpoint_name, params, callback) {
+function update_last_updated(endpoint_name, params) {
+  if (endpoint_name === 'status') return;
+
   var api_url = generate_full_api_url(endpoint_name, params);
-  if (endpoint_name !== 'status') {
-    $('#api-request-link').attr('href', api_url);
+  $('#last-updated').show();
+
+  $('#api-request a').attr('href', api_url);
+  $('#api-request').show();
+
+  if (endpoint_name === 'search' || endpoint_name === 'reverse') {
+    $('#api-request-debug a').attr('href', api_url + '&debug=1');
+    $('#api-request-debug').show();
+  } else {
+    $('#api-request-debug').hide();
   }
+}
+
+function fetch_from_api(endpoint_name, params, callback) {
+  var api_url = generate_full_api_url(endpoint_name, params);
   $.get(api_url, function (data) {
+    if (endpoint_name !== 'status') {
+      update_last_updated(endpoint_name, params);
+    }
     callback(data);
   });
 }
 
 function update_data_date() {
   fetch_from_api('status', { format: 'json' }, function (data) {
+    $('#last-updated').show();
     $('#data-date').text(data.data_updated);
   });
 }
diff --git a/src/assets/js/controller.js b/src/assets/js/controller.js
index 364e8f2..56c7d00 100644
--- a/src/assets/js/controller.js
+++ b/src/assets/js/controller.js
@@ -22,6 +22,7 @@ jQuery(document).ready(function () {
 
   function is_relative_url(url) {
     if (!url) return false;
+    if (url.match(/debug=1/)) return false;
     if (url.indexOf('?') === 0) return true;
     if (url.indexOf('/') === 0) return true;
     if (url.indexOf('#') === 0) return false;
diff --git a/src/assets/js/searchpage.js b/src/assets/js/searchpage.js
index ee76ba8..95d842d 100755
--- a/src/assets/js/searchpage.js
+++ b/src/assets/js/searchpage.js
@@ -321,11 +321,6 @@ function search_page_load() {
       format: 'jsonv2'
     };
 
-    if (search_params.get('debug') === '1') {
-      window.location.href = generate_full_api_url('reverse', api_request_params);
-      return;
-    }
-
     context = {
       // aPlace: aPlace,
       fLat: api_request_params.lat,
@@ -390,11 +385,6 @@ function search_page_load() {
       format: 'jsonv2'
     };
 
-    if (search_params.get('debug') === '1') {
-      window.location.href = generate_full_api_url('search', api_request_params);
-      return;
-    }
-
     context = {
       sQuery: api_request_params.q,
       sViewBox: search_params.get('viewbox'),
diff --git a/src/layout.html b/src/layout.html
index 81c613a..640794c 100644
--- a/src/layout.html
+++ b/src/layout.html
@@ -31,10 +31,11 @@
       </div>
       <div id="last-updated" class="col-4 text-center">
         <div id="loading">loading...</div>
-        Data from <a id="api-request-link" href="">API request</a>
-        <br>
-        Data last updated:
-        <span id="data-date"></span>
+        <div id="api-request">
+          Data from <a href="">API request</a>
+          <span id="api-request-debug">(<a href="">debug output</a>)</span>
+        </div>
+        Data last updated: <span id="data-date"></span>
       </div>
       <div class="col-4 text-right">
         <div class="dropdown">