From f51f2a70794858f9c8fb5d75ecd40fd1e4ec3897 Mon Sep 17 00:00:00 2001
From: Sarah Hoffmann <lonvia@denofr.de>
Date: Fri, 12 Feb 2021 02:03:22 +0100
Subject: [PATCH] Components for internal links (#69)

* add component for link to details page

* introduce components for reverse and generic internal links

Supersedes the generic click handler that was looking for
internal links.
---
 src/components/DetailsIndex.svelte  |  2 +-
 src/components/DetailsLink.svelte   | 42 +++++++++++++++++++++++++++++
 src/components/DetailsOneRow.svelte |  5 ++--
 src/components/Header.svelte        |  7 ++---
 src/components/PageLink.svelte      | 12 +++++++++
 src/components/ResultsList.svelte   | 18 ++++++-------
 src/components/ReverseBar.svelte    |  6 +++--
 src/components/ReverseLink.svelte   | 31 +++++++++++++++++++++
 src/components/SearchBar.svelte     | 17 ++++++------
 src/lib/helpers.js                  | 28 -------------------
 src/main.js                         | 39 ---------------------------
 src/pages/DeletablePage.svelte      |  6 +++--
 src/pages/DetailsPage.svelte        | 15 +++++++----
 13 files changed, 128 insertions(+), 100 deletions(-)
 create mode 100644 src/components/DetailsLink.svelte
 create mode 100644 src/components/PageLink.svelte
 create mode 100644 src/components/ReverseLink.svelte

diff --git a/src/components/DetailsIndex.svelte b/src/components/DetailsIndex.svelte
index 1b19967..2183597 100644
--- a/src/components/DetailsIndex.svelte
+++ b/src/components/DetailsIndex.svelte
@@ -91,4 +91,4 @@
     margin-right: 5px;
     width: 30em;
   }
-</style>
\ No newline at end of file
+</style>
diff --git a/src/components/DetailsLink.svelte b/src/components/DetailsLink.svelte
new file mode 100644
index 0000000..51a0c8c
--- /dev/null
+++ b/src/components/DetailsLink.svelte
@@ -0,0 +1,42 @@
+<script>
+  import { refresh_page } from '../lib/stores.js';
+
+  export let extra_classes = '';
+  export let feature = null;
+
+  let url_params = '';
+
+  function formatShortOSMType(sType) {
+    if (sType === 'node') return 'N';
+    if (sType === 'way') return 'W';
+    if (sType === 'relation') return 'R';
+    return '';
+  }
+
+  function handleClick() {
+    window.history.pushState([], '', 'details.html' + url_params);
+    refresh_page();
+  }
+
+  $: {
+    if (feature !== null && feature.osm_type) {
+      let param = '?osmtype=';
+      if (feature.osm_type.length == 1) {
+        param += encodeURIComponent(feature.osm_type);
+      } else {
+        param += formatShortOSMType(feature.osm_type);
+      }
+      param += '&osmid=' + encodeURIComponent(feature.osm_id);
+      if (feature.class) {
+        param += '&class=' + encodeURIComponent(feature.class);
+      } else if (feature.category) {
+        param += '&class=' + encodeURIComponent(feature.category);
+      }
+      url_params = param
+    } else {
+        url_params = '';
+    }
+ }
+</script>
+
+<a on:click|preventDefault|stopPropagation={handleClick} href="details.html{url_params}" class={extra_classes}><slot></slot></a>
diff --git a/src/components/DetailsOneRow.svelte b/src/components/DetailsOneRow.svelte
index cde2ac2..1ab566d 100644
--- a/src/components/DetailsOneRow.svelte
+++ b/src/components/DetailsOneRow.svelte
@@ -1,4 +1,5 @@
 <script>
+  import DetailsLink from '../components/DetailsLink.svelte';
 
   export let addressLine;
   export let bDistanceInMeters;
@@ -6,7 +7,7 @@
   $: bAddressLineUsed = addressLine.isaddress;
 
   import {
-    formatPlaceType, osmLink, formatAdminLevel, formatDistance, detailsURL
+    formatPlaceType, osmLink, formatAdminLevel, formatDistance
   } from '../lib/helpers.js';
 
 </script>
@@ -24,7 +25,7 @@
   <td>{addressLine.rank_address}</td>
   <td>{formatAdminLevel(addressLine.admin_level)}</td>
   <td>{@html formatDistance(addressLine.distance, bDistanceInMeters)}</td>
-  <td>{#if addressLine.osm_id}<a href="{detailsURL(addressLine)}">details</a>{/if}</td>
+  <td>{#if addressLine.osm_id}<DetailsLink feature={addressLine}>details</DetailsLink>{/if}</td>
 </tr>
 
 <style>
diff --git a/src/components/Header.svelte b/src/components/Header.svelte
index 63e2a44..5000cd6 100644
--- a/src/components/Header.svelte
+++ b/src/components/Header.svelte
@@ -1,5 +1,6 @@
 <script>
   import LastUpdated from './LastUpdated.svelte';
+  import PageLink from './PageLink.svelte';
 </script>
 
 <style>
@@ -13,7 +14,7 @@
     white-space: nowrap;
   }
 
-  .brand a:hover{
+  .brand :global(a:hover) {
     text-decoration: none;
   }
 
@@ -38,10 +39,10 @@
   <div class="row">
     <div class="col-4">
       <div class="brand">
-        <a href="search.html">
+        <PageLink page="search">
           <img alt="logo" src="images/osm_logo.120px.png" width="30" height="30"/>
           <h1>Nominatim</h1>
-        </a>
+        </PageLink>
       </div>
     </div>
     <div class="col-4">
diff --git a/src/components/PageLink.svelte b/src/components/PageLink.svelte
new file mode 100644
index 0000000..d70c3f0
--- /dev/null
+++ b/src/components/PageLink.svelte
@@ -0,0 +1,12 @@
+<script>
+import { refresh_page } from '../lib/stores.js';
+
+export let page;
+
+function handleClick() {
+  window.history.pushState([], '', page + '.html');
+  refresh_page();
+}
+</script>
+
+<a on:click|preventDefault|stopPropagation={handleClick} href="{page}.html"><slot></slot></a>
diff --git a/src/components/ResultsList.svelte b/src/components/ResultsList.svelte
index 668f330..2fc6828 100644
--- a/src/components/ResultsList.svelte
+++ b/src/components/ResultsList.svelte
@@ -1,7 +1,8 @@
 <script>
   import { results_store } from '../lib/stores.js';
-  import { formatLabel, detailsURL } from '../lib/helpers.js';
+  import { formatLabel } from '../lib/helpers.js';
 
+  import DetailsLink from './DetailsLink.svelte';
   import Welcome from './Welcome.svelte';
   import MapIcon from './MapIcon.svelte';
 
@@ -61,9 +62,9 @@
         </div>
         <span class="name">{aResult.display_name}</span>
         <span class="type">{formatLabel(aResult)}</span>
-        <p class="coords">{aResult.lat},{aResult.lon}</p>  
+        <p class="coords">{aResult.lat},{aResult.lon}</p>
 
-        <a class="details btn btn-outline-secondary btn-sm" href="{detailsURL(aResult)}">details</a>
+        <DetailsLink extra_classes="btn btn-outline-secondary btn-sm" feature={aResult}>details</DetailsLink>
       </div>
     {/each}
 
@@ -102,17 +103,18 @@
     background-color: #D9E7F7;
     border-color: #9DB9E4;
   }
-  .result.highlight .details {
+  .result.highlight :global(a) {
     margin: 10px auto;
     display: block;
     max-width: 10em;
     padding: 1px;
+    background-color: white;
   }
   .result .type{
     color: gray;
     font-size: 0.8em;
   }
-  .result .details {
+  .result :global(a) {
     display: none;
   }
 
@@ -130,11 +132,7 @@
     margin-top: 1em;
   }
 
-  .btn-outline-secondary {
-    background-color: white;
-  }
-
-  .btn-outline-secondary:hover {
+  .result.highlight :global(a):hover {
     color: #111;
   }
 </style>
diff --git a/src/components/ReverseBar.svelte b/src/components/ReverseBar.svelte
index c7f081d..53d7bff 100644
--- a/src/components/ReverseBar.svelte
+++ b/src/components/ReverseBar.svelte
@@ -1,5 +1,7 @@
 <script>
   import UrlSubmitForm from '../components/UrlSubmitForm.svelte';
+  import DetailsLink from '../components/DetailsLink.svelte';
+  import PageLink from '../components/PageLink.svelte';
 
   import { zoomLevels } from '../lib/helpers.js';
   import { map_store } from '../lib/stores.js';
@@ -70,8 +72,8 @@
       </button>
     </div>
     <div class="search-type-link">
-      <a href="details.html" class="mr-2">search by id</a>
-      <a href="search.html">forward search</a>
+      <DetailsLink extra_classes="mr-2">search by id</DetailsLink>
+      <PageLink page="search">forward search</PageLink>
     </div>
   </UrlSubmitForm>
 </div>
diff --git a/src/components/ReverseLink.svelte b/src/components/ReverseLink.svelte
new file mode 100644
index 0000000..5289999
--- /dev/null
+++ b/src/components/ReverseLink.svelte
@@ -0,0 +1,31 @@
+<script>
+import { refresh_page } from '../lib/stores.js';
+
+export let lat;
+export let lon;
+export let zoom = null;
+
+let params = '';
+
+$: {
+  if (lat && lon) {
+    let new_params = '?lat=' + encodeURIComponent(lat);
+    new_params += '&lon=' + encodeURIComponent(lon);
+
+    if (zoom) {
+      new_params += '&zoom=' + encodeURIComponent(zoom);
+    }
+
+    params = new_params;
+  } else {
+    params = '';
+  }
+}
+
+function handleClick() {
+  window.history.pushState([], '', 'reverse.html' + params);
+  refresh_page();
+}
+</script>
+
+<a on:click|preventDefault|stopPropagation={handleClick} href="reverse.html{params}"><slot></slot></a>
diff --git a/src/components/SearchBar.svelte b/src/components/SearchBar.svelte
index 306ce6e..dca6161 100644
--- a/src/components/SearchBar.svelte
+++ b/src/components/SearchBar.svelte
@@ -1,5 +1,7 @@
 <script>
   import UrlSubmitForm from '../components/UrlSubmitForm.svelte';
+  import DetailsLink from '../components/DetailsLink.svelte';
+  import ReverseLink from '../components/ReverseLink.svelte';
 
   import { map_store } from '../lib/stores.js';
   import { get } from 'svelte/store';
@@ -7,6 +9,8 @@
   export let bStructuredSearch = false;
   export let api_request_params = {};
   let sViewBox;
+  let lat;
+  let lon;
 
   function map_viewbox_as_string(map) {
     var bounds = map.getBounds();
@@ -38,12 +42,9 @@
   }
 
   function update_reverse_link(map) {
-    let link = document.getElementById('switch-to-reverse');
-    if (link) {
-      let center_lat_lng = map.wrapLatLng(map.getCenter());
-      link.href = 'reverse.html?lat=' + center_lat_lng.lat.toFixed(5)
-                   + '&lon=' + center_lat_lng.lng.toFixed(5);
-    }
+    let center_lat_lng = map.wrapLatLng(map.getCenter());
+    lat = center_lat_lng.lat.toFixed(5);
+    lon = center_lat_lng.lng.toFixed(5);
   }
 
   map_store.subscribe(map => {
@@ -88,8 +89,8 @@
       <a class="nav-link" class:active={bStructuredSearch} data-toggle="tab" href="#structured">structured</a>
     </li>
     <div class="search-type-link">
-      <a href="details.html" class="mr-2">search by id</a>
-      <a id="switch-to-reverse" href="reverse.html">reverse search</a>
+      <DetailsLink extra_classes="mr-2">search by id</DetailsLink>
+      <ReverseLink lat={lat} lon={lon}>reverse search</ReverseLink>
     </div>
   </ul>
   <div class="tab-content p-2">
diff --git a/src/lib/helpers.js b/src/lib/helpers.js
index e55cbf0..cbbdbc9 100644
--- a/src/lib/helpers.js
+++ b/src/lib/helpers.js
@@ -1,8 +1,6 @@
 module.exports.formatOSMType = formatOSMType;
-module.exports.formatShortOSMType = formatShortOSMType;
 module.exports.osmLink = osmLink;
 module.exports.formatLabel = formatLabel;
-module.exports.detailsURL = detailsURL;
 module.exports.wikipediaLink = wikipediaLink;
 module.exports.coverageType = coverageType;
 module.exports.isAdminBoundary = isAdminBoundary;
@@ -28,13 +26,6 @@ function formatOSMType(sType, bExcludeExternal) {
   return '';
 }
 
-function formatShortOSMType(sType) {
-  if (sType === 'node') return 'N';
-  if (sType === 'way') return 'W';
-  if (sType === 'relation') return 'R';
-  return '';
-}
-
 function osmLink(aPlace) {
   if (!aPlace.osm_type) return '';
   var sOSMType = formatOSMType(aPlace.osm_type, false);
@@ -59,25 +50,6 @@ function formatLabel(aPlace) {
   return '';
 }
 
-// 'details.html?osmtype=R&osmid=2181874&class=boundary'
-function detailsURL(aFeature) {
-  if (!aFeature) return '';
-
-  var sOSMType = aFeature.osm_type;
-  if (sOSMType && sOSMType.length !== 1) {
-    sOSMType = formatShortOSMType(aFeature.osm_type, false); // node => N
-  }
-  if (!sOSMType) return '';
-
-  var sURL = 'details.html?osmtype=' + sOSMType + '&osmid=' + aFeature.osm_id;
-  if (aFeature.class) {
-    sURL = sURL + '&class=' + encodeURIComponent(aFeature.class);
-  } else if (aFeature.category) {
-    sURL = sURL + '&class=' + encodeURIComponent(aFeature.category);
-  }
-  return sURL;
-}
-
 /* en:London_Borough_of_Redbridge => https://en.wikipedia.org/wiki/London_Borough_of_Redbridge */
 function wikipediaLink(aPlace) {
   if (!aPlace.calculated_wikipedia) return '';
diff --git a/src/main.js b/src/main.js
index 8445501..3b17bed 100644
--- a/src/main.js
+++ b/src/main.js
@@ -1,44 +1,5 @@
 import App from './App.svelte';
-import { refresh_page } from './lib/stores.js';
-
-let myhistory = [];
 
 const app = new App({ // eslint-disable-line no-unused-vars
   target: document.body
 });
-
-
-function is_relative_url(url) {
-  if (!url) return false;
-  if (url.indexOf('?') === 0) return true;
-  if (url.indexOf('/') === 0) return true;
-  if (url.indexOf('#') === 0) return false;
-  if (url.match(/^http/)) return false;
-  if (!url.match(/\.html/)) return true;
-
-  return false;
-}
-
-
-// load page after click on relative URL
-document.addEventListener('click', function (e) {
-
-  // loop parent nodes from the target to the delegation node
-  for (var target = e.target; target && target !== this; target = target.parentNode) {
-
-    if (target.matches('a') && target.href) {
-      // target.href always contains the full absolute URL, inspect the raw value instead
-      var target_url = target.attributes.href.value;
-
-      if (!is_relative_url(target_url)) return;
-
-      e.preventDefault();
-      e.stopPropagation();
-
-      window.history.pushState(myhistory, '', target_url);
-
-      refresh_page();
-      break;
-    }
-  }
-});
diff --git a/src/pages/DeletablePage.svelte b/src/pages/DeletablePage.svelte
index 27e881a..1d6b91e 100644
--- a/src/pages/DeletablePage.svelte
+++ b/src/pages/DeletablePage.svelte
@@ -1,7 +1,9 @@
 <script>
   import { onMount } from 'svelte';
   import { fetch_from_api, update_html_title } from '../lib/api_utils.js';
-  import { detailsURL, osmLink } from '../lib/helpers.js';
+  import { osmLink } from '../lib/helpers.js';
+
+  import DetailsLink from '../components/DetailsLink.svelte';
 
   let aPolygons = [];
 
@@ -36,7 +38,7 @@
         <tbody>
           {#each aPolygons as polygon}
           <tr>
-            <td><a href="{detailsURL(polygon)}">{polygon.place_id}</a></td>
+            <td><DetailsLink feature={polygon}>{polygon.place_id}</DetailsLink></td>
             <td>{polygon.country_code}</td>
             <td>{polygon.name}</td>
             <td>{@html osmLink(polygon)}</td>
diff --git a/src/pages/DetailsPage.svelte b/src/pages/DetailsPage.svelte
index 5d6e663..e9c7482 100644
--- a/src/pages/DetailsPage.svelte
+++ b/src/pages/DetailsPage.svelte
@@ -1,14 +1,16 @@
 <script>
-  import { onMount } from 'svelte';
+  import { onMount, onDestroy } from 'svelte';
   import { fetch_from_api, update_html_title } from '../lib/api_utils.js';
+  import { page } from '../lib/stores.js';
 
   import {
-    osmLink, detailsURL, wikipediaLink, coverageType, isAdminBoundary,
+    osmLink, wikipediaLink, coverageType, isAdminBoundary,
     formatAddressRank, formatKeywordToken
   } from '../lib/helpers.js';
   import MapIcon from '../components/MapIcon.svelte';
   import DetailsIndex from '../components/DetailsIndex.svelte';
   import DetailsOneRow from '../components/DetailsOneRow.svelte';
+  import DetailsLink from '../components/DetailsLink.svelte';
   import Map from '../components/Map.svelte';
 
   let aPlace;
@@ -54,7 +56,10 @@
       aPlace = undefined;
     }
   }
-  onMount(loaddata);
+
+  let page_subscription;
+  onMount(() => { page_subscription = page.subscribe(loaddata); });
+  onDestroy(() => { page_subscription(); });
 
 </script>
 
@@ -67,7 +72,7 @@
       <div class="col-sm-10">
         <h1>
           {aPlace.localname}
-          <small><a href="{detailsURL(aPlace)}">link to this page</a></small>
+          <small><DetailsLink feature={aPlace}>link to this page</DetailsLink></small>
         </h1>
       </div>
       <div class="col-sm-2 text-right">
@@ -278,7 +283,7 @@
     padding-left: 8px;
   }
 
-  h1 small a {
+  h1 small :global(a) {
     font-size: 0.5em;
     white-space: nowrap;
   }
-- 
2.39.5