Merge pull request #3466 from mtmail/apple-silicon-parallels

[nominatim.git] / .github / workflows / ci-tests.yml

diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
index 910114d7e5cf5e9e0a16d46949b14bbc2f8b5bd9..5b7dacf084ca43dda6b789a9fc7670565f6c87a9 100644 (file)
--- a/.github/workflows/ci-tests.yml
+++ b/.github/workflows/ci-tests.yml
@@ -65,7 +65,7 @@ jobs:
             - name: Unpack Nominatim
               run: tar xf nominatim-src.tar.bz2
 
             - name: Unpack Nominatim
               run: tar xf nominatim-src.tar.bz2
 

-            - uses: actions/setup-python@v4
+            - uses: actions/setup-python@v5

               with:
                 python-version: 3.7
               if: matrix.flavour == 'oldstuff'
               with:
                 python-version: 3.7
               if: matrix.flavour == 'oldstuff'


@@ -80,23 +80,23 @@ jobs:
                   flavour: ${{ matrix.flavour }}
                   lua: ${{ matrix.lua }}
 
                   flavour: ${{ matrix.flavour }}
                   lua: ${{ matrix.lua }}
 

-            - name: Install test prerequsites (behave from apt)
+            - name: Install test prerequisites (behave from apt)

               run: sudo apt-get install -y -qq python3-behave
               if: matrix.flavour == 'ubuntu-20'
 
               run: sudo apt-get install -y -qq python3-behave
               if: matrix.flavour == 'ubuntu-20'
 

-            - name: Install test prerequsites (behave from pip)
+            - name: Install test prerequisites (behave from pip)

               run: pip3 install behave==1.2.6
               if: (matrix.flavour == 'oldstuff') || (matrix.flavour == 'ubuntu-22')
 
               run: pip3 install behave==1.2.6
               if: (matrix.flavour == 'oldstuff') || (matrix.flavour == 'ubuntu-22')
 

-            - name: Install test prerequsites (from apt for Ununtu 2x)
+            - name: Install test prerequisites (from apt for Ununtu 2x)

               run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn
               if: matrix.flavour != 'oldstuff'
 
             - name: Install newer pytest-asyncio
               run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn
               if: matrix.flavour != 'oldstuff'
 
             - name: Install newer pytest-asyncio

-              run: pip3 install -U pytest-asyncio==0.21.1
+              run: pip3 install -U pytest-asyncio

               if: matrix.flavour == 'ubuntu-20'
 
               if: matrix.flavour == 'ubuntu-20'
 

-            - name: Install test prerequsites (from pip for Ubuntu 18)
+            - name: Install test prerequisites (from pip for Ubuntu 18)

               run: pip3 install pytest pytest-asyncio uvicorn
               if: matrix.flavour == 'oldstuff'
 
               run: pip3 install pytest pytest-asyncio uvicorn
               if: matrix.flavour == 'oldstuff'
 


@@ -105,12 +105,12 @@ jobs:
 
             - name: Install latest pylint
               run: pip3 install -U pylint
 
             - name: Install latest pylint
               run: pip3 install -U pylint

-              if: matrix.flavour != 'oldstuff'
+              if: matrix.flavour == 'ubuntu-22'

 
             - name: Python linting
 
             - name: Python linting

-              run: python3 -m pylint nominatim
+              run: python3 -m pylint src

               working-directory: Nominatim
               working-directory: Nominatim

-              if: matrix.flavour != 'oldstuff'
+              if: matrix.flavour == 'ubuntu-22'

 
             - name: Python unit tests
               run: python3 -m pytest test/python
 
             - name: Python unit tests
               run: python3 -m pytest test/python


@@ -126,7 +126,7 @@ jobs:
               if: matrix.flavour != 'oldstuff'
 
             - name: Python static typechecking
               if: matrix.flavour != 'oldstuff'
 
             - name: Python static typechecking

-              run: python3 -m mypy --strict nominatim
+              run: python3 -m mypy --strict src

               working-directory: Nominatim
               if: matrix.flavour != 'oldstuff'
 
               working-directory: Nominatim
               if: matrix.flavour != 'oldstuff'
 


@@ -134,6 +134,10 @@ jobs:
         needs: create-archive
         runs-on: ubuntu-20.04
 
         needs: create-archive
         runs-on: ubuntu-20.04
 

+        strategy:
+            matrix:
+                postgresql: ["13", "16"]
+

         steps:
             - uses: actions/download-artifact@v4
               with:
         steps:
             - uses: actions/download-artifact@v4
               with:


@@ -149,17 +153,19 @@ jobs:
 
             - uses: ./Nominatim/.github/actions/setup-postgresql
               with:
 
             - uses: ./Nominatim/.github/actions/setup-postgresql
               with:

-                  postgresql-version: 13
+                  postgresql-version: ${{ matrix.postgresql }}

                   postgis-version: 3
 
             - name: Install Postgresql server dev
                   postgis-version: 3
 
             - name: Install Postgresql server dev

-              run: sudo apt-get install postgresql-server-dev-13
+              run: sudo apt-get install postgresql-server-dev-$PGVER
+              env:
+                PGVER: ${{ matrix.postgresql }}

 
             - uses: ./Nominatim/.github/actions/build-nominatim
               with:
                   cmake-args: -DBUILD_MODULE=on
 
 
             - uses: ./Nominatim/.github/actions/build-nominatim
               with:
                   cmake-args: -DBUILD_MODULE=on
 

-            - name: Install test prerequsites
+            - name: Install test prerequisites

               run: sudo apt-get install -y -qq python3-behave
 
             - name: BDD tests (legacy tokenizer)
               run: sudo apt-get install -y -qq python3-behave
 
             - name: BDD tests (legacy tokenizer)


@@ -206,7 +212,7 @@ jobs:
               with:
                   flavour: 'ubuntu-22'
 
               with:
                   flavour: 'ubuntu-22'
 

-            - name: Install test prerequsites
+            - name: Install test prerequisites

               run: sudo apt-get install -y -qq python3-behave
 
             - name: BDD tests (php)
               run: sudo apt-get install -y -qq python3-behave
 
             - name: BDD tests (php)


@@ -221,16 +227,16 @@ jobs:
 
         strategy:
             matrix:
 
         strategy:
             matrix:

-                name: [Ubuntu-20, Ubuntu-22]
+                name: [Ubuntu-22, Ubuntu-24]

                 include:
                 include:

-                    - name: Ubuntu-20
-                      image: "ubuntu:20.04"
-                      ubuntu: 20
-                      install_mode: install-apache

                     - name: Ubuntu-22
                       image: "ubuntu:22.04"
                       ubuntu: 22
                       install_mode: install-apache
                     - name: Ubuntu-22
                       image: "ubuntu:22.04"
                       ubuntu: 22
                       install_mode: install-apache

+                    - name: Ubuntu-24
+                      image: "ubuntu:24.04"
+                      ubuntu: 24
+                      install_mode: install-apache

 
         container:
             image: ${{ matrix.image }}
 
         container:
             image: ${{ matrix.image }}


@@ -286,6 +292,16 @@ jobs:
                   mkdir data-env-reverse
               working-directory: /home/nominatim
 
                   mkdir data-env-reverse
               working-directory: /home/nominatim
 

+            - name: Add nominatim to path
+              run: |
+                sudo ln -s /home/nominatim/nominatim-venv/bin/nominatim /usr/local/bin/nominatim
+              if: matrix.ubuntu == 24
+
+            - name: Need lua binary
+              run: |
+                sudo apt-get install -y lua5.4 lua-dkjson
+              if: matrix.ubuntu == 24
+

             - name: Print version
               run: nominatim --version
               working-directory: /home/nominatim/nominatim-project
             - name: Print version
               run: nominatim --version
               working-directory: /home/nominatim/nominatim-project


@@ -318,9 +334,18 @@ jobs:
               run: apt-get install -y python3-pip
               shell: bash
 
               run: apt-get install -y python3-pip
               shell: bash
 

-            - name: Run update
+            - name: Install osmium (Ubuntu 22)

               run: |
                   pip3 install --user osmium
               run: |
                   pip3 install --user osmium

+              if: matrix.ubuntu == 22
+
+            - name: Install osmium (Ubuntu 24)
+              run: |
+                  /home/nominatim/nominatim-venv/bin/pip install osmium
+              if: matrix.ubuntu == 24
+
+            - name: Run update
+              run: |

                   nominatim replication --init
                   NOMINATIM_REPLICATION_MAX_DIFF=1 nominatim replication --once
               working-directory: /home/nominatim/nominatim-project
                   nominatim replication --init
                   NOMINATIM_REPLICATION_MAX_DIFF=1 nominatim replication --once
               working-directory: /home/nominatim/nominatim-project


@@ -386,3 +411,10 @@ jobs:
 
           - name: Check full import
             run: nominatim admin --check-database
 
           - name: Check full import
             run: nominatim admin --check-database

+
+    codespell:
+      runs-on: ubuntu-latest
+      steps:
+          - uses: codespell-project/actions-codespell@v2
+            with:
+                only_warn: 1