when looking for keywords on detail page a SQL bracket error was possible

[nominatim.git] / website / details.php

diff --git a/website/details.php b/website/details.php
index 7f0a951faa0e30f080fbff00aadffaa5e1ade0a0..e2a8a031e02a4c67a224bea5e7df4855b5195ce2 100755 (executable)
--- a/website/details.php
+++ b/website/details.php
@@ -11,7 +11,7 @@ $oParams = new Nominatim\ParameterParser();
 
 $sOutputFormat = 'html';
 $aLangPrefOrder = $oParams->getPreferredLanguages();
 
 $sOutputFormat = 'html';
 $aLangPrefOrder = $oParams->getPreferredLanguages();

-$sLanguagePrefArraySQL = "ARRAY[".join(',', array_map("getDBQuoted", $aLangPrefOrder))."]";
+$sLanguagePrefArraySQL = 'ARRAY['.join(',', array_map('getDBQuoted', $aLangPrefOrder)).']';

 
 $sPlaceId = $oParams->getString('place_id');
 $sOsmType = $oParams->getSet('osmtype', array('N', 'W', 'R'));
 
 $sPlaceId = $oParams->getString('place_id');
 $sOsmType = $oParams->getSet('osmtype', array('N', 'W', 'R'));


@@ -30,20 +30,20 @@ if ($sOsmType && $iOsmId > 0) {
     // Be nice about our error messages for broken geometry
 
     if (!$sPlaceId) {
     // Be nice about our error messages for broken geometry
 
     if (!$sPlaceId) {

-        $sSQL = "SELECT ";
-        $sSQL .= "    osm_type, ";
-        $sSQL .= "    osm_id, ";
-        $sSQL .= "    errormessage, ";
-        $sSQL .= "    class, ";
-        $sSQL .= "    type, ";
+        $sSQL = 'SELECT ';
+        $sSQL .= '    osm_type, ';
+        $sSQL .= '    osm_id, ';
+        $sSQL .= '    errormessage, ';
+        $sSQL .= '    class, ';
+        $sSQL .= '    type, ';

         $sSQL .= "    get_name_by_language(name,$sLanguagePrefArraySQL) AS localname,";
         $sSQL .= "    get_name_by_language(name,$sLanguagePrefArraySQL) AS localname,";

-        $sSQL .= "    ST_AsText(prevgeometry) AS prevgeom, ";
-        $sSQL .= "    ST_AsText(newgeometry) AS newgeom";
-        $sSQL .= " FROM import_polygon_error ";
+        $sSQL .= '    ST_AsText(prevgeometry) AS prevgeom, ';
+        $sSQL .= '    ST_AsText(newgeometry) AS newgeom';
+        $sSQL .= ' FROM import_polygon_error ';

         $sSQL .= " WHERE osm_type = '".$sOsmType."'";
         $sSQL .= " WHERE osm_type = '".$sOsmType."'";

-        $sSQL .= "  AND osm_id = ".$iOsmId;
-        $sSQL .= " ORDER BY updated DESC";
-        $sSQL .= " LIMIT 1";
+        $sSQL .= '  AND osm_id = '.$iOsmId;
+        $sSQL .= ' ORDER BY updated DESC';
+        $sSQL .= ' LIMIT 1';

         $aPointDetails = chksql($oDB->getRow($sSQL));
         if (!PEAR::isError($aPointDetails) && $aPointDetails) {
             if (preg_match('/\[(-?\d+\.\d+) (-?\d+\.\d+)\]/', $aPointDetails['errormessage'], $aMatches)) {
         $aPointDetails = chksql($oDB->getRow($sSQL));
         if (!PEAR::isError($aPointDetails) && $aPointDetails) {
             if (preg_match('/\[(-?\d+\.\d+) (-?\d+\.\d+)\]/', $aPointDetails['errormessage'], $aMatches)) {


@@ -60,7 +60,7 @@ if ($sOsmType && $iOsmId > 0) {
 }
 
 
 }
 
 

-if (!$sPlaceId) userError("Please select a place id");
+if (!$sPlaceId) userError('Please select a place id');

 
 $iPlaceID = (int)$sPlaceId;
 
 
 $iPlaceID = (int)$sPlaceId;
 


@@ -73,6 +73,9 @@ if (CONST_Use_US_Tiger_Data) {
 $iParentPlaceID = chksql($oDB->getOne('SELECT parent_place_id FROM location_property_osmline WHERE place_id = '.$iPlaceID));
 if ($iParentPlaceID) $iPlaceID = $iParentPlaceID;
 
 $iParentPlaceID = chksql($oDB->getOne('SELECT parent_place_id FROM location_property_osmline WHERE place_id = '.$iPlaceID));
 if ($iParentPlaceID) $iPlaceID = $iParentPlaceID;
 

+// artificial postcodes
+$iParentPlaceID = chksql($oDB->getOne('SELECT parent_place_id FROM location_postcode WHERE place_id = '.$iPlaceID));
+if ($iParentPlaceID) $iPlaceID = $iParentPlaceID;

 
 if (CONST_Use_Aux_Location_data) {
     $iParentPlaceID = chksql($oDB->getOne('SELECT parent_place_id FROM location_property_aux WHERE place_id = '.$iPlaceID));
 
 if (CONST_Use_Aux_Location_data) {
     $iParentPlaceID = chksql($oDB->getOne('SELECT parent_place_id FROM location_property_aux WHERE place_id = '.$iPlaceID));


@@ -82,34 +85,34 @@ if (CONST_Use_Aux_Location_data) {
 $hLog = logStart($oDB, 'details', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
 
 // Get the details for this point
 $hLog = logStart($oDB, 'details', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
 
 // Get the details for this point

-$sSQL = "SELECT place_id, osm_type, osm_id, class, type, name, admin_level,";
-$sSQL .= "    housenumber, postcode, country_code,";
-$sSQL .= "    importance, wikipedia,";
+$sSQL = 'SELECT place_id, osm_type, osm_id, class, type, name, admin_level,';
+$sSQL .= '    housenumber, postcode, country_code,';
+$sSQL .= '    importance, wikipedia,';

 $sSQL .= "    to_char(indexed_date, 'YYYY-MM-DD HH24:MI') AS indexed_date,";
 $sSQL .= "    to_char(indexed_date, 'YYYY-MM-DD HH24:MI') AS indexed_date,";

-$sSQL .= "    parent_place_id, ";
-$sSQL .= "    rank_address, ";
-$sSQL .= "    rank_search, ";
-$sSQL .= "    get_searchrank_label(rank_search) AS rank_search_label,";
+$sSQL .= '    parent_place_id, ';
+$sSQL .= '    rank_address, ';
+$sSQL .= '    rank_search, ';
+$sSQL .= '    get_searchrank_label(rank_search) AS rank_search_label,';

 $sSQL .= "    get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";
 $sSQL .= "    ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea, ";
 //$sSQL .= " ST_Area(geometry::geography) AS area, ";
 $sSQL .= "    get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";
 $sSQL .= "    ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea, ";
 //$sSQL .= " ST_Area(geometry::geography) AS area, ";

-$sSQL .= "    ST_y(centroid) AS lat, ";
-$sSQL .= "    ST_x(centroid) AS lon,";
-$sSQL .= "    CASE ";
-$sSQL .= "       WHEN importance = 0 OR importance IS NULL THEN 0.75-(rank_search::float/40) ";
-$sSQL .= "       ELSE importance ";
-$sSQL .= "       END as calculated_importance, ";
-$sSQL .= "    ST_AsGeoJSON(CASE ";
-$sSQL .= "                WHEN ST_NPoints(geometry) > 5000 THEN ST_SimplifyPreserveTopology(geometry, 0.0001) ";
-$sSQL .= "                ELSE geometry ";
-$sSQL .= "                END) as asgeojson";
-$sSQL .= " FROM placex ";
+$sSQL .= '    ST_y(centroid) AS lat, ';
+$sSQL .= '    ST_x(centroid) AS lon,';
+$sSQL .= '    CASE ';
+$sSQL .= '       WHEN importance = 0 OR importance IS NULL THEN 0.75-(rank_search::float/40) ';
+$sSQL .= '       ELSE importance ';
+$sSQL .= '       END as calculated_importance, ';
+$sSQL .= '    ST_AsGeoJSON(CASE ';
+$sSQL .= '                WHEN ST_NPoints(geometry) > 5000 THEN ST_SimplifyPreserveTopology(geometry, 0.0001) ';
+$sSQL .= '                ELSE geometry ';
+$sSQL .= '                END) as asgeojson';
+$sSQL .= ' FROM placex ';

 $sSQL .= " WHERE place_id = $iPlaceID";
 
 $sSQL .= " WHERE place_id = $iPlaceID";
 

-$aPointDetails = chksql($oDB->getRow($sSQL), "Could not get details of place object.");
+$aPointDetails = chksql($oDB->getRow($sSQL), 'Could not get details of place object.');

 
 if (!$aPointDetails) {
 
 if (!$aPointDetails) {

-    userError("Unknown place id.");
+    userError('Unknown place id.');

 }
 
 $aPointDetails['localname'] = $aPointDetails['localname']?$aPointDetails['localname']:$aPointDetails['housenumber'];
 }
 
 $aPointDetails['localname'] = $aPointDetails['localname']?$aPointDetails['localname']:$aPointDetails['housenumber'];


@@ -130,6 +133,13 @@ if (PEAR::isError($aPointDetails['aNames'])) { // possible timeout
     $aPointDetails['aNames'] = [];
 }
 
     $aPointDetails['aNames'] = [];
 }
 

+// Address tags
+$sSQL = "SELECT (each(address)).key as key,(each(address)).value FROM placex WHERE place_id = $iPlaceID ORDER BY key";
+$aPointDetails['aAddressTags'] = $oDB->getAssoc($sSQL);
+if (PEAR::isError($aPointDetails['aAddressTags'])) { // possible timeout
+    $aPointDetails['aAddressTags'] = [];
+}
+

 // Extra tags
 $sSQL = "SELECT (each(extratags)).key,(each(extratags)).value FROM placex WHERE place_id = $iPlaceID ORDER BY (each(extratags)).key";
 $aPointDetails['aExtraTags'] = $oDB->getAssoc($sSQL);
 // Extra tags
 $sSQL = "SELECT (each(extratags)).key,(each(extratags)).value FROM placex WHERE place_id = $iPlaceID ORDER BY (each(extratags)).key";
 $aPointDetails['aExtraTags'] = $oDB->getAssoc($sSQL);


@@ -141,56 +151,56 @@ if (PEAR::isError($aPointDetails['aExtraTags'])) { // possible timeout
 $aAddressLines = getAddressDetails($oDB, $sLanguagePrefArraySQL, $iPlaceID, $aPointDetails['country_code'], -1, true);
 
 // Linked places
 $aAddressLines = getAddressDetails($oDB, $sLanguagePrefArraySQL, $iPlaceID, $aPointDetails['country_code'], -1, true);
 
 // Linked places

-$sSQL = "SELECT placex.place_id, osm_type, osm_id, class, type, housenumber,";
-$sSQL .= " admin_level, rank_address, ";
+$sSQL = 'SELECT placex.place_id, osm_type, osm_id, class, type, housenumber,';
+$sSQL .= ' admin_level, rank_address, ';

 $sSQL .= " ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea,";
 $sSQL .= " ST_DistanceSpheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') AS distance, ";
 $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";
 $sSQL .= " ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea,";
 $sSQL .= " ST_DistanceSpheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') AS distance, ";
 $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";

-$sSQL .= " length(name::text) AS namelength ";
-$sSQL .= " FROM ";
-$sSQL .= "    placex, ";
-$sSQL .= "    ( ";
-$sSQL .= "      SELECT centroid AS placegeometry ";
-$sSQL .= "      FROM placex ";
+$sSQL .= ' length(name::text) AS namelength ';
+$sSQL .= ' FROM ';
+$sSQL .= '    placex, ';
+$sSQL .= '    ( ';
+$sSQL .= '      SELECT centroid AS placegeometry ';
+$sSQL .= '      FROM placex ';

 $sSQL .= "      WHERE place_id = $iPlaceID ";
 $sSQL .= "      WHERE place_id = $iPlaceID ";

-$sSQL .= "    ) AS x";
+$sSQL .= '    ) AS x';

 $sSQL .= " WHERE linked_place_id = $iPlaceID";
 $sSQL .= " WHERE linked_place_id = $iPlaceID";

-$sSQL .= " ORDER BY ";
-$sSQL .= "   rank_address ASC, ";
-$sSQL .= "   rank_search ASC, ";
+$sSQL .= ' ORDER BY ';
+$sSQL .= '   rank_address ASC, ';
+$sSQL .= '   rank_search ASC, ';

 $sSQL .= "   get_name_by_language(name, $sLanguagePrefArraySQL), ";
 $sSQL .= "   get_name_by_language(name, $sLanguagePrefArraySQL), ";

-$sSQL .= "   housenumber";
+$sSQL .= '   housenumber';

 $aLinkedLines = $oDB->getAll($sSQL);
 if (PEAR::isError($aLinkedLines)) { // possible timeout
     $aLinkedLines = [];
 }
 
 // All places this is an imediate parent of
 $aLinkedLines = $oDB->getAll($sSQL);
 if (PEAR::isError($aLinkedLines)) { // possible timeout
     $aLinkedLines = [];
 }
 
 // All places this is an imediate parent of

-$sSQL = "SELECT obj.place_id, osm_type, osm_id, class, type, housenumber,";
+$sSQL = 'SELECT obj.place_id, osm_type, osm_id, class, type, housenumber,';

 $sSQL .= " admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea,";
 $sSQL .= " ST_DistanceSpheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') AS distance, ";
 $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";
 $sSQL .= " admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') AS isarea,";
 $sSQL .= " ST_DistanceSpheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') AS distance, ";
 $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) AS localname, ";

-$sSQL .= " length(name::text) AS namelength ";
-$sSQL .= " FROM ";
-$sSQL .= "    ( ";
-$sSQL .= "      SELECT placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, rank_search, geometry, name ";
-$sSQL .= "      FROM placex ";
+$sSQL .= ' length(name::text) AS namelength ';
+$sSQL .= ' FROM ';
+$sSQL .= '    ( ';
+$sSQL .= '      SELECT placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, rank_search, geometry, name ';
+$sSQL .= '      FROM placex ';

 $sSQL .= "      WHERE parent_place_id = $iPlaceID ";
 $sSQL .= "      WHERE parent_place_id = $iPlaceID ";

-$sSQL .= "      ORDER BY ";
-$sSQL .= "         rank_address ASC, ";
-$sSQL .= "         rank_search ASC ";
-$sSQL .= "      LIMIT 500 ";
-$sSQL .= "    ) AS obj,";
-$sSQL .= "    ( ";
-$sSQL .= "      SELECT centroid AS placegeometry ";
-$sSQL .= "      FROM placex ";
+$sSQL .= '      ORDER BY ';
+$sSQL .= '         rank_address ASC, ';
+$sSQL .= '         rank_search ASC ';
+$sSQL .= '      LIMIT 500 ';
+$sSQL .= '    ) AS obj,';
+$sSQL .= '    ( ';
+$sSQL .= '      SELECT centroid AS placegeometry ';
+$sSQL .= '      FROM placex ';

 $sSQL .= "      WHERE place_id = $iPlaceID ";
 $sSQL .= "      WHERE place_id = $iPlaceID ";

-$sSQL .= "    ) AS x";
-$sSQL .= " ORDER BY ";
-$sSQL .= "    rank_address ASC, ";
-$sSQL .= "    rank_search ASC, ";
-$sSQL .= "    localname, ";
-$sSQL .= "    housenumber";
+$sSQL .= '    ) AS x';
+$sSQL .= ' ORDER BY ';
+$sSQL .= '    rank_address ASC, ';
+$sSQL .= '    rank_search ASC, ';
+$sSQL .= '    localname, ';
+$sSQL .= '    housenumber';

 $aParentOfLines = $oDB->getAll($sSQL);
 if (PEAR::isError($aParentOfLines)) { // possible timeout
     $aParentOfLines = [];
 $aParentOfLines = $oDB->getAll($sSQL);
 if (PEAR::isError($aParentOfLines)) { // possible timeout
     $aParentOfLines = [];


@@ -200,28 +210,30 @@ $aPlaceSearchNameKeywords = false;
 $aPlaceSearchAddressKeywords = false;
 if ($oParams->getBool('keywords')) {
     $sSQL = "SELECT * FROM search_name WHERE place_id = $iPlaceID";
 $aPlaceSearchAddressKeywords = false;
 if ($oParams->getBool('keywords')) {
     $sSQL = "SELECT * FROM search_name WHERE place_id = $iPlaceID";

-    $aPlaceSearchName = $oDB->getRow($sSQL);
-    if (PEAR::isError($aPlaceSearchName)) { // possible timeout
+    $aPlaceSearchName = $oDB->getRow($sSQL); // can be null
+    if (!$aPlaceSearchName || PEAR::isError($aPlaceSearchName)) { // possible timeout

         $aPlaceSearchName = [];
     }
 
         $aPlaceSearchName = [];
     }
 

-    $sSQL = "SELECT * FROM word WHERE word_id in (".substr($aPlaceSearchName['name_vector'], 1, -1).")";
-    $aPlaceSearchNameKeywords = $oDB->getAll($sSQL);
-    if (PEAR::isError($aPlaceSearchNameKeywords)) { // possible timeout
-        $aPlaceSearchNameKeywords = [];
-    }
+    if (!empty($aPlaceSearchName)) {
+        $sSQL = 'SELECT * FROM word WHERE word_id in ('.substr($aPlaceSearchName['name_vector'], 1, -1).')';
+        $aPlaceSearchNameKeywords = $oDB->getAll($sSQL);
+        if (PEAR::isError($aPlaceSearchNameKeywords)) { // possible timeout
+            $aPlaceSearchNameKeywords = [];
+        }

 
 

-    $sSQL = "SELECT * FROM word WHERE word_id in (".substr($aPlaceSearchName['nameaddress_vector'], 1, -1).")";
-    $aPlaceSearchAddressKeywords = $oDB->getAll($sSQL);
-    if (PEAR::isError($aPlaceSearchAddressKeywords)) { // possible timeout
-        $aPlaceSearchAddressKeywords = [];
+        $sSQL = 'SELECT * FROM word WHERE word_id in ('.substr($aPlaceSearchName['nameaddress_vector'], 1, -1).')';
+        $aPlaceSearchAddressKeywords = $oDB->getAll($sSQL);
+        if (PEAR::isError($aPlaceSearchAddressKeywords)) { // possible timeout
+            $aPlaceSearchAddressKeywords = [];
+        }

     }
 }
 
 logEnd($oDB, $hLog, 1);
 
 if ($sOutputFormat=='html') {
     }
 }
 
 logEnd($oDB, $hLog, 1);
 
 if ($sOutputFormat=='html') {

-    $sSQL = "SELECT TO_CHAR(lastimportdate - '2 minutes'::interval,'YYYY/MM/DD HH24:MI')||' GMT' FROM import_status LIMIT 1";
+    $sSQL = "SELECT TO_CHAR(lastimportdate,'YYYY/MM/DD HH24:MI')||' GMT' FROM import_status LIMIT 1";

     $sDataDate = chksql($oDB->getOne($sSQL));
     $sTileURL = CONST_Map_Tile_URL;
     $sTileAttribution = CONST_Map_Tile_Attribution;
     $sDataDate = chksql($oDB->getOne($sSQL));
     $sTileURL = CONST_Map_Tile_URL;
     $sTileAttribution = CONST_Map_Tile_Attribution;