actions: test import with installed version of Nominatim

[nominatim.git] / .github / workflows / ci-tests.yml

diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
index f1da461686f148db0a438c2f0432c6dfac962198..d5336d4ef52e5cb3fbb6a3fc02ef8dad22ec221e 100644 (file)
--- a/.github/workflows/ci-tests.yml
+++ b/.github/workflows/ci-tests.yml
@@ -6,11 +6,26 @@ jobs:
     tests:
         runs-on: ubuntu-20.04
 
     tests:
         runs-on: ubuntu-20.04
 

+        strategy:
+            matrix:
+                postgresql: [9.5, 13]
+                include:
+                    - postgresql: 9.5
+                      postgis: 2.5
+                    - postgresql: 13
+                      postgis: 3
+

         steps:
             - uses: actions/checkout@v2
               with:
                   submodules: true
 
         steps:
             - uses: actions/checkout@v2
               with:
                   submodules: true
 

+            - name: Setup PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                  php-version: '7.4'
+                  tools: phpunit, phpcs
+

             - name: Get Date
               id: get-date
               run: |
             - name: Get Date
               id: get-date
               run: |


@@ -20,27 +35,34 @@ jobs:
             - uses: actions/cache@v2
               with:
                   path: |
             - uses: actions/cache@v2
               with:
                   path: |

-                      data/country_osm_grid.sql.gz
-                      monaco-latest.osm.pbf
+                     data/country_osm_grid.sql.gz
+                     monaco-latest.osm.pbf

                   key: nominatim-data-${{ steps.get-date.outputs.date }}
 
             - uses: ./.github/actions/setup-postgresql
                   key: nominatim-data-${{ steps.get-date.outputs.date }}
 
             - uses: ./.github/actions/setup-postgresql

+              with:
+                  postgresql-version: ${{ matrix.postgresql }}
+                  postgis-version: ${{ matrix.postgis }}

             - uses: ./.github/actions/build-nominatim
 
             - name: Install test prerequsites
             - uses: ./.github/actions/build-nominatim
 
             - name: Install test prerequsites

-              run: |
-                   sudo apt-get install -y -qq php-codesniffer python3-tidylib
-                   sudo pip3 install behave nose
+              run: sudo apt-get install -y -qq php-codesniffer pylint python3-pytest python3-behave

 
             - name: PHP linting
               run: phpcs --report-width=120 .
 
 
             - name: PHP linting
               run: phpcs --report-width=120 .
 

+            - name: Python linting
+              run: pylint --extension-pkg-whitelist=osmium nominatim
+

             - name: PHP unit tests
               run: phpunit ./
               working-directory: test/php
 
             - name: PHP unit tests
               run: phpunit ./
               working-directory: test/php
 

+            - name: Python unit tests
+              run: py.test-3 test/python
+

             - name: BDD tests
             - name: BDD tests

-              run: behave -DREMOVE_TEMPLATE=1 --format=progress3 db osm2pgsql
+              run: behave -DREMOVE_TEMPLATE=1 --format=progress3

               working-directory: test/bdd
 
     import:
               working-directory: test/bdd
 
     import:


@@ -60,46 +82,47 @@ jobs:
             - uses: actions/cache@v2
               with:
                   path: |
             - uses: actions/cache@v2
               with:
                   path: |

-                      data/country_osm_grid.sql.gz
-                      monaco-latest.osm.pbf
+                     data/country_osm_grid.sql.gz
+                     monaco-latest.osm.pbf

                   key: nominatim-data-${{ steps.get-date.outputs.date }}
 
             - uses: ./.github/actions/setup-postgresql
                   key: nominatim-data-${{ steps.get-date.outputs.date }}
 
             - uses: ./.github/actions/setup-postgresql

+              with:
+                  postgresql-version: 13
+                  postgis-version: 3

             - uses: ./.github/actions/build-nominatim
 
             - uses: ./.github/actions/build-nominatim
 

-            - name: Create configuration
-              run: |
-                   echo '<?php' > settings/local.php
-                   echo " @define('CONST_Pyosmium_Binary', '/usr/lib/python3-pyosmium/pyosmium-get-changes');" >> settings/local.php
-              working-directory: build
-
-            - name: Download import data
+            - name: Prepare import environment

               run: |
               run: |

+                  mkdir data-env
+                  cd data-env

                   if [ ! -f monaco-latest.osm.pbf ]; then
                       wget --no-verbose https://download.geofabrik.de/europe/monaco-latest.osm.pbf
                   fi
                   if [ ! -f monaco-latest.osm.pbf ]; then
                       wget --no-verbose https://download.geofabrik.de/europe/monaco-latest.osm.pbf
                   fi

+                  which nominatim

               shell: bash
 
             - name: Import
               shell: bash
 
             - name: Import

-              run: php ./utils/setup.php --osm-file ../monaco-latest.osm.pbf --osm2pgsql-cache 500 --all
-              working-directory: build
+              run: nominatim import --osm-file monaco-latest.osm.pbf
+              shell: bash
+              working-directory: data-env

 
             - name: Import special phrases
 
             - name: Import special phrases

-              run: php ./utils/specialphrases.php --wiki-import | psql -d nominatim
-              working-directory: build
+              run: nominatim special-phrases --from-wiki | psql -d nominatim
+              working-directory: data-env

 
             - name: Check import
 
             - name: Check import

-              run: php ./utils/check_import_finished.php
-              working-directory: build
+              run: nominatim check-database
+              working-directory: data-env

 
             - name: Run update
               run: |
 
             - name: Run update
               run: |

-                   php ./utils/update.php --init-updates
-                   php ./utils/update.php --import-osmosis
-              working-directory: build
+                   nominatim replication --init
+                   nominatim replication --once
+              working-directory: data-env

 
             - name: Run reverse-only import
 
             - name: Run reverse-only import

-              run : |
-                  dropdb nominatim
-                  php ./utils/setup.php --osm-file ../monaco-latest.osm.pbf --reverse-only --all
-              working-directory: build
+              run : nominatim import --osm-file ../monaco-latest.osm.pbf --reverse-only
+              working-directory: data-env
+              env:
+                  NOMINATIM_DATABASE_DSN: pgsql:dbname=reverse