Merge pull request #533 from mtmail/PSR2-php-tests

[nominatim.git] / lib / ReverseGeocode.php

diff --git a/lib/ReverseGeocode.php b/lib/ReverseGeocode.php
index b7ee36b4086efa43988bf5bb780981b3b35d5219..c56c9b29b2cbadc417092147f93fc30ee6501cf6 100644 (file)
--- a/lib/ReverseGeocode.php
+++ b/lib/ReverseGeocode.php
@@ -1,16 +1,20 @@
 <?php
 
+namespace Nominatim;
+
 class ReverseGeocode
 {
     protected $oDB;
     protected $iMaxRank = 28;
 
-    function ReverseGeocode(&$oDB)
+
+    public function __construct(&$oDB)
     {
         $this->oDB =& $oDB;
     }
 
-    function setZoom($iZoom)
+
+    public function setZoom($iZoom)
     {
         // Zoom to rank, this could probably be calculated but a lookup gives fine control
         $aZoomRank = array(
@@ -38,9 +42,14 @@ class ReverseGeocode
         $this->iMaxRank = (isset($iZoom) && isset($aZoomRank[$iZoom]))?$aZoomRank[$iZoom]:28;
     }
 
-    // returns { place_id =>, type => '(osm|tiger)' }
-    // fails if no place was found
-    function lookup($fLat, $fLon, $bDoInterpolation = true)
+
+    /* lookup()
+     * returns { place_id =>, type => '(osm|tiger)' }
+     * fails if no place was found
+     */
+
+
+    public function lookup($fLat, $fLon, $bDoInterpolation = true)
     {
         $sPointSQL = 'ST_SetSRID(ST_Point('.$fLon.','.$fLat.'),4326)';
         $iMaxRank = $this->iMaxRank;
@@ -78,8 +87,10 @@ class ReverseGeocode
             $sSQL .= ' OR ST_DWithin('.$sPointSQL.', centroid, '.$fSearchDiam.'))';
             $sSQL .= ' ORDER BY ST_distance('.$sPointSQL.', geometry) ASC limit 1';
             if (CONST_Debug) var_dump($sSQL);
-            $aPlace = chksql($this->oDB->getRow($sSQL),
-                             "Could not determine closest place.");
+            $aPlace = chksql(
+                $this->oDB->getRow($sSQL),
+                "Could not determine closest place."
+            );
             $iPlaceID = $aPlace['place_id'];
             $iParentPlaceID = $aPlace['parent_place_id'];
             $bIsInUnitedStates = ($aPlace['calculated_country_code'] == 'us');
@@ -102,23 +113,29 @@ class ReverseGeocode
                     echo $i['housenumber'] . ' | ' . $i['distance'] * 1000 . ' | ' . $i['lat'] . ' | ' . $i['lon']. ' | '. "<br>\n";
                 }
             }
-            $aPlaceLine = chksql($this->oDB->getRow($sSQL),
-                                 "Could not determine closest housenumber on an osm interpolation line.");
+            $aPlaceLine = chksql(
+                $this->oDB->getRow($sSQL),
+                "Could not determine closest housenumber on an osm interpolation line."
+            );
             if ($aPlaceLine) {
                 if (CONST_Debug) var_dump('found housenumber in interpolation lines table', $aPlaceLine);
                 if ($aPlace['rank_search'] == 30) {
-                    // if a house was already found in placex, we have to find out, 
+                    // if a house was already found in placex, we have to find out,
                     // if the placex house or the interpolated house are closer to the searched point
                     // distance between point and placex house
                     $sSQL = 'SELECT ST_distance('.$sPointSQL.', house.geometry) as distance FROM placex as house WHERE house.place_id='.$iPlaceID;
-                    $aDistancePlacex = chksql($this->oDB->getRow($sSQL),
-                                              "Could not determine distance between searched point and placex house.");
+                    $aDistancePlacex = chksql(
+                        $this->oDB->getRow($sSQL),
+                        "Could not determine distance between searched point and placex house."
+                    );
                     $fDistancePlacex = $aDistancePlacex['distance'];
                     // distance between point and interpolated house (fraction on interpolation line)
                     $sSQL = 'SELECT ST_distance('.$sPointSQL.', ST_LineInterpolatePoint(linegeo, '.$aPlaceLine['fraction'].')) as distance';
                     $sSQL .= ' FROM location_property_osmline WHERE place_id = '.$aPlaceLine['place_id'];
-                    $aDistanceInterpolation = chksql($this->oDB->getRow($sSQL),
-                                                     "Could not determine distance between searched point and interpolated house.");
+                    $aDistanceInterpolation = chksql(
+                        $this->oDB->getRow($sSQL),
+                        "Could not determine distance between searched point and interpolated house."
+                    );
                     $fDistanceInterpolation = $aDistanceInterpolation['distance'];
                     if ($fDistanceInterpolation < $fDistancePlacex) {
                         // interpolation is closer to point than placex house
@@ -160,8 +177,10 @@ class ReverseGeocode
                 }
             }
 
-            $aPlaceTiger = chksql($this->oDB->getRow($sSQL),
-                                  "Could not determine closest Tiger place.");
+            $aPlaceTiger = chksql(
+                $this->oDB->getRow($sSQL),
+                "Could not determine closest Tiger place."
+            );
             if ($aPlaceTiger) {
                 if (CONST_Debug) var_dump('found Tiger housenumber', $aPlaceTiger);
                 $bPlaceIsTiger = true;
@@ -183,8 +202,7 @@ class ReverseGeocode
             $sSQL .= " WHERE place_id = $iPlaceID";
             $sSQL .= " ORDER BY abs(cached_rank_address - $iMaxRank) asc,cached_rank_address desc,isaddress desc,distance desc";
             $sSQL .= ' LIMIT 1';
-            $iPlaceID = chksql($this->oDB->getOne($sSQL),
-                               "Could not get parent for place.");
+            $iPlaceID = chksql($this->oDB->getOne($sSQL), "Could not get parent for place.");
             if (!$iPlaceID) {
                 $iPlaceID = $aPlace['place_id'];
             }
@@ -195,5 +213,4 @@ class ReverseGeocode
                 'fraction' => ($bPlaceIsTiger || $bPlaceIsLine) ? $fFraction : -1
                );
     }
-    
 }