Merge remote-tracking branch 'upstream/master'

[nominatim.git] / nominatim / api / results.py

diff --git a/nominatim/api/results.py b/nominatim/api/results.py
index 63c9cf12532974e3977c2199ed92f004b3b90301..10f03393416b33b36f2969e012c0e678d064998a 100644 (file)
--- a/nominatim/api/results.py
+++ b/nominatim/api/results.py
@@ -21,6 +21,7 @@ import sqlalchemy as sa
 from nominatim.typing import SaSelect, SaRow
 from nominatim.api.types import Point, LookupDetails
 from nominatim.api.connection import SearchConnection
 from nominatim.typing import SaSelect, SaRow
 from nominatim.api.types import Point, LookupDetails
 from nominatim.api.connection import SearchConnection

+from nominatim.api.logging import log

 
 # This file defines complex result data classes.
 # pylint: disable=too-many-instance-attributes
 
 # This file defines complex result data classes.
 # pylint: disable=too-many-instance-attributes


@@ -131,13 +132,6 @@ class SearchResult:
         return self.importance or (0.7500001 - (self.rank_search/40.0))
 
 
         return self.importance or (0.7500001 - (self.rank_search/40.0))
 
 

-    # pylint: disable=consider-using-f-string
-    def centroid_as_geojson(self) -> str:
-        """ Get the centroid in GeoJSON format.
-        """
-        return '{"type": "Point","coordinates": [%f, %f]}' % self.centroid
-
-

 def _filter_geometries(row: SaRow) -> Dict[str, str]:
     return {k[9:]: v for k, v in row._mapping.items() # pylint: disable=W0212
             if k.startswith('geometry_')}
 def _filter_geometries(row: SaRow) -> Dict[str, str]:
     return {k[9:]: v for k, v in row._mapping.items() # pylint: disable=W0212
             if k.startswith('geometry_')}


@@ -165,7 +159,7 @@ def create_from_placex_row(row: SaRow) -> SearchResult:
                         importance=row.importance,
                         country_code=row.country_code,
                         indexed_date=getattr(row, 'indexed_date'),
                         importance=row.importance,
                         country_code=row.country_code,
                         indexed_date=getattr(row, 'indexed_date'),

-                        centroid=Point(row.x, row.y),
+                        centroid=Point.from_wkb(row.centroid.data),

                         geometry=_filter_geometries(row))
 
 
                         geometry=_filter_geometries(row))
 
 


@@ -185,7 +179,7 @@ def create_from_osmline_row(row: SaRow) -> SearchResult:
                                    'step': str(row.step)},
                         country_code=row.country_code,
                         indexed_date=getattr(row, 'indexed_date'),
                                    'step': str(row.step)},
                         country_code=row.country_code,
                         indexed_date=getattr(row, 'indexed_date'),

-                        centroid=Point(row.x, row.y),
+                        centroid=Point.from_wkb(row.centroid.data),

                         geometry=_filter_geometries(row))
 
 
                         geometry=_filter_geometries(row))
 
 


@@ -202,7 +196,7 @@ def create_from_tiger_row(row: SaRow) -> SearchResult:
                                    'endnumber': str(row.endnumber),
                                    'step': str(row.step)},
                         country_code='us',
                                    'endnumber': str(row.endnumber),
                                    'step': str(row.step)},
                         country_code='us',

-                        centroid=Point(row.x, row.y),
+                        centroid=Point.from_wkb(row.centroid.data),

                         geometry=_filter_geometries(row))
 
 
                         geometry=_filter_geometries(row))
 
 


@@ -218,7 +212,7 @@ def create_from_postcode_row(row: SaRow) -> SearchResult:
                         rank_search=row.rank_search,
                         rank_address=row.rank_address,
                         country_code=row.country_code,
                         rank_search=row.rank_search,
                         rank_address=row.rank_address,
                         country_code=row.country_code,

-                        centroid=Point(row.x, row.y),
+                        centroid=Point.from_wkb(row.centroid.data),

                         indexed_date=row.indexed_date,
                         geometry=_filter_geometries(row))
 
                         indexed_date=row.indexed_date,
                         geometry=_filter_geometries(row))
 


@@ -228,13 +222,18 @@ async def add_result_details(conn: SearchConnection, result: SearchResult,
     """ Retrieve more details from the database according to the
         parameters specified in 'details'.
     """
     """ Retrieve more details from the database according to the
         parameters specified in 'details'.
     """

+    log().section('Query details for result')

     if details.address_details:
     if details.address_details:

+        log().comment('Query address details')

         await complete_address_details(conn, result)
     if details.linked_places:
         await complete_address_details(conn, result)
     if details.linked_places:

+        log().comment('Query linked places')

         await complete_linked_places(conn, result)
     if details.parented_places:
         await complete_linked_places(conn, result)
     if details.parented_places:

+        log().comment('Query parent places')

         await complete_parented_places(conn, result)
     if details.keywords:
         await complete_parented_places(conn, result)
     if details.keywords:

+        log().comment('Query keywords')

         await complete_keywords(conn, result)
 
 
         await complete_keywords(conn, result)