Merge remote-tracking branch 'upstream/master'

[nominatim.git] / lib / Geocode.php

diff --git a/lib/Geocode.php b/lib/Geocode.php
index 7ab53d97812a5cbf640672e93f0e963f8c6f10eb..cce85f2b31b8f78c982fe9f9674355d3a40a95e7 100644 (file)
--- a/lib/Geocode.php
+++ b/lib/Geocode.php
@@ -917,21 +917,14 @@ class Geocode
                     $aResult['lon'],
                     $aResult['lat']
                 );
                     $aResult['lon'],
                     $aResult['lat']
                 );

-                // Adjust importance for the number of exact string matches in the result
-                $iCountWords = 0;
-                $sAddress = $aResult['langaddress'];
-                foreach ($aRecheckWords as $i => $sWord) {
-                    if (stripos($sAddress, $sWord)!==false) {
-                        $iCountWords++;
-                        if (preg_match('/(^|,)\s*'.preg_quote($sWord, '/').'\s*(,|$)/', $sAddress)) $iCountWords += 0.1;
-                    }
-                }
-
-                $aResult['importance'] = $aResult['importance'] + ($iCountWords*0.1); // 0.1 is a completely arbitrary number but something in the range 0.1 to 0.5 would seem right

 
                 // secondary ordering (for results with same importance (the smaller the better):
                 // - approximate importance of address parts
 
                 // secondary ordering (for results with same importance (the smaller the better):
                 // - approximate importance of address parts

-                $aResult['foundorder'] = -$aResult['addressimportance']/10;
+                if (isset($aResult['addressimportance']) && $aResult['addressimportance']) {
+                    $aResult['foundorder'] = -$aResult['addressimportance']/10;
+                } else {
+                    $aResult['foundorder'] = -$aResult['importance'];
+                }

                 // - number of exact matches from the query
                 $aResult['foundorder'] -= $aResults[$aResult['place_id']]->iExactMatches;
                 // - importance of the class/type
                 // - number of exact matches from the query
                 $aResult['foundorder'] -= $aResults[$aResult['place_id']]->iExactMatches;
                 // - importance of the class/type


@@ -941,6 +934,21 @@ class Geocode
                 } else {
                     $aResult['foundorder'] += 0.01;
                 }
                 } else {
                     $aResult['foundorder'] += 0.01;
                 }

+                // - rank
+                $aResult['foundorder'] -= 0.00001 * (30 - $aResult['rank_search']);
+
+                // Adjust importance for the number of exact string matches in the result
+                $iCountWords = 0;
+                $sAddress = $aResult['langaddress'];
+                foreach ($aRecheckWords as $i => $sWord) {
+                    if (stripos($sAddress, $sWord)!==false) {
+                        $iCountWords++;
+                        if (preg_match('/(^|,)\s*'.preg_quote($sWord, '/').'\s*(,|$)/', $sAddress)) $iCountWords += 0.1;
+                    }
+                }
+
+                // 0.1 is a completely arbitrary number but something in the range 0.1 to 0.5 would seem right
+                $aResult['importance'] = $aResult['importance'] + ($iCountWords*0.1);

             }
             $aSearchResults[$iIdx] = $aResult;
         }
             }
             $aSearchResults[$iIdx] = $aResult;
         }