needs: create-archive
strategy:
matrix:
- flavour: [oldstuff, "ubuntu-20", "ubuntu-22"]
+ flavour: ["ubuntu-20", "ubuntu-24"]
include:
- - flavour: oldstuff
- ubuntu: 20
- postgresql: '9.6'
- postgis: '2.5'
- lua: '5.1'
- flavour: ubuntu-20
ubuntu: 20
- postgresql: 13
+ postgresql: 12
postgis: 3
- lua: '5.3'
- - flavour: ubuntu-22
- ubuntu: 22
- postgresql: 15
+ lua: '5.1'
+ - flavour: ubuntu-24
+ ubuntu: 24
+ postgresql: 17
postgis: 3
lua: '5.3'
flavour: ${{ matrix.flavour }}
lua: ${{ matrix.lua }}
- - name: Install test prerequisites (behave from apt)
- run: sudo apt-get install -y -qq python3-behave
- if: matrix.flavour == 'ubuntu-20'
-
- - name: Install test prerequisites (behave from pip)
+ - name: Install test prerequisites
run: pip3 install behave==1.2.6
- if: (matrix.flavour == 'oldstuff') || (matrix.flavour == 'ubuntu-22')
- - name: Install test prerequisites (from apt for Ununtu 2x)
+ - name: Install test prerequisites
run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn
- if: matrix.flavour != 'oldstuff'
- name: Install newer pytest-asyncio
run: pip3 install -U pytest-asyncio
if: matrix.flavour == 'ubuntu-20'
- - name: Install test prerequisites (from pip for Ubuntu 18)
- run: pip3 install pytest pytest-asyncio uvicorn
- if: matrix.flavour == 'oldstuff'
-
- name: Install Python webservers
run: pip3 install falcon starlette asgi_lifespan
- - name: Install latest pylint
- run: pip3 install -U pylint
- if: matrix.flavour == 'ubuntu-22'
+ - name: Install latest flake8
+ run: pip3 install -U flake8
- name: Python linting
- run: python3 -m pylint src
+ run: python3 -m flake8 src
working-directory: Nominatim
- if: matrix.flavour == 'ubuntu-22'
- name: Python unit tests
run: python3 -m pytest test/python
- name: BDD tests
run: |
- python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build --format=progress3
+ export PATH=$GITHUB_WORKSPACE/build/osm2pgsql:$PATH
+ python3 -m behave -DREMOVE_TEMPLATE=1 --format=progress3
working-directory: Nominatim/test/bdd
- name: Install mypy and typechecking info
run: pip3 install -U mypy osmium uvicorn types-PyYAML types-jinja2 types-psycopg2 types-psutil types-requests types-ujson types-Pygments typing-extensions
- if: matrix.flavour != 'oldstuff'
- name: Python static typechecking
- run: python3 -m mypy --strict src
- working-directory: Nominatim
- if: matrix.flavour != 'oldstuff'
-
- legacy-test:
- needs: create-archive
- runs-on: ubuntu-20.04
-
- strategy:
- matrix:
- postgresql: ["13", "16"]
-
- steps:
- - uses: actions/download-artifact@v4
- with:
- name: full-source
-
- - name: Unpack Nominatim
- run: tar xf nominatim-src.tar.bz2
-
- - name: Setup PHP
- uses: shivammathur/setup-php@v2
- with:
- php-version: '7.4'
-
- - uses: ./Nominatim/.github/actions/setup-postgresql
- with:
- postgresql-version: ${{ matrix.postgresql }}
- postgis-version: 3
-
- - name: Install Postgresql server dev
- run: sudo apt-get install postgresql-server-dev-$PGVER
- env:
- PGVER: ${{ matrix.postgresql }}
-
- - uses: ./Nominatim/.github/actions/build-nominatim
- with:
- cmake-args: -DBUILD_MODULE=on
-
- - name: Install test prerequisites
- run: sudo apt-get install -y -qq python3-behave
-
- - name: BDD tests (legacy tokenizer)
- run: |
- python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DAPI_ENGINE=php -DTOKENIZER=legacy --format=progress3
- working-directory: Nominatim/test/bdd
-
-
- php-test:
- needs: create-archive
- runs-on: ubuntu-22.04
-
- steps:
- - uses: actions/download-artifact@v4
- with:
- name: full-source
-
- - name: Unpack Nominatim
- run: tar xf nominatim-src.tar.bz2
-
- - uses: ./Nominatim/.github/actions/setup-postgresql
- with:
- postgresql-version: 15
- postgis-version: 3
-
- - name: Setup PHP
- uses: shivammathur/setup-php@v2
- with:
- php-version: 8.1
- tools: phpunit:9, phpcs, composer
- ini-values: opcache.jit=disable
- env:
- GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
- - name: PHP linting
- run: phpcs --report-width=120 .
+ run: python3 -m mypy --strict --python-version 3.8 src
working-directory: Nominatim
- - name: PHP unit tests
- run: phpunit ./
- working-directory: Nominatim/test/php
-
- - uses: ./Nominatim/.github/actions/build-nominatim
- with:
- flavour: 'ubuntu-22'
-
- - name: Install test prerequisites
- run: sudo apt-get install -y -qq python3-behave
-
- - name: BDD tests (php)
- run: |
- python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DAPI_ENGINE=php --format=progress3
- working-directory: Nominatim/test/bdd
-
-
install:
runs-on: ubuntu-latest
needs: create-archive
- name: Check full import
run: nominatim admin --check-database
+ migrate:
+ runs-on: ubuntu-24.04
+ needs: create-archive
+
+ steps:
+ - uses: actions/download-artifact@v4
+ with:
+ name: full-source
+
+ - name: Unpack Nominatim
+ run: tar xf nominatim-src.tar.bz2
+
+ - uses: ./Nominatim/.github/actions/setup-postgresql
+ with:
+ postgresql-version: 17
+ postgis-version: 3
+
+ - name: Install Python dependencies
+ run: |
+ sudo apt-get install --no-install-recommends virtualenv osm2pgsql
+
+ - name: Install Nominatim master version
+ run: |
+ virtualenv master
+ cd Nominatim
+ ../master/bin/pip install packaging/nominatim-db
+
+ - name: Install Nominatim from pypi
+ run: |
+ virtualenv release
+ ./release/bin/pip install nominatim-db
+
+ - name: Import Nominatim database using release
+ run: |
+ ./release/bin/nominatim import --osm-file Nominatim/test/testdb/apidb-test-data.pbf
+ ./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm
+
+ - name: Migrate to master version
+ run: |
+ ./master/bin/nominatim admin --migrate
+ ./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm
+
codespell:
runs-on: ubuntu-latest
steps: