bdd: move external process execution in separate func

[nominatim.git] / test / bdd / steps / osm_data.py

diff --git a/test/bdd/steps/osm_data.py b/test/bdd/steps/osm_data.py
index 926fb9ab9868de513619f53c9ef482b4837833ff..c1043baaed69c365e8b4742427d4ac8f9b5732fb 100644 (file)
--- a/test/bdd/steps/osm_data.py
+++ b/test/bdd/steps/osm_data.py
@@ -2,18 +2,41 @@ import subprocess
 import tempfile
 import random
 import os
-from nose.tools import * # for assert functions
+
+@given(u'the ([0-9.]+ )?grid')
+def define_node_grid(context, grid_step):
+    """
+    Define a grid of node positions.
+    Use a table to define the grid. The nodes must be integer ids. Optionally
+    you can give the grid distance. The default is 0.00001 degrees.
+    """
+    if grid_step is not None:
+        grid_step = float(grid_step.strip())
+    else:
+        grid_step = 0.00001
+
+    context.osm.set_grid([context.table.headings] + [list(h) for h in context.table],
+                          grid_step)
+
 
 @when(u'loading osm data')
 def load_osm_file(context):
+    """
+    Load the given data into a freshly created test data using osm2pgsql.
+    No further indexing is done.
 
+    The data is expected as attached text in OPL format.
+    """
     # create a OSM file in /tmp and import it
     with tempfile.NamedTemporaryFile(dir='/tmp', suffix='.opl', delete=False) as fd:
         fname = fd.name
         for line in context.text.splitlines():
             if line.startswith('n') and line.find(' x') < 0:
-                    line += " x%d y%d" % (random.random() * 360 - 180,
-                                          random.random() * 180 - 90)
+                coord = context.osm.grid_node(int(line[1:].split(' ')[0]))
+                if coord is None:
+                    coord = (random.random() * 360 - 180,
+                             random.random() * 180 - 90)
+                line += " x%f y%f" % coord
             fd.write(line.encode('utf-8'))
             fd.write(b'\n')
 
@@ -33,12 +56,22 @@ def load_osm_file(context):
 
 @when(u'updating osm data')
 def update_from_osm_file(context):
+    """
+    Update a database previously populated with 'loading osm data'.
+    Needs to run indexing on the existing data first to yield the correct result.
+
+    The data is expected as attached text in OPL format.
+    """
     context.nominatim.run_setup_script('create-functions', 'create-partition-functions')
 
     cur = context.db.cursor()
-    cur.execute("""insert into placex (osm_type, osm_id, class, type, name,
-                   admin_level,  housenumber, street, addr_place, isin, postcode,
-                   country_code, extratags, geometry) select * from place""")
+    cur.execute("""insert into placex (osm_type, osm_id, class, type, name, admin_level, address, extratags, geometry)
+                     select            osm_type, osm_id, class, type, name, admin_level, address, extratags, geometry from place""")
+    cur.execute(
+        """insert into location_property_osmline (osm_id, address, linegeo)
+             SELECT osm_id, address, geometry from place
+              WHERE class='place' and type='houses' and osm_type='W'
+                    and ST_GeometryType(geometry) = 'ST_LineString'""")
     context.db.commit()
     context.nominatim.run_setup_script('index', 'index-noanalyse')
     context.nominatim.run_setup_script('create-functions', 'create-partition-functions',