PHP code style: enforce long array initialisation (#1015)

[nominatim.git] / website / lookup.php

diff --git a/website/lookup.php b/website/lookup.php
index d1c81292bc99d20d5308053856035a71271de39e..71c93715f9e47621304bbcbdc3f88f542ff70e9e 100755 (executable)
--- a/website/lookup.php
+++ b/website/lookup.php
@@ -1,93 +1,69 @@
 <?php
 <?php

-       @define('CONST_ConnectionBucket_PageType', 'Reverse');
+@define('CONST_ConnectionBucket_PageType', 'Reverse');

 
 

-       require_once(dirname(dirname(__FILE__)).'/lib/init-website.php');
-       require_once(CONST_BasePath.'/lib/log.php');
-       require_once(CONST_BasePath.'/lib/PlaceLookup.php');
+require_once(dirname(dirname(__FILE__)).'/settings/settings.php');
+require_once(CONST_BasePath.'/lib/init-website.php');
+require_once(CONST_BasePath.'/lib/log.php');
+require_once(CONST_BasePath.'/lib/PlaceLookup.php');
+require_once(CONST_BasePath.'/lib/output.php');
+ini_set('memory_limit', '200M');

 
 

-       if (strpos(CONST_BulkUserIPs, ','.$_SERVER["REMOTE_ADDR"].',') !== false)
-       {
-               $fLoadAvg = getLoadAverage();
-               if ($fLoadAvg > 2) sleep(60);
-               if ($fLoadAvg > 4) sleep(120);
-               if ($fLoadAvg > 6)
-               {
-                       userError("Bulk User: Temporary block due to high server load");
-                       exit;
-               }
-       }
+$oParams = new Nominatim\ParameterParser();

 
 

-       $oDB =& getDB();
-       ini_set('memory_limit', '200M');
+// Format for output
+$sOutputFormat = $oParams->getSet('format', array('xml', 'json'), 'xml');

 
 

-       // Format for output
-       $sOutputFormat = 'xml';
-       if (isset($_GET['format']) && ($_GET['format'] == 'xml' || $_GET['format'] == 'json'))
-       {
-               $sOutputFormat = $_GET['format'];
-       }
+// Preferred language
+$aLangPrefOrder = $oParams->getPreferredLanguages();

 
 

-       // Show address breakdown
-       $bShowAddressDetails = true;
-       if (isset($_GET['addressdetails'])) $bShowAddressDetails = (bool)$_GET['addressdetails'];
+$oDB =& getDB();

 
 

-       // Preferred language
-       $aLangPrefOrder = getPreferredLanguages();
+$hLog = logStart($oDB, 'place', $_SERVER['QUERY_STRING'], $aLangPrefOrder);

 
 

-       $hLog = logStart($oDB, 'place', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
+$aSearchResults = array();
+$aCleanedQueryParts = array();

 
 

-       $aSearchResults = array();
-       if (isset($_GET['osm_ids']))
-       {
-               $oPlaceLookup = new PlaceLookup($oDB);
-               $oPlaceLookup->setLanguagePreference($aLangPrefOrder);
-               $oPlaceLookup->setIncludeAddressDetails($bShowAddressDetails);
-               
-               $osm_ids = explode(',', $_GET['osm_ids']);
-               
-               if ( count($osm_ids) > CONST_Places_Max_ID_count ) 
-               {
-                       userError('Bulk User: Only ' . CONST_Places_Max_ID_count . " ids are allowed in one request.");
-                       exit;
-               }
-               
-               $type = ''; 
-               $id = 0;
-               foreach ($osm_ids AS $item) 
-               {
-                       // Skip empty items
-                       if (empty($item)) continue;
-                       
-                       $type = $item[0];
-                       $id = (int) substr($item, 1);
-                       if ( $id > 0 && ($type == 'N' || $type == 'W' || $type == 'R') )
-                       {
-                               $oPlaceLookup->setOSMID($type, $id);
-                               $oPlace = $oPlaceLookup->lookup();
-                               if ($oPlace){
-                                       // we want to use the search-* output templates, so we need to fill
-                                       // $aSearchResults and slightly change the (reverse search) oPlace
-                                       // key names
-                                       $oResult = $oPlace;
-                                       unset($oResult['aAddress']);
-                                       $oResult['address'] = $oPlace['aAddress'];
-                                       unset($oResult['langaddress']);
-                                       $oResult['name'] = $oPlace['langaddress'];
-                                       $aSearchResults[] = $oResult;
-                               }
-                       }
-               }
-       }
+$oPlaceLookup = new Nominatim\PlaceLookup($oDB);
+$oPlaceLookup->loadParamArray($oParams);

 
 

+$aOsmIds = explode(',', $oParams->getString('osm_ids', ''));

 
 

-       if (CONST_Debug) exit;
+if (count($aOsmIds) > CONST_Places_Max_ID_count) {
+    userError('Bulk User: Only ' . CONST_Places_Max_ID_count . ' ids are allowed in one request.');
+}

 
 

-       $sXmlRootTag = 'lookupresults';
-       // we initialize these to avoid warnings in our logfile
-       $sQuery = '';
-       $sViewBox = '';
-       $bShowPolygons = '';
-       $aExcludePlaceIDs = [];
-       $sMoreURL = '';
+foreach ($aOsmIds as $sItem) {
+    // Skip empty sItem
+    if (empty($sItem)) continue;
+    
+    $sType = $sItem[0];
+    $iId = (int) substr($sItem, 1);
+    if ($iId > 0 && ($sType == 'N' || $sType == 'W' || $sType == 'R')) {
+        $aCleanedQueryParts[] = $sType . $iId;
+        $oPlace = $oPlaceLookup->lookupOSMID($sType, $iId);
+        if ($oPlace) {
+            // we want to use the search-* output templates, so we need to fill
+            // $aSearchResults and slightly change the (reverse search) oPlace
+            // key names
+            $oResult = $oPlace;
+            unset($oResult['aAddress']);
+            if (isset($oPlace['aAddress'])) $oResult['address'] = $oPlace['aAddress'];
+            unset($oResult['langaddress']);
+            $oResult['name'] = $oPlace['langaddress'];
+            $aSearchResults[] = $oResult;
+        }
+    }
+}

 
 

-       include(CONST_BasePath.'/lib/template/search-'.$sOutputFormat.'.php');
+
+if (CONST_Debug) exit;
+
+$sXmlRootTag = 'lookupresults';
+$sQuery = join(',', $aCleanedQueryParts);
+// we initialize these to avoid warnings in our logfile
+$sViewBox = '';
+$bShowPolygons = '';
+$aExcludePlaceIDs = array();
+$sMoreURL = '';
+
+include(CONST_BasePath.'/lib/template/search-'.$sOutputFormat.'.php');