Merge remote-tracking branch 'upstream/master'

[nominatim.git] / lib / AddressDetails.php

diff --git a/lib/AddressDetails.php b/lib/AddressDetails.php
index a721f4c5ea689b66c6aa208c99c0458c00911653..3d17ede51cb4d3c605f3d166dca58af542c7a15f 100644 (file)
--- a/lib/AddressDetails.php
+++ b/lib/AddressDetails.php
@@ -2,7 +2,7 @@
 
 namespace Nominatim;
 
-require_once(CONST_BasePath.'/lib/ClassTypes.php');
+require_once(CONST_LibDir.'/ClassTypes.php');
 
 /**
  * Detailed list of address parts for a single result
@@ -64,21 +64,13 @@ class AddressDetails
     public function getAddressNames($sCountry = null)
     {
         $aAddress = array();
-        $aFallback = array();
 
         foreach ($this->aAddressLines as $aLine) {
             if (!self::isAddress($aLine)) {
                 continue;
             }
 
-            $bFallback = false;
-            $sTypeLabel = ClassTypes\getSimpleLabel($aLine);
-
-            if ($sTypeLabel === false) {
-                $aTypeLabel = ClassTypes\getFallbackLabel($aLine['rank_address'],
-                                                          $sCountry);
-                $bFallback = true;
-            }
+            $sTypeLabel = ClassTypes\getLabelTag($aLine);
 
             $sName = null;
             if (isset($aLine['localname']) && $aLine['localname']!=='') {
@@ -90,11 +82,9 @@ class AddressDetails
             if (isset($sName)) {
                 $sTypeLabel = strtolower(str_replace(' ', '_', $sTypeLabel));
                 if (!isset($aAddress[$sTypeLabel])
-                    || (isset($aFallback[$sTypeLabel]) && $aFallback[$sTypeLabel])
                     || $aLine['class'] == 'place'
                 ) {
                     $aAddress[$sTypeLabel] = $sName;
-                    $aFallback[$sTypeLabel] = $bFallback;
                 }
             }
         }
@@ -127,8 +117,12 @@ class AddressDetails
 
             if ($aLine['type'] == 'postcode' || $aLine['type'] == 'postal_code') {
                 $aJson['postcode'] = $aLine['localname'];
-            } elseif ($aLine['type'] == 'house_number') {
+                continue;
+            }
+
+            if ($aLine['type'] == 'house_number') {
                 $aJson['housenumber'] = $aLine['localname'];
+                continue;
             }
 
             if ($this->iPlaceID == $aLine['place_id']) {