fix new linting issues from pylint 2.16

[nominatim.git] / nominatim / db / properties.py

diff --git a/nominatim/db/properties.py b/nominatim/db/properties.py
index 270204872dd56459691c4105156fe8073d6aa815..e8d5e0ca5c47194f7e72402f3c6b541a251c6a2a 100644 (file)
--- a/nominatim/db/properties.py
+++ b/nominatim/db/properties.py
@@ -7,9 +7,12 @@
 """
 Query and access functions for the in-database property table.
 """
 """
 Query and access functions for the in-database property table.
 """

+from typing import Optional, cast

 
 

-def set_property(conn, name, value):
-    """ Add or replace the propery with the given name.
+from nominatim.db.connection import Connection
+
+def set_property(conn: Connection, name: str, value: str) -> None:
+    """ Add or replace the property with the given name.

     """
     with conn.cursor() as cur:
         cur.execute('SELECT value FROM nominatim_properties WHERE property = %s',
     """
     with conn.cursor() as cur:
         cur.execute('SELECT value FROM nominatim_properties WHERE property = %s',


@@ -23,8 +26,9 @@ def set_property(conn, name, value):
         cur.execute(sql, (value, name))
     conn.commit()
 
         cur.execute(sql, (value, name))
     conn.commit()
 

-def get_property(conn, name):
-    """ Return the current value of the given propery or None if the property
+
+def get_property(conn: Connection, name: str) -> Optional[str]:
+    """ Return the current value of the given property or None if the property

         is not set.
     """
     if not conn.table_exists('nominatim_properties'):
         is not set.
     """
     if not conn.table_exists('nominatim_properties'):


@@ -34,4 +38,10 @@ def get_property(conn, name):
         cur.execute('SELECT value FROM nominatim_properties WHERE property = %s',
                     (name, ))
 
         cur.execute('SELECT value FROM nominatim_properties WHERE property = %s',
                     (name, ))
 

-        return cur.fetchone()[0] if cur.rowcount > 0 else None
+        if cur.rowcount == 0:
+            return None
+
+        result = cur.fetchone()
+        assert result is not None
+
+        return cast(Optional[str], result[0])