Merge remote-tracking branch 'upstream/master'

[nominatim.git] / lib / ReverseGeocode.php

diff --git a/lib/ReverseGeocode.php b/lib/ReverseGeocode.php
index 41da26676f771cbd1750b66a3a790400be469e0d..8e5e8bd1de59dd1d13c502d169faf5fcb4153481 100644 (file)
--- a/lib/ReverseGeocode.php
+++ b/lib/ReverseGeocode.php
@@ -72,12 +72,12 @@ class ReverseGeocode
             'Could not determine closest housenumber on an osm interpolation line.'
         );
     }
-    
+
     protected function polygonFunctions($sPointSQL, $iMaxRank)
     {
         // starts the nopolygonFound function if no polygon is found with the lookupPolygon function
         $oResult = null;
-        
+
         $aPlace = $this->lookupPolygon($sPointSQL, $iMaxRank);
         if ($aPlace) {
             $oResult = new Result($aPlace['place_id']);
@@ -91,33 +91,34 @@ class ReverseGeocode
         }
         return $oResult;
     }
-    
+
     protected function noPolygonFound($sPointSQL, $iMaxRank)
     {
         // searches for polygon in table country_osm_grid which contains the searchpoint
         // and searches for the nearest place node to the searchpoint in this polygon
-        $sSQL = 'SELECT * FROM country_osm_grid';
-        $sSQL .= ' WHERE ST_CONTAINS (geometry, '.$sPointSQL.' )';
-        
+        $sSQL = 'SELECT country_code FROM country_osm_grid';
+        $sSQL .= ' WHERE ST_CONTAINS (geometry, '.$sPointSQL.') limit 1';
+
         $aPoly = chksql(
             $this->oDB->getRow($sSQL),
             'Could not determine polygon containing the point.'
         );
         if ($aPoly) {
             $sCountryCode = $aPoly['country_code'];
-            
-            $sSQL = 'SELECT *, ST_distance('.$sPointSQL.', geometry) as distance';
+
+            $sSQL = 'SELECT place_id, ST_distance('.$sPointSQL.', geometry) as distance';
             $sSQL .= ' FROM placex';
             $sSQL .= ' WHERE osm_type = \'N\'';
             $sSQL .= ' AND country_code = \''.$sCountryCode.'\'';
             $sSQL .= ' AND rank_address > 0';
-            $sSQL .= ' AND rank_address <= ' .$iMaxRank;
+            $sSQL .= ' AND rank_address <= ' .min(25, $iMaxRank);
             $sSQL .= ' AND type != \'postcode\'';
             $sSQL .= ' AND name IS NOT NULL ';
             $sSQL .= ' and indexed_status = 0 and linked_place_id is null';
+            $sSQL .= ' AND ST_DWithin('.$sPointSQL.', geometry, 1.0)';
             $sSQL .= ' ORDER BY distance ASC, rank_address DESC';
             $sSQL .= ' LIMIT 1';
-            
+
             if (CONST_Debug) var_dump($sSQL);
             $aPlacNode = chksql(
                 $this->oDB->getRow($sSQL),
@@ -128,19 +129,19 @@ class ReverseGeocode
             }
         }
     }
-    
+
     protected function lookupPolygon($sPointSQL, $iMaxRank)
     {
         // searches for polygon where the searchpoint is within
         // if a polygon is found, placenodes with a higher rank are searched inside the polygon
-    
+
         // polygon search begins at suburb-level
         if ($iMaxRank > 25) $iMaxRank = 25;
         // no polygon search over country-level
         if ($iMaxRank < 4) $iMaxRank = 4;
         // search for polygon
-        $sSQL = 'SELECT * FROM';
-        $sSQL .= '(select place_id,parent_place_id,rank_address, rank_search, country_code, geometry';
+        $sSQL = 'SELECT place_id, parent_place_id, rank_address, rank_search FROM';
+        $sSQL .= '(select place_id, parent_place_id, rank_address, rank_search, country_code, geometry';
         $sSQL .= ' FROM placex';
         $sSQL .= ' WHERE ST_GeometryType(geometry) in (\'ST_Polygon\', \'ST_MultiPolygon\')';
         $sSQL .= ' AND rank_address Between 4 AND ' .$iMaxRank;
@@ -162,7 +163,7 @@ class ReverseGeocode
             $iRankAddress = $aPoly['rank_address'];
             $iRankSearch = $aPoly['rank_search'];
             $iPlaceID = $aPoly['place_id'];
-            
+
             if ($iRankAddress != $iMaxRank) {
             //search diameter for the place node search
                 if ($iMaxRank <= 4) {
@@ -180,8 +181,8 @@ class ReverseGeocode
                 } elseif ($iMaxRank <= 25) {
                     $fSearchDiam = 0.1;
                 }
-                
-                $sSQL = 'SELECT *';
+
+                $sSQL = 'SELECT place_id';
                 $sSQL .= ' FROM (';
                 $sSQL .= ' SELECT place_id, rank_address,country_code, geometry,';
                 $sSQL .= ' ST_distance('.$sPointSQL.', geometry) as distance';
@@ -208,7 +209,7 @@ class ReverseGeocode
                 $sSQL .= ' WHERE ST_CONTAINS((SELECT geometry FROM placex WHERE place_id = '.$iPlaceID.'), geometry )';
                 $sSQL .= ' ORDER BY distance ASC, rank_address DESC';
                 $sSQL .= ' LIMIT 1';
-                
+
                 if (CONST_Debug) var_dump($sSQL);
                 $aPlacNode = chksql(
                     $this->oDB->getRow($sSQL),
@@ -221,7 +222,7 @@ class ReverseGeocode
         }
         return $aPoly;
     }
-    
+
 
     public function lookup($fLat, $fLon, $bDoInterpolation = true)
     {
@@ -245,7 +246,7 @@ class ReverseGeocode
         $aPlace = null;
         $fMaxAreaDistance = 1;
         $bIsTigerStreet = false;
-       
+
         // for POI or street level
         if ($iMaxRank >= 26) {
             $sSQL = 'select place_id,parent_place_id,rank_address,country_code,';
@@ -274,14 +275,13 @@ class ReverseGeocode
                 $this->oDB->getRow($sSQL),
                 'Could not determine closest place.'
             );
-            
+
             if ($aPlace) {
-                    
                 $iDistance = $aPlace['distance'];
                 $iPlaceID = $aPlace['place_id'];
                 $oResult = new Result($iPlaceID);
                 $iParentPlaceID = $aPlace['parent_place_id'];
-                
+
                 if ($bDoInterpolation && $iMaxRank >= 30) {
                     if ($aPlace['rank_address'] <=27) {
                         $iDistance = 0.001;
@@ -293,7 +293,7 @@ class ReverseGeocode
                         $oResult->iHouseNumber = closestHouseNumber($aHouse);
                     }
                 }
-                
+
                 // if street and maxrank > streetlevel
                 if (($aPlace['rank_address'] <=27)&& $iMaxRank > 27) {
                     // find the closest object (up to a certain radius) of which the street is a parent of
@@ -319,7 +319,7 @@ class ReverseGeocode
                         $iPlaceID = $aStreet['place_id'];
                         $oResult = new Result($iPlaceID);
                         $iParentPlaceID = $aStreet['parent_place_id'];
-                            
+
                         if ($bDoInterpolation && $iMaxRank >= 30) {
                             $aHouse = $this->lookupInterpolation($sPointSQL, $iDistance, $iParentPlaceID);
 
@@ -330,7 +330,7 @@ class ReverseGeocode
                         }
                     }
                 }
-                
+
                   // In the US we can check TIGER data for nearest housenumber
                 if (CONST_Use_US_Tiger_Data && $aPlace['country_code'] == 'us' && $this->iMaxRank >= 28) {
                     $fSearchDiam = $aPlace['rank_address'] > 28 ? $aPlace['distance'] : 0.001;