Merge pull request #2312 from lonvia/icu-tokenizer

[nominatim.git] / test / python / test_tokenizer_factory.py

diff --git a/test/python/test_tokenizer_factory.py b/test/python/test_tokenizer_factory.py
index 63c6915b1f81b371295c161718e115d32e31a433..69517e9401739c1e23ae8cdc3d892cf84f9ca2a2 100644 (file)
--- a/test/python/test_tokenizer_factory.py
+++ b/test/python/test_tokenizer_factory.py
@@ -7,7 +7,7 @@ import pytest
 from nominatim.db import properties
 from nominatim.tokenizer import factory
 from nominatim.errors import UsageError
 from nominatim.db import properties
 from nominatim.tokenizer import factory
 from nominatim.errors import UsageError

-import dummy_tokenizer
+from dummy_tokenizer import DummyTokenizer

 
 @pytest.fixture
 def test_config(def_config, tmp_path):
 
 @pytest.fixture
 def test_config(def_config, tmp_path):


@@ -15,37 +15,27 @@ def test_config(def_config, tmp_path):
     return def_config
 
 
     return def_config
 
 

-@pytest.fixture
-def tokenizer_import(monkeypatch):
-    monkeypatch.setenv('NOMINATIM_TOKENIZER', 'dummy')
-
-    def _import_dummy(module, *args, **kwargs):
-        return dummy_tokenizer
-
-    monkeypatch.setattr(importlib, "import_module", _import_dummy)
-
-

 def test_setup_dummy_tokenizer(temp_db_conn, test_config,
 def test_setup_dummy_tokenizer(temp_db_conn, test_config,

-                               tokenizer_import, property_table):
+                               tokenizer_mock, property_table):

     tokenizer = factory.create_tokenizer(test_config)
 
     tokenizer = factory.create_tokenizer(test_config)
 

-    assert isinstance(tokenizer, dummy_tokenizer.DummyTokenizer)
+    assert isinstance(tokenizer, DummyTokenizer)

     assert tokenizer.init_state == "new"
     assert (test_config.project_dir / 'tokenizer').is_dir()
 
     assert properties.get_property(temp_db_conn, 'tokenizer') == 'dummy'
 
 
     assert tokenizer.init_state == "new"
     assert (test_config.project_dir / 'tokenizer').is_dir()
 
     assert properties.get_property(temp_db_conn, 'tokenizer') == 'dummy'
 
 

-def test_setup_tokenizer_dir_exists(test_config, tokenizer_import, property_table):
+def test_setup_tokenizer_dir_exists(test_config, tokenizer_mock, property_table):

     (test_config.project_dir / 'tokenizer').mkdir()
 
     tokenizer = factory.create_tokenizer(test_config)
 
     (test_config.project_dir / 'tokenizer').mkdir()
 
     tokenizer = factory.create_tokenizer(test_config)
 

-    assert isinstance(tokenizer, dummy_tokenizer.DummyTokenizer)
+    assert isinstance(tokenizer, DummyTokenizer)

     assert tokenizer.init_state == "new"
 
 
     assert tokenizer.init_state == "new"
 
 

-def test_setup_tokenizer_dir_failure(test_config, tokenizer_import, property_table):
+def test_setup_tokenizer_dir_failure(test_config, tokenizer_mock, property_table):

     (test_config.project_dir / 'tokenizer').write_text("foo")
 
     with pytest.raises(UsageError):
     (test_config.project_dir / 'tokenizer').write_text("foo")
 
     with pytest.raises(UsageError):


@@ -59,16 +49,16 @@ def test_setup_bad_tokenizer_name(test_config, monkeypatch):
         factory.create_tokenizer(test_config)
 
 def test_load_tokenizer(temp_db_conn, test_config,
         factory.create_tokenizer(test_config)
 
 def test_load_tokenizer(temp_db_conn, test_config,

-                        tokenizer_import, property_table):
+                        tokenizer_mock, property_table):

     factory.create_tokenizer(test_config)
 
     tokenizer = factory.get_tokenizer_for_db(test_config)
 
     factory.create_tokenizer(test_config)
 
     tokenizer = factory.get_tokenizer_for_db(test_config)
 

-    assert isinstance(tokenizer, dummy_tokenizer.DummyTokenizer)
+    assert isinstance(tokenizer, DummyTokenizer)

     assert tokenizer.init_state == "loaded"
 
 
     assert tokenizer.init_state == "loaded"
 
 

-def test_load_no_tokenizer_dir(test_config, tokenizer_import, property_table):
+def test_load_no_tokenizer_dir(test_config, tokenizer_mock, property_table):

     factory.create_tokenizer(test_config)
 
     test_config.project_dir = test_config.project_dir / 'foo'
     factory.create_tokenizer(test_config)
 
     test_config.project_dir = test_config.project_dir / 'foo'


@@ -77,7 +67,7 @@ def test_load_no_tokenizer_dir(test_config, tokenizer_import, property_table):
         factory.get_tokenizer_for_db(test_config)
 
 
         factory.get_tokenizer_for_db(test_config)
 
 

-def test_load_missing_propoerty(temp_db_cursor, test_config, tokenizer_import, property_table):
+def test_load_missing_propoerty(temp_db_cursor, test_config, tokenizer_mock, property_table):

     factory.create_tokenizer(test_config)
 
     temp_db_cursor.execute("TRUNCATE TABLE nominatim_properties")
     factory.create_tokenizer(test_config)
 
     temp_db_cursor.execute("TRUNCATE TABLE nominatim_properties")