Merge remote-tracking branch 'upstream/master'

[nominatim.git] / test / python / cli / test_cmd_refresh.py

diff --git a/test/python/cli/test_cmd_refresh.py b/test/python/cli/test_cmd_refresh.py
index ed3a68babce0a21256c860f94345cedcf5928ec2..f3f93f0ff3409553c73470f7a612a1b10cd663d1 100644 (file)
--- a/test/python/cli/test_cmd_refresh.py
+++ b/test/python/cli/test_cmd_refresh.py
@@ -24,7 +24,6 @@ class TestRefresh:
     @pytest.mark.parametrize("command,func", [
                              ('address-levels', 'load_address_levels_from_config'),
                              ('wiki-data', 'import_wikipedia_articles'),
     @pytest.mark.parametrize("command,func", [
                              ('address-levels', 'load_address_levels_from_config'),
                              ('wiki-data', 'import_wikipedia_articles'),

-                             ('osm-views', 'import_osm_views_geotiff')

                              ('importance', 'recompute_importance'),
                              ('website', 'setup_website'),
                              ])
                              ('importance', 'recompute_importance'),
                              ('website', 'setup_website'),
                              ])


@@ -72,21 +71,27 @@ class TestRefresh:
 
         assert self.call_nominatim('refresh', '--wiki-data') == 1
 
 
         assert self.call_nominatim('refresh', '--wiki-data') == 1
 

-    def test_refresh_osm_views_geotiff_file_not_found(self, monkeypatch):
-        monkeypatch.setenv('NOMINATIM_OSM_VIEWS_DATA_PATH', 'gjoiergjeroi345Q')
+    def test_refresh_secondary_importance_file_not_found(self):
+        assert self.call_nominatim('refresh', '--secondary-importance') == 1

 
 

-        assert self.call_nominatim('refresh', '--osm-views') == 1

 
 

-    def test_refresh_importance_computed_after_wiki_and_osm_views_import(self, monkeypatch):
+    def test_refresh_secondary_importance_new_table(self, mock_func_factory):
+        mocks = [mock_func_factory(nominatim.tools.refresh, 'import_secondary_importance'),
+                 mock_func_factory(nominatim.tools.refresh, 'create_functions')]
+
+        assert self.call_nominatim('refresh', '--secondary-importance') == 0
+        assert mocks[0].called == 1
+        assert mocks[1].called == 1
+
+
+    def test_refresh_importance_computed_after_wiki_import(self, monkeypatch):

         calls = []
         monkeypatch.setattr(nominatim.tools.refresh, 'import_wikipedia_articles',
                             lambda *args, **kwargs: calls.append('import') or 0)
         calls = []
         monkeypatch.setattr(nominatim.tools.refresh, 'import_wikipedia_articles',
                             lambda *args, **kwargs: calls.append('import') or 0)

-        monkeypatch.setattr(nominatim.tools.refresh, 'import_osm_views_geotiff',
-                            lambda *args, **kwargs: calls.append('import') or 0)

         monkeypatch.setattr(nominatim.tools.refresh, 'recompute_importance',
                             lambda *args, **kwargs: calls.append('update'))
 
         monkeypatch.setattr(nominatim.tools.refresh, 'recompute_importance',
                             lambda *args, **kwargs: calls.append('update'))
 

-        assert self.call_nominatim('refresh', '--importance', '--wiki-data', '--osm-views') == 0
+        assert self.call_nominatim('refresh', '--importance', '--wiki-data') == 0

 
         assert calls == ['import', 'update']
 
 
         assert calls == ['import', 'update']