Merge pull request #362 from mtmail/fix-timeout-on-detail-pages

[nominatim.git] / website / details.php

diff --git a/website/details.php b/website/details.php
index b7a38b2d7cc7c1cea3c000835de8e68b8393475a..ad753a82a5bb93075deb5bf466287e3bb4bb6304 100755 (executable)
--- a/website/details.php
+++ b/website/details.php
@@ -1,25 +1,52 @@
 <?php
 <?php

-        require_once(dirname(dirname(__FILE__)).'/lib/init-website.php');
-        require_once(CONST_BasePath.'/lib/log.php');
+       @define('CONST_ConnectionBucket_PageType', 'Details');
+
+       require_once(dirname(dirname(__FILE__)).'/lib/init-website.php');
+       require_once(CONST_BasePath.'/lib/log.php');

 
        $sOutputFormat = 'html';
 
        $sOutputFormat = 'html';

-/*
-        $fLoadAvg = getLoadAverage();
-        if ($fLoadAvg > 3)
-        {
-               echo "Page temporarily blocked due to high server load\n";
-                exit;
-        }
-*/
+       /*
+          $fLoadAvg = getLoadAverage();
+          if ($fLoadAvg > 3)
+          {
+          echo "Page temporarily blocked due to high server load\n";
+          exit;
+          }
+        */

        ini_set('memory_limit', '200M');
 
        $oDB =& getDB();
 
        ini_set('memory_limit', '200M');
 
        $oDB =& getDB();
 

+       $aLangPrefOrder = getPreferredLanguages();
+       $sLanguagePrefArraySQL = "ARRAY[".join(',',array_map("getDBQuoted",$aLangPrefOrder))."]";
+

        if (isset($_GET['osmtype']) && isset($_GET['osmid']) && (int)$_GET['osmid'] && ($_GET['osmtype'] == 'N' || $_GET['osmtype'] == 'W' || $_GET['osmtype'] == 'R'))
        {
                $_GET['place_id'] = $oDB->getOne("select place_id from placex where osm_type = '".$_GET['osmtype']."' and osm_id = ".(int)$_GET['osmid']." order by type = 'postcode' asc");
        if (isset($_GET['osmtype']) && isset($_GET['osmid']) && (int)$_GET['osmid'] && ($_GET['osmtype'] == 'N' || $_GET['osmtype'] == 'W' || $_GET['osmtype'] == 'R'))
        {
                $_GET['place_id'] = $oDB->getOne("select place_id from placex where osm_type = '".$_GET['osmtype']."' and osm_id = ".(int)$_GET['osmid']." order by type = 'postcode' asc");

+
+               // Be nice about our error messages for broken geometry
+
+               if (!$_GET['place_id'])
+               {
+                       $aPointDetails = $oDB->getRow("select osm_type, osm_id, errormessage, class, type, get_name_by_language(name,$sLanguagePrefArraySQL) as localname, ST_AsText(prevgeometry) as prevgeom, ST_AsText(newgeometry) as newgeom from import_polygon_error where osm_type = '".$_GET['osmtype']."' and osm_id = ".(int)$_GET['osmid']." order by updated desc limit 1");
+                       if (!PEAR::isError($aPointDetails) && $aPointDetails) {
+                               if (preg_match('/\[(-?\d+\.\d+) (-?\d+\.\d+)\]/', $aPointDetails['errormessage'], $aMatches))
+                               {
+                                       $aPointDetails['error_x'] = $aMatches[1];
+                                       $aPointDetails['error_y'] = $aMatches[2];
+                               }
+                               else
+                               {
+                                       $aPointDetails['error_x'] = 0;
+                                       $aPointDetails['error_y'] = 0;
+                               }
+                               include(CONST_BasePath.'/lib/template/details-error-'.$sOutputFormat.'.php');
+                               exit;
+                       }
+               }

        }
 
        }
 

+

        if (!isset($_GET['place_id']))
        {
                echo "Please select a place id";
        if (!isset($_GET['place_id']))
        {
                echo "Please select a place id";


@@ -33,9 +60,6 @@
        $iParentPlaceID = $oDB->getOne('select parent_place_id from location_property_aux where place_id = '.$iPlaceID);
        if ($iParentPlaceID) $iPlaceID = $iParentPlaceID;
 
        $iParentPlaceID = $oDB->getOne('select parent_place_id from location_property_aux where place_id = '.$iPlaceID);
        if ($iParentPlaceID) $iPlaceID = $iParentPlaceID;
 

-       $aLangPrefOrder = getPreferredLanguages();
-       $sLanguagePrefArraySQL = "ARRAY[".join(',',array_map("getDBQuoted",$aLangPrefOrder))."]";
-

        $hLog = logStart($oDB, 'details', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
 
        // Make sure the point we are reporting on is fully indexed
        $hLog = logStart($oDB, 'details', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
 
        // Make sure the point we are reporting on is fully indexed


@@ -43,20 +67,20 @@
        //$oDB->query($sSQL);
 
        // Get the details for this point
        //$oDB->query($sSQL);
 
        // Get the details for this point

-       $sSQL = "select place_id, osm_type, osm_id, class, type, name, admin_level, housenumber, street, isin, postcode, country_code, importance, wikipedia,";
-       $sSQL .= " parent_place_id, rank_address, rank_search, get_searchrank_label(rank_search) as rank_search_label, get_name_by_language(name,$sLanguagePrefArraySQL) as localname, ";
-       $sSQL .= " ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea,ST_GeometryType(geometry) as geotype, ST_Y(ST_Centroid(geometry)) as lat,ST_X(ST_Centroid(geometry)) as lon ";
+       $sSQL = "select place_id, osm_type, osm_id, class, type, name, admin_level, housenumber, street, isin, postcode, calculated_country_code as country_code, importance, wikipedia,";
+       $sSQL .= " to_char(indexed_date, 'YYYY-MM-DD HH24:MI') as indexed_date, parent_place_id, rank_address, rank_search, get_searchrank_label(rank_search) as rank_search_label, get_name_by_language(name,$sLanguagePrefArraySQL) as localname, ";
+       $sSQL .= " ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea, ";
+       //$sSQL .= " ST_Area(geometry::geography) as area, ";
+       $sSQL .= " ST_y(centroid) as lat, ST_x(centroid) as lon,";
+       $sSQL .= " case when importance = 0 OR importance IS NULL then 0.75-(rank_search::float/40) else importance end as calculated_importance, ";
+       $sSQL .= " ST_AsText(CASE WHEN ST_NPoints(geometry) > 5000 THEN ST_SimplifyPreserveTopology(geometry, 0.0001) ELSE geometry END) as outlinestring";

        $sSQL .= " from placex where place_id = $iPlaceID";
        $aPointDetails = $oDB->getRow($sSQL);
        if (PEAR::IsError($aPointDetails))
        {
                failInternalError("Could not get details of place object.", $sSQL, $aPointDetails);
        }
        $sSQL .= " from placex where place_id = $iPlaceID";
        $aPointDetails = $oDB->getRow($sSQL);
        if (PEAR::IsError($aPointDetails))
        {
                failInternalError("Could not get details of place object.", $sSQL, $aPointDetails);
        }

-
-        $aPointDetails['localname'] = $aPointDetails['localname']?$aPointDetails['localname']:$aPointDetails['housenumber'];
-       $fLon = $aPointDetails['lon'];
-       $fLat = $aPointDetails['lat'];
-       $iZoom = 14;
+       $aPointDetails['localname'] = $aPointDetails['localname']?$aPointDetails['localname']:$aPointDetails['housenumber'];

 
        $aClassType = getClassTypesWithImportance();
        $aPointDetails['icon'] = $aClassType[$aPointDetails['class'].':'.$aPointDetails['type']]['icon'];
 
        $aClassType = getClassTypesWithImportance();
        $aPointDetails['icon'] = $aClassType[$aPointDetails['class'].':'.$aPointDetails['type']]['icon'];


@@ -64,66 +88,46 @@
        // Get all alternative names (languages, etc)
        $sSQL = "select (each(name)).key,(each(name)).value from placex where place_id = $iPlaceID order by (each(name)).key";
        $aPointDetails['aNames'] = $oDB->getAssoc($sSQL);
        // Get all alternative names (languages, etc)
        $sSQL = "select (each(name)).key,(each(name)).value from placex where place_id = $iPlaceID order by (each(name)).key";
        $aPointDetails['aNames'] = $oDB->getAssoc($sSQL);

+       if (PEAR::isError($aPointDetails['aNames'])) // possible timeout
+       {
+               $aPointDetails['aNames'] = [];
+       }

 
        // Extra tags
        $sSQL = "select (each(extratags)).key,(each(extratags)).value from placex where place_id = $iPlaceID order by (each(extratags)).key";
        $aPointDetails['aExtraTags'] = $oDB->getAssoc($sSQL);
 
        // Extra tags
        $sSQL = "select (each(extratags)).key,(each(extratags)).value from placex where place_id = $iPlaceID order by (each(extratags)).key";
        $aPointDetails['aExtraTags'] = $oDB->getAssoc($sSQL);

-
-       // Get the bounding box and outline polygon
-       $sSQL = "select ST_AsText(geometry) as outlinestring,";
-       $sSQL .= "ST_YMin(geometry) as minlat,ST_YMax(geometry) as maxlat,";
-       $sSQL .= "ST_XMin(geometry) as minlon,ST_XMax(geometry) as maxlon";
-       $sSQL .= " from placex where place_id = $iPlaceID";
-       $aPointPolygon = $oDB->getRow($sSQL);
-       IF (PEAR::IsError($aPointPolygon))
-       {
-               failInternalError("Could not get bounding box of place object.", $sSQL, $aPointPolygon);
-       }
-       if (preg_match('#POLYGON\\(\\(([- 0-9.,]+)#',$aPointPolygon['outlinestring'],$aMatch))
-       {
-               preg_match_all('/(-?[0-9.]+) (-?[0-9.]+)/',$aMatch[1],$aPolyPoints,PREG_SET_ORDER);
-       }
-       elseif (preg_match('#MULTIPOLYGON\\(\\(\\(([- 0-9.,]+)#',$aPointPolygon['outlinestring'],$aMatch))
+       if (PEAR::isError($aPointDetails['aExtraTags'])) // possible timeout

        {
        {

-               // TODO: this just takes the first ring
-               preg_match_all('/(-?[0-9.]+) (-?[0-9.]+)/',$aMatch[1],$aPolyPoints,PREG_SET_ORDER);
-       }
-       elseif (preg_match('#POINT\\((-?[0-9.]+) (-?[0-9.]+)\\)#',$aPointPolygon['outlinestring'],$aMatch))
-       {
-               $fRadius = 0.01;
-               if ($aPointDetails['rank_search'] > 20) $fRadius = 0.0001;
-               $iSteps = min(max(($fRadius * 40000)^2,16),100);
-               $fStepSize = (2*pi())/$iSteps;
-               $aPolyPoints = array();
-               for($f = 0; $f < 2*pi(); $f += $fStepSize)
-               {
-
-                       $aPolyPoints[] = array('',$aMatch[1]+($fRadius*sin($f)),$aMatch[2]+($fRadius*cos($f)));
-               }
-               $aPointPolygon['minlat'] = $aPointPolygon['minlat'] - $fRadius;
-               $aPointPolygon['maxlat'] = $aPointPolygon['maxlat'] + $fRadius;
-               $aPointPolygon['minlon'] = $aPointPolygon['minlon'] - $fRadius;
-               $aPointPolygon['maxlon'] = $aPointPolygon['maxlon'] + $fRadius;
+               $aPointDetails['aExtraTags'] = [];

        }
 
        // Address
        $aAddressLines = getAddressDetails($oDB, $sLanguagePrefArraySQL, $iPlaceID, $aPointDetails['country_code'], true);
 
        // Linked places
        }
 
        // Address
        $aAddressLines = getAddressDetails($oDB, $sLanguagePrefArraySQL, $iPlaceID, $aPointDetails['country_code'], true);
 
        // Linked places

-       $sSQL = "select placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea, st_distance(geometry, placegeometry) as distance, ";
+       $sSQL = "select placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea, ST_Distance_Spheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') as distance, ";

        $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) as localname, length(name::text) as namelength ";
        $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) as localname, length(name::text) as namelength ";

-       $sSQL .= " from placex, (select geometry as placegeometry from placex where place_id = $iPlaceID) as x";
+       $sSQL .= " from placex, (select centroid as placegeometry from placex where place_id = $iPlaceID) as x";

        $sSQL .= " where linked_place_id = $iPlaceID";
        $sSQL .= " order by rank_address asc,rank_search asc,get_name_by_language(name,$sLanguagePrefArraySQL),housenumber";
        $aLinkedLines = $oDB->getAll($sSQL);
        $sSQL .= " where linked_place_id = $iPlaceID";
        $sSQL .= " order by rank_address asc,rank_search asc,get_name_by_language(name,$sLanguagePrefArraySQL),housenumber";
        $aLinkedLines = $oDB->getAll($sSQL);

+       if (PEAR::isError($aLinkedLines)) // possible timeout
+       {
+               $aLinkedLines = [];
+       }

 
        // All places this is an imediate parent of
 
        // All places this is an imediate parent of

-       $sSQL = "select placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea, st_distance(geometry, placegeometry) as distance, ";
+       $sSQL = "select obj.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, ST_GeometryType(geometry) in ('ST_Polygon','ST_MultiPolygon') as isarea, ST_Distance_Spheroid(geometry, placegeometry, 'SPHEROID[\"WGS 84\",6378137,298.257223563, AUTHORITY[\"EPSG\",\"7030\"]]') as distance, ";

        $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) as localname, length(name::text) as namelength ";
        $sSQL .= " get_name_by_language(name,$sLanguagePrefArraySQL) as localname, length(name::text) as namelength ";

-       $sSQL .= " from placex, (select geometry as placegeometry from placex where place_id = $iPlaceID) as x";
-       $sSQL .= " where parent_place_id = $iPlaceID";
-       $sSQL .= " order by rank_address asc,rank_search asc,get_name_by_language(name,$sLanguagePrefArraySQL),housenumber";
+       $sSQL .= " from (select placex.place_id, osm_type, osm_id, class, type, housenumber, admin_level, rank_address, rank_search, geometry, name from placex ";
+       $sSQL .= " where parent_place_id = $iPlaceID order by rank_address asc,rank_search asc limit 500) as obj,";
+       $sSQL .= " (select centroid as placegeometry from placex where place_id = $iPlaceID) as x";
+       $sSQL .= " order by rank_address asc,rank_search asc,localname,housenumber";

        $aParentOfLines = $oDB->getAll($sSQL);
        $aParentOfLines = $oDB->getAll($sSQL);

+       if (PEAR::isError($aParentOfLines)) // possible timeout
+       {
+               $aParentOfLines = [];
+       }

 
        $aPlaceSearchNameKeywords = false;
        $aPlaceSearchAddressKeywords = false;
 
        $aPlaceSearchNameKeywords = false;
        $aPlaceSearchAddressKeywords = false;


@@ -131,12 +135,31 @@
        {
                $sSQL = "select * from search_name where place_id = $iPlaceID";
                $aPlaceSearchName = $oDB->getRow($sSQL);
        {
                $sSQL = "select * from search_name where place_id = $iPlaceID";
                $aPlaceSearchName = $oDB->getRow($sSQL);

+               if (PEAR::isError($aPlaceSearchName)) // possible timeout
+               {
+                       $aPlaceSearchName = [];
+               }
+

                $sSQL = "select * from word where word_id in (".substr($aPlaceSearchName['name_vector'],1,-1).")";
                $aPlaceSearchNameKeywords = $oDB->getAll($sSQL);
                $sSQL = "select * from word where word_id in (".substr($aPlaceSearchName['name_vector'],1,-1).")";
                $aPlaceSearchNameKeywords = $oDB->getAll($sSQL);

+               if (PEAR::isError($aPlaceSearchNameKeywords)) // possible timeout
+               {
+                       $aPlaceSearchNameKeywords = [];
+               }
+
+

                $sSQL = "select * from word where word_id in (".substr($aPlaceSearchName['nameaddress_vector'],1,-1).")";
                $aPlaceSearchAddressKeywords = $oDB->getAll($sSQL);
                $sSQL = "select * from word where word_id in (".substr($aPlaceSearchName['nameaddress_vector'],1,-1).")";
                $aPlaceSearchAddressKeywords = $oDB->getAll($sSQL);

+               if (PEAR::isError($aPlaceSearchAddressKeywords)) // possible timeout
+               {
+                       $aPlaceSearchAddressKeywords = [];
+               }
+

        }
 
        logEnd($oDB, $hLog, 1);
 
        }
 
        logEnd($oDB, $hLog, 1);
 

+       $sTileURL = CONST_Map_Tile_URL;
+       $sTileAttribution = CONST_Map_Tile_Attribution;
+       

        include(CONST_BasePath.'/lib/template/details-'.$sOutputFormat.'.php');
        include(CONST_BasePath.'/lib/template/details-'.$sOutputFormat.'.php');