Merge remote-tracking branch 'upstream/master'

[nominatim.git] / lib / ParameterParser.php

diff --git a/lib/ParameterParser.php b/lib/ParameterParser.php
index 5177a08e81eea3194a8e0eaedb15127e9db1c47b..26b648bb2865165d8b9ee897263b2ebed17016f1 100644 (file)
--- a/lib/ParameterParser.php
+++ b/lib/ParameterParser.php
@@ -23,7 +23,7 @@ class ParameterParser
 
     public function getInt($sName, $bDefault = false)
     {
 
     public function getInt($sName, $bDefault = false)
     {

-        if (!isset($this->aParams[$sName]) || strlen($this->aParams[$sName]) == 0) {
+        if (!isset($this->aParams[$sName])) {

             return $bDefault;
         }
 
             return $bDefault;
         }
 


@@ -36,7 +36,7 @@ class ParameterParser
 
     public function getFloat($sName, $bDefault = false)
     {
 
     public function getFloat($sName, $bDefault = false)
     {

-        if (!isset($this->aParams[$sName]) || strlen($this->aParams[$sName]) == 0) {
+        if (!isset($this->aParams[$sName])) {

             return $bDefault;
         }
 
             return $bDefault;
         }
 


@@ -74,7 +74,8 @@ class ParameterParser
         $sValue = $this->getString($sName);
 
         if ($sValue) {
         $sValue = $this->getString($sName);
 
         if ($sValue) {

-            return explode(',', $sValue);
+            // removes all NULL, FALSE and Empty Strings but leaves 0 (zero) values
+            return array_values(array_filter(explode(',', $sValue), 'strlen'));

         }
 
         return $aDefault;
         }
 
         return $aDefault;


@@ -82,8 +83,8 @@ class ParameterParser
 
     public function getPreferredLanguages($sFallback = null)
     {
 
     public function getPreferredLanguages($sFallback = null)
     {

-        if ($sFallback === null && isset($_SERVER["HTTP_ACCEPT_LANGUAGE"])) {
-            $sFallback = $_SERVER["HTTP_ACCEPT_LANGUAGE"];
+        if ($sFallback === null && isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
+            $sFallback = $_SERVER['HTTP_ACCEPT_LANGUAGE'];

         }
 
         $aLanguages = array();
         }
 
         $aLanguages = array();


@@ -98,7 +99,7 @@ class ParameterParser
                 arsort($aLanguages);
             }
         }
                 arsort($aLanguages);
             }
         }

-        if (!sizeof($aLanguages) && CONST_Default_Language) {
+        if (empty($aLanguages) && CONST_Default_Language) {

             $aLanguages[CONST_Default_Language] = 1;
         }
 
             $aLanguages[CONST_Default_Language] = 1;
         }