add types-requests dependency

[nominatim.git] / .github / workflows / ci-tests.yml

diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
index 6ebf1ab97d154c7d5841d77f35e2cbdf3a1d8d56..cdc7ea1e3ec60ed41c04ce4c355e7869c3f03282 100644 (file)
--- a/.github/workflows/ci-tests.yml
+++ b/.github/workflows/ci-tests.yml
@@ -7,11 +7,11 @@ jobs:
         runs-on: ubuntu-latest
 
         steps:
         runs-on: ubuntu-latest
 
         steps:

-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v3

               with:
                 submodules: true
 
               with:
                 submodules: true
 

-            - uses: actions/cache@v2
+            - uses: actions/cache@v3

               with:
                   path: |
                      data/country_osm_grid.sql.gz
               with:
                   path: |
                      data/country_osm_grid.sql.gz


@@ -27,7 +27,7 @@ jobs:
                   mv nominatim-src.tar.bz2 Nominatim
 
             - name: 'Upload Artifact'
                   mv nominatim-src.tar.bz2 Nominatim
 
             - name: 'Upload Artifact'

-              uses: actions/upload-artifact@v2
+              uses: actions/upload-artifact@v3

               with:
                   name: full-source
                   path: nominatim-src.tar.bz2
               with:
                   name: full-source
                   path: nominatim-src.tar.bz2


@@ -37,7 +37,7 @@ jobs:
         needs: create-archive
         strategy:
             matrix:
         needs: create-archive
         strategy:
             matrix:

-                ubuntu: [18, 20]
+                ubuntu: [18, 20, 22]

                 include:
                     - ubuntu: 18
                       postgresql: 9.6
                 include:
                     - ubuntu: 18
                       postgresql: 9.6


@@ -49,11 +49,16 @@ jobs:
                       postgis: 3
                       pytest: py.test-3
                       php: 7.4
                       postgis: 3
                       pytest: py.test-3
                       php: 7.4

+                    - ubuntu: 22
+                      postgresql: 15
+                      postgis: 3
+                      pytest: py.test-3
+                      php: 8.1

 
         runs-on: ubuntu-${{ matrix.ubuntu }}.04
 
         steps:
 
         runs-on: ubuntu-${{ matrix.ubuntu }}.04
 
         steps:

-            - uses: actions/download-artifact@v2
+            - uses: actions/download-artifact@v3

               with:
                   name: full-source
 
               with:
                   name: full-source
 


@@ -65,8 +70,9 @@ jobs:
               with:
                   php-version: ${{ matrix.php }}
                   tools: phpunit, phpcs, composer
               with:
                   php-version: ${{ matrix.php }}
                   tools: phpunit, phpcs, composer

+                  ini-values: opcache.jit=disable

 
 

-            - uses: actions/setup-python@v2
+            - uses: actions/setup-python@v4

               with:
                 python-version: 3.6
               if: matrix.ubuntu == 18
               with:
                 python-version: 3.6
               if: matrix.ubuntu == 18


@@ -81,12 +87,19 @@ jobs:
                   ubuntu: ${{ matrix.ubuntu }}
 
             - name: Install test prerequsites
                   ubuntu: ${{ matrix.ubuntu }}
 
             - name: Install test prerequsites

-              run: sudo apt-get install -y -qq pylint python3-pytest python3-behave
+              run: sudo apt-get install -y -qq python3-pytest python3-behave

               if: matrix.ubuntu == 20
 
             - name: Install test prerequsites
               if: matrix.ubuntu == 20
 
             - name: Install test prerequsites

-              run: pip3 install pylint==2.6.0 pytest behave==1.2.6
-              if: matrix.ubuntu == 18
+              run: pip3 install pylint pytest behave==1.2.6
+              if: ${{ (matrix.ubuntu == 18) || (matrix.ubuntu == 22) }}
+
+            - name: Install test prerequsites
+              run: sudo apt-get install -y -qq python3-pytest
+              if: matrix.ubuntu == 22
+
+            - name: Install latest pylint/mypy
+              run: pip3 install -U pylint mypy types-PyYAML types-jinja2 types-psycopg2 types-psutil types-requests typing-extensions

 
             - name: PHP linting
               run: phpcs --report-width=120 .
 
             - name: PHP linting
               run: phpcs --report-width=120 .


@@ -96,10 +109,15 @@ jobs:
               run: pylint nominatim
               working-directory: Nominatim
 
               run: pylint nominatim
               working-directory: Nominatim
 

+            - name: Python static typechecking
+              run: mypy --strict nominatim
+              working-directory: Nominatim
+
+

             - name: PHP unit tests
               run: phpunit ./
               working-directory: Nominatim/test/php
             - name: PHP unit tests
               run: phpunit ./
               working-directory: Nominatim/test/php

-              if: matrix.ubuntu == 20
+              if: ${{ (matrix.ubuntu == 20) || (matrix.ubuntu == 22) }}

 
             - name: Python unit tests
               run: $PYTEST test/python
 
             - name: Python unit tests
               run: $PYTEST test/python


@@ -113,22 +131,12 @@ jobs:
               working-directory: Nominatim/test/bdd
 
 
               working-directory: Nominatim/test/bdd
 
 

-    icu-test:
+    legacy-test:

         needs: create-archive
         needs: create-archive

-        strategy:
-            matrix:
-                ubuntu: [20]
-                include:
-                    - ubuntu: 20
-                      postgresql: 13
-                      postgis: 3
-                      pytest: py.test-3
-                      php: 7.4
-
-        runs-on: ubuntu-${{ matrix.ubuntu }}.04
+        runs-on: ubuntu-20.04

 
         steps:
 
         steps:

-            - uses: actions/download-artifact@v2
+            - uses: actions/download-artifact@v3

               with:
                   name: full-source
 
               with:
                   name: full-source
 


@@ -138,35 +146,27 @@ jobs:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
               with:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
               with:

-                  php-version: ${{ matrix.php }}
-                  coverage: xdebug
-                  tools: phpunit, phpcs, composer
-
-            - uses: actions/setup-python@v2
-              with:
-                python-version: 3.6
-              if: matrix.ubuntu == 18
+                  php-version: 7.4

 
             - uses: ./Nominatim/.github/actions/setup-postgresql
               with:
 
             - uses: ./Nominatim/.github/actions/setup-postgresql
               with:

-                  postgresql-version: ${{ matrix.postgresql }}
-                  postgis-version: ${{ matrix.postgis }}
+                  postgresql-version: 13
+                  postgis-version: 3
+
+            - name: Install Postgresql server dev
+              run: sudo apt-get install postgresql-server-dev-13

 
             - uses: ./Nominatim/.github/actions/build-nominatim
               with:
 
             - uses: ./Nominatim/.github/actions/build-nominatim
               with:

-                  ubuntu: ${{ matrix.ubuntu }}
+                  ubuntu: 20
+                  cmake-args: -DBUILD_MODULE=on

 
             - name: Install test prerequsites
               run: sudo apt-get install -y -qq python3-behave
 
             - name: Install test prerequsites
               run: sudo apt-get install -y -qq python3-behave

-              if: matrix.ubuntu == 20

 
 

-            - name: Install test prerequsites
-              run: pip3 install behave==1.2.6
-              if: matrix.ubuntu == 18
-
-            - name: BDD tests (icu tokenizer)
+            - name: BDD tests (legacy tokenizer)

               run: |
               run: |

-                  behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DTOKENIZER=icu --format=progress3
+                  behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DTOKENIZER=legacy --format=progress3

               working-directory: Nominatim/test/bdd
 
 
               working-directory: Nominatim/test/bdd
 
 


@@ -176,7 +176,7 @@ jobs:
 
         strategy:
             matrix:
 
         strategy:
             matrix:

-                name: [Ubuntu-18, Ubuntu-20]
+                name: [Ubuntu-18, Ubuntu-20, Ubuntu-22]

                 include:
                     - name: Ubuntu-18
                       flavour: ubuntu
                 include:
                     - name: Ubuntu-18
                       flavour: ubuntu


@@ -188,6 +188,11 @@ jobs:
                       image: "ubuntu:20.04"
                       ubuntu: 20
                       install_mode: install-apache
                       image: "ubuntu:20.04"
                       ubuntu: 20
                       install_mode: install-apache

+                    - name: Ubuntu-22
+                      flavour: ubuntu
+                      image: "ubuntu:22.04"
+                      ubuntu: 22
+                      install_mode: install-apache

 
         container:
             image: ${{ matrix.image }}
 
         container:
             image: ${{ matrix.image }}


@@ -226,7 +231,7 @@ jobs:
                 OS: ${{ matrix.name }}
                 INSTALL_MODE: ${{ matrix.install_mode }}
 
                 OS: ${{ matrix.name }}
                 INSTALL_MODE: ${{ matrix.install_mode }}
 

-            - uses: actions/download-artifact@v2
+            - uses: actions/download-artifact@v3

               with:
                   name: full-source
                   path: /home/nominatim
               with:
                   name: full-source
                   path: /home/nominatim


@@ -260,6 +265,10 @@ jobs:
               run: nominatim --version
               working-directory: /home/nominatim/nominatim-project
 
               run: nominatim --version
               working-directory: /home/nominatim/nominatim-project
 

+            - name: Collect host OS information
+              run: nominatim admin --collect-os-info
+              working-directory: /home/nominatim/nominatim-project
+              

             - name: Import
               run: nominatim import --osm-file ../test.pbf
               working-directory: /home/nominatim/nominatim-project
             - name: Import
               run: nominatim import --osm-file ../test.pbf
               working-directory: /home/nominatim/nominatim-project