fix various failing BDD tests

[nominatim.git] / lib-php / TokenSpecialTerm.php

diff --git a/lib-php/TokenSpecialTerm.php b/lib-php/TokenSpecialTerm.php
index 5b2d4c70a64f75de8971da78500bc2b8ad65e331..475ae71ba184349242d20143a67538186a0535a6 100644 (file)
--- a/lib-php/TokenSpecialTerm.php
+++ b/lib-php/TokenSpecialTerm.php
@@ -1,4 +1,12 @@
 <?php
 <?php

+/**
+ * SPDX-License-Identifier: GPL-2.0-only
+ *
+ * This file is part of Nominatim. (https://nominatim.org)
+ *
+ * Copyright (C) 2022 by the Nominatim developer community.
+ * For a full list of authors see the git log.
+ */

 
 namespace Nominatim\Token;
 
 
 namespace Nominatim\Token;
 


@@ -44,7 +52,10 @@ class SpecialTerm
      */
     public function isExtendable($oSearch, $oPosition)
     {
      */
     public function isExtendable($oSearch, $oPosition)
     {

-        return !$oSearch->hasOperator() && $oPosition->isPhrase('');
+        return !$oSearch->hasOperator()
+               && $oPosition->isPhrase('')
+               && ($this->iOperator != \Nominatim\Operator::NONE
+                  || (!$oSearch->hasAddress() && !$oSearch->hasHousenumber() && !$oSearch->hasCountry()));

     }
 
     /**
     }
 
     /**


@@ -58,19 +69,31 @@ class SpecialTerm
      */
     public function extendSearch($oSearch, $oPosition)
     {
      */
     public function extendSearch($oSearch, $oPosition)
     {

-        $iSearchCost = 2;
+        $iSearchCost = 0;

 
         $iOp = $this->iOperator;
         if ($iOp == \Nominatim\Operator::NONE) {
 
         $iOp = $this->iOperator;
         if ($iOp == \Nominatim\Operator::NONE) {

-            if ($oSearch->hasName() || $oSearch->getContext()->isBoundedSearch()) {
+            if ($oPosition->isFirstToken()
+                || $oSearch->hasName()
+                || $oSearch->getContext()->isBoundedSearch()
+            ) {

                 $iOp = \Nominatim\Operator::NAME;
                 $iOp = \Nominatim\Operator::NAME;

+                $iSearchCost += 3;

             } else {
                 $iOp = \Nominatim\Operator::NEAR;
             } else {
                 $iOp = \Nominatim\Operator::NEAR;

+                $iSearchCost += 4;
+                if (!$oPosition->isFirstToken()) {
+                    $iSearchCost += 3;
+                }

             }
             }

+        } elseif ($oPosition->isFirstToken()) {

             $iSearchCost += 2;
             $iSearchCost += 2;

-        } elseif (!$oPosition->isFirstToken() && !$oPosition->isLastToken()) {
-            $iSearchCost += 2;
+        } elseif ($oPosition->isLastToken()) {
+            $iSearchCost += 4;
+        } else {
+            $iSearchCost += 6;

         }
         }

+

         if ($oSearch->hasHousenumber()) {
             $iSearchCost ++;
         }
         if ($oSearch->hasHousenumber()) {
             $iSearchCost ++;
         }