X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/317cc5c5443ef0a46b70be589fba2737d0685948..6c4c9ec1f2fb2ae2026f3cd59c505dd33c4ebe3e:/nominatim/api/types.py diff --git a/nominatim/api/types.py b/nominatim/api/types.py index c7e15843..7cb7b133 100644 --- a/nominatim/api/types.py +++ b/nominatim/api/types.py @@ -14,9 +14,9 @@ import dataclasses import enum import math from struct import unpack +from binascii import unhexlify -from geoalchemy2 import WKTElement -import geoalchemy2.functions +import sqlalchemy as sa from nominatim.errors import UsageError @@ -73,9 +73,11 @@ class Point(NamedTuple): @staticmethod - def from_wkb(wkb: bytes) -> 'Point': + def from_wkb(wkb: Union[str, bytes]) -> 'Point': """ Create a point from EWKB as returned from the database. """ + if isinstance(wkb, str): + wkb = unhexlify(wkb) if len(wkb) != 25: raise ValueError("Point wkb has unexpected length") if wkb[0] == 0: @@ -122,10 +124,10 @@ class Point(NamedTuple): return Point(x, y) - def sql_value(self) -> WKTElement: + def sql_value(self) -> str: """ Create an SQL expression for the point. """ - return WKTElement(f'POINT({self.x} {self.y})', srid=4326) + return f'POINT({self.x} {self.y})' @@ -182,7 +184,7 @@ class Bbox: def sql_value(self) -> Any: """ Create an SQL expression for the box. """ - return geoalchemy2.functions.ST_MakeEnvelope(*self.coords, 4326) + return sa.func.ST_MakeEnvelope(*self.coords, 4326) def contains(self, pt: Point) -> bool: @@ -193,13 +195,16 @@ class Bbox: @staticmethod - def from_wkb(wkb: Optional[bytes]) -> 'Optional[Bbox]': + def from_wkb(wkb: Union[None, str, bytes]) -> 'Optional[Bbox]': """ Create a Bbox from a bounding box polygon as returned by the database. Return s None if the input value is None. """ if wkb is None: return None + if isinstance(wkb, str): + wkb = unhexlify(wkb) + if len(wkb) != 97: raise ValueError("WKB must be a bounding box polygon") if wkb.startswith(WKB_BBOX_HEADER_LE): @@ -302,10 +307,11 @@ def format_excluded(ids: Any) -> List[int]: else: raise UsageError("Parameter 'excluded' needs to be a comma-separated list " "or a Python list of numbers.") - if not all(isinstance(i, int) or (isinstance(i, str) and i.isdigit()) for i in plist): + if not all(isinstance(i, int) or + (isinstance(i, str) and (not i or i.isdigit())) for i in plist): raise UsageError("Parameter 'excluded' only takes place IDs.") - return [int(id) for id in plist if id] + return [int(id) for id in plist if id] or [0] def format_categories(categories: List[Tuple[str, str]]) -> List[Tuple[str, str]]: