X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/3eb4d8805700ba12bd601e552c3bc48064423083..893490f94e19d113e46b89b3ae62492d40db4a7a:/test/python/test_tokenizer_legacy.py diff --git a/test/python/test_tokenizer_legacy.py b/test/python/test_tokenizer_legacy.py index 45c400fe..58bf5a5e 100644 --- a/test/python/test_tokenizer_legacy.py +++ b/test/python/test_tokenizer_legacy.py @@ -69,6 +69,38 @@ def analyzer(tokenizer_factory, test_config, monkeypatch, sql_preprocessor, yield analyzer +@pytest.fixture +def make_standard_name(temp_db_cursor): + temp_db_cursor.execute("""CREATE OR REPLACE FUNCTION make_standard_name(name TEXT) + RETURNS TEXT AS $$ SELECT ' ' || name; $$ LANGUAGE SQL""") + + +@pytest.fixture +def create_postcode_id(table_factory, temp_db_cursor): + table_factory('out_postcode_table', 'postcode TEXT') + + temp_db_cursor.execute("""CREATE OR REPLACE FUNCTION create_postcode_id(postcode TEXT) + RETURNS BOOLEAN AS $$ + INSERT INTO out_postcode_table VALUES (postcode) RETURNING True; + $$ LANGUAGE SQL""") + + +@pytest.fixture +def create_housenumbers(temp_db_cursor): + temp_db_cursor.execute("""CREATE OR REPLACE FUNCTION create_housenumbers( + housenumbers TEXT[], + OUT tokens TEXT, OUT normtext TEXT) + AS $$ + SELECT housenumbers::TEXT, array_to_string(housenumbers, ';') + $$ LANGUAGE SQL""") + + +@pytest.fixture +def make_keywords(temp_db_cursor, temp_db_with_extensions): + temp_db_cursor.execute( + """CREATE OR REPLACE FUNCTION make_keywords(names HSTORE) + RETURNS INTEGER[] AS $$ SELECT ARRAY[1, 2, 3] $$ LANGUAGE SQL""") + def test_init_new(tokenizer_factory, test_config, monkeypatch, temp_db_conn, sql_preprocessor): monkeypatch.setenv('NOMINATIM_TERM_NORMALIZATION', 'xxvv') @@ -157,3 +189,110 @@ def test_migrate_database(tokenizer_factory, test_config, temp_db_conn, monkeypa def test_normalize(analyzer): assert analyzer.normalize('TEsT') == 'test' + + +def test_add_postcodes_from_db(analyzer, table_factory, temp_db_cursor, + create_postcode_id): + table_factory('location_postcode', 'postcode TEXT', + content=(('1234',), ('12 34',), ('AB23',), ('1234',))) + + analyzer.add_postcodes_from_db() + + assert temp_db_cursor.row_set("SELECT * from out_postcode_table") \ + == set((('1234', ), ('12 34', ), ('AB23',))) + + +def test_update_special_phrase_empty_table(analyzer, word_table, temp_db_cursor, + make_standard_name): + analyzer.update_special_phrases([ + ("König bei", "amenity", "royal", "near"), + ("Könige", "amenity", "royal", "-"), + ("strasse", "highway", "primary", "in") + ]) + + assert temp_db_cursor.row_set("""SELECT word_token, word, class, type, operator + FROM word WHERE class != 'place'""") \ + == set(((' könig bei', 'könig bei', 'amenity', 'royal', 'near'), + (' könige', 'könige', 'amenity', 'royal', None), + (' strasse', 'strasse', 'highway', 'primary', 'in'))) + + +def test_update_special_phrase_delete_all(analyzer, word_table, temp_db_cursor, + make_standard_name): + temp_db_cursor.execute("""INSERT INTO word (word_token, word, class, type, operator) + VALUES (' foo', 'foo', 'amenity', 'prison', 'in'), + (' bar', 'bar', 'highway', 'road', null)""") + + assert 2 == temp_db_cursor.scalar("SELECT count(*) FROM word WHERE class != 'place'""") + + analyzer.update_special_phrases([]) + + assert 0 == temp_db_cursor.scalar("SELECT count(*) FROM word WHERE class != 'place'""") + + +def test_update_special_phrase_modify(analyzer, word_table, temp_db_cursor, + make_standard_name): + temp_db_cursor.execute("""INSERT INTO word (word_token, word, class, type, operator) + VALUES (' foo', 'foo', 'amenity', 'prison', 'in'), + (' bar', 'bar', 'highway', 'road', null)""") + + assert 2 == temp_db_cursor.scalar("SELECT count(*) FROM word WHERE class != 'place'""") + + analyzer.update_special_phrases([ + ('prison', 'amenity', 'prison', 'in'), + ('bar', 'highway', 'road', '-'), + ('garden', 'leisure', 'garden', 'near') + ]) + + assert temp_db_cursor.row_set("""SELECT word_token, word, class, type, operator + FROM word WHERE class != 'place'""") \ + == set(((' prison', 'prison', 'amenity', 'prison', 'in'), + (' bar', 'bar', 'highway', 'road', None), + (' garden', 'garden', 'leisure', 'garden', 'near'))) + + +def test_process_place_names(analyzer, make_keywords): + + info = analyzer.process_place({'name' : {'name' : 'Soft bAr', 'ref': '34'}}) + + assert info['names'] == '{1,2,3}' + + +@pytest.mark.parametrize('pc', ['12345', 'AB 123', '34-345']) +def test_process_place_postcode(analyzer, temp_db_cursor, create_postcode_id, pc): + + info = analyzer.process_place({'address': {'postcode' : pc}}) + + assert temp_db_cursor.row_set("SELECT * from out_postcode_table") \ + == set(((pc, ),)) + + +@pytest.mark.parametrize('pc', ['12:23', 'ab;cd;f', '123;836']) +def test_process_place_bad_postcode(analyzer, temp_db_cursor, create_postcode_id, + pc): + + info = analyzer.process_place({'address': {'postcode' : pc}}) + + assert 0 == temp_db_cursor.scalar("SELECT count(*) from out_postcode_table") + + +@pytest.mark.parametrize('hnr', ['123a', '1', '101']) +def test_process_place_housenumbers_simple(analyzer, create_housenumbers, hnr): + info = analyzer.process_place({'address': {'housenumber' : hnr}}) + + assert info['hnr'] == hnr + assert info['hnr_tokens'].startswith("{") + + +def test_process_place_housenumbers_lists(analyzer, create_housenumbers): + info = analyzer.process_place({'address': {'conscriptionnumber' : '1; 2;3'}}) + + assert set(info['hnr'].split(';')) == set(('1', '2', '3')) + + +def test_process_place_housenumbers_duplicates(analyzer, create_housenumbers): + info = analyzer.process_place({'address': {'housenumber' : '134', + 'conscriptionnumber' : '134', + 'streetnumber' : '99a'}}) + + assert set(info['hnr'].split(';')) == set(('134', '99a'))