X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/42631b85c7445b3acae9d907330fd2544f3366a1..7572c9e28a97e2cafa3dd747803f51337de0f69c:/nominatim/api/logging.py?ds=sidebyside diff --git a/nominatim/api/logging.py b/nominatim/api/logging.py index 202d7de9..5b6d0e4d 100644 --- a/nominatim/api/logging.py +++ b/nominatim/api/logging.py @@ -12,6 +12,7 @@ from contextvars import ContextVar import datetime as dt import textwrap import io +import re import sqlalchemy as sa from sqlalchemy.ext.asyncio import AsyncConnection @@ -80,7 +81,8 @@ class BaseLogger: """ def format_sql(self, conn: AsyncConnection, statement: 'sa.Executable', - extra_params: Union[Mapping[str, Any], Sequence[Mapping[str, Any]], None]) -> str: + extra_params: Union[Mapping[str, Any], + Sequence[Mapping[str, Any]], None]) -> str: """ Return the comiled version of the statement. """ compiled = cast('sa.ClauseElement', statement).compile(conn.sync_engine) @@ -95,14 +97,19 @@ class BaseLogger: sqlstr = str(compiled) - if '%s' in sqlstr: + if sa.__version__.startswith('1'): try: - return sqlstr % tuple((repr(compiled.params[name]) for name in compiled.positiontup)) + sqlstr = re.sub(r'__\[POSTCOMPILE_[^]]*\]', '%s', sqlstr) + return sqlstr % tuple((repr(params.get(name, None)) + for name in compiled.positiontup)) # type: ignore except TypeError: return sqlstr - return str(compiled) % params - + # Fixes an odd issue with Python 3.7 where percentages are not + # quoted correctly. + sqlstr = re.sub(r'%(?!\()', '%%', sqlstr) + sqlstr = re.sub(r'__\[POSTCOMPILE_([^]]*)\]', r'%(\1)s', sqlstr) + return sqlstr % params class HTMLLogger(BaseLogger): """ Logger that formats messages in HTML.