X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/815e3cccf6840d935e5a708588700cca23b976e9..7b0e0dfd883b268b58a721e2967303fa368e563f:/nominatim/db/utils.py?ds=sidebyside diff --git a/nominatim/db/utils.py b/nominatim/db/utils.py index b859afa8..d9154ed9 100644 --- a/nominatim/db/utils.py +++ b/nominatim/db/utils.py @@ -7,17 +7,21 @@ """ Helper functions for handling DB accesses. """ +from typing import IO, Optional, Union, Any, Iterable import subprocess import logging import gzip import io +from pathlib import Path -from nominatim.db.connection import get_pg_env +from nominatim.db.connection import get_pg_env, Cursor from nominatim.errors import UsageError LOG = logging.getLogger() -def _pipe_to_proc(proc, fdesc): +def _pipe_to_proc(proc: 'subprocess.Popen[bytes]', + fdesc: Union[IO[bytes], gzip.GzipFile]) -> int: + assert proc.stdin is not None chunk = fdesc.read(2048) while chunk and proc.poll() is None: try: @@ -28,7 +32,10 @@ def _pipe_to_proc(proc, fdesc): return len(chunk) -def execute_file(dsn, fname, ignore_errors=False, pre_code=None, post_code=None): +def execute_file(dsn: str, fname: Path, + ignore_errors: bool = False, + pre_code: Optional[str] = None, + post_code: Optional[str] = None) -> None: """ Read an SQL file and run its contents against the given database using psql. Use `pre_code` and `post_code` to run extra commands before or after executing the file. The commands are run within the @@ -42,6 +49,7 @@ def execute_file(dsn, fname, ignore_errors=False, pre_code=None, post_code=None) cmd.append('--quiet') with subprocess.Popen(cmd, env=get_pg_env(dsn), stdin=subprocess.PIPE) as proc: + assert proc.stdin is not None try: if not LOG.isEnabledFor(logging.INFO): proc.stdin.write('set client_min_messages to WARNING;'.encode('utf-8')) @@ -76,20 +84,20 @@ class CopyBuffer: """ Data collector for the copy_from command. """ - def __init__(self): + def __init__(self) -> None: self.buffer = io.StringIO() - def __enter__(self): + def __enter__(self) -> 'CopyBuffer': return self - def __exit__(self, exc_type, exc_value, traceback): + def __exit__(self, exc_type: Any, exc_value: Any, traceback: Any) -> None: if self.buffer is not None: self.buffer.close() - def add(self, *data): + def add(self, *data: Any) -> None: """ Add another row of data to the copy buffer. """ first = True @@ -105,9 +113,9 @@ class CopyBuffer: self.buffer.write('\n') - def copy_out(self, cur, table, columns=None): + def copy_out(self, cur: Cursor, table: str, columns: Optional[Iterable[str]] = None) -> None: """ Copy all collected data into the given table. """ if self.buffer.tell() > 0: self.buffer.seek(0) - cur.copy_from(self.buffer, table, columns=columns) + cur.copy_from(self.buffer, table, columns=columns) # type: ignore[arg-type]