X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/aa9fff919900caafb276630b8ca4f1c1c598ab1c..d45524cbfb299f5004a03c52802c64749c5ad212:/website/reverse.php

diff --git a/website/reverse.php b/website/reverse.php
index fd1f5c27..75eb2677 100755
--- a/website/reverse.php
+++ b/website/reverse.php
@@ -21,16 +21,12 @@
 
 
 	$bAsPoints = false;
-	$bAsGeoJSON = (boolean)isset($_GET['polygon_geojson']) && $_GET['polygon_geojson'];
-	$bAsKML = (boolean)isset($_GET['polygon_kml']) && $_GET['polygon_kml'];
-	$bAsSVG = (boolean)isset($_GET['polygon_svg']) && $_GET['polygon_svg'];
-	$bAsText = (boolean)isset($_GET['polygon_text']) && $_GET['polygon_text'];
-	if ( ( ($bAsGeoJSON?1:0)
-			 + ($bAsKML?1:0)
-			 + ($bAsSVG?1:0)
-			 + ($bAsText?1:0)
-			 + ($bAsPoints?1:0)
-			 ) > CONST_PolygonOutput_MaximumTypes)
+	$bAsGeoJSON = getParamBool('polygon_geojson');
+	$bAsKML = getParamBool('polygon_kml');
+	$bAsSVG = getParamBool('polygon_svg');
+	$bAsText = getParamBool('polygon_text');
+	if ((($bAsGeoJSON?1:0) + ($bAsKML?1:0) + ($bAsSVG?1:0)
+		+ ($bAsText?1:0) + ($bAsPoints?1:0)) > CONST_PolygonOutput_MaximumTypes)
 	{
 		if (CONST_PolygonOutput_MaximumTypes)
 		{
@@ -45,19 +41,14 @@
 
 
 	// Polygon simplification threshold (optional)
-	$fThreshold = 0.0;
-	if (isset($_GET['polygon_threshold'])) $fThreshold = (float)$_GET['polygon_threshold'];
+	$fThreshold = getParamFloat('polygon_threshold', 0.0);
 
 
 	$oDB =& getDB();
 	ini_set('memory_limit', '200M');
 
 	// Format for output
-	$sOutputFormat = 'xml';
-	if (isset($_GET['format']) && ( $_GET['format'] == 'html' || $_GET['format'] == 'xml' || $_GET['format'] == 'json' || $_GET['format'] == 'jsonv2'))
-	{
-		$sOutputFormat = $_GET['format'];
-	}
+	$sOutputFormat = getParamSet('format', array('html', 'xml', 'json', 'jsonv2'), 'xml');
 
 	// Preferred language
 	$aLangPrefOrder = getPreferredLanguages();
@@ -65,24 +56,28 @@
 	$hLog = logStart($oDB, 'reverse', $_SERVER['QUERY_STRING'], $aLangPrefOrder);
 
 
-	if (isset($_GET['osm_type']) && isset($_GET['osm_id']) && (int)$_GET['osm_id'] && ($_GET['osm_type'] == 'N' || $_GET['osm_type'] == 'W' || $_GET['osm_type'] == 'R'))
+	$sOsmType = getParamSet('osmtype', array('N', 'W', 'R'));
+	$iOsmId = getParamInt('osmid', -1);
+	$fLat = getParamFloat('lat');
+	$fLon = getParamFloat('lon');
+	if ($sOsmType && $iOsmId > 0)
 	{
-		$aLookup = array('osm_type' => $_GET['osm_type'], 'osm_id' => $_GET['osm_id']);
+		$aLookup = array('osm_type' => $sOsmType, 'osm_id' => $iOsmId);
 	}
-	else if (isset($_GET['lat']) && isset($_GET['lon']) && preg_match('/^[+-]?[0-9]*\.?[0-9]+$/', $_GET['lat']) && preg_match('/^[+-]?[0-9]*\.?[0-9]+$/', $_GET['lon']))
+	else if ($fLat !== false && $fLon !==false)
 	{
 		$oReverseGeocode = new ReverseGeocode($oDB);
 		$oReverseGeocode->setLanguagePreference($aLangPrefOrder);
 
-		$oReverseGeocode->setLatLon($_GET['lat'], $_GET['lon']);
-		$oReverseGeocode->setZoom(@$_GET['zoom']);
+		$oReverseGeocode->setLatLon($fLat, $fLon);
+		$oReverseGeocode->setZoom(getParamInt('zoom'));
 
 		$aLookup = $oReverseGeocode->lookup();
 		if (CONST_Debug) var_dump($aLookup);
 	}
 	else
 	{
-		$aLookup = null;
+		userError("Need coordinates or OSM object to lookup.");
 	}
 
 	if ($aLookup)