X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/b087f3ab7b59b5c7c3b1ad00996232c832b5d0ea..4cce681ead77ff2e5bdee2e7f1695162c805bbb5:/.github/workflows/ci-tests.yml?ds=sidebyside diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml index e3d7b4a6..8b38d3dc 100644 --- a/.github/workflows/ci-tests.yml +++ b/.github/workflows/ci-tests.yml @@ -11,7 +11,7 @@ jobs: with: submodules: true - - uses: actions/cache@v3 + - uses: actions/cache@v4 with: path: | data/country_osm_grid.sql.gz @@ -27,7 +27,7 @@ jobs: mv nominatim-src.tar.bz2 Nominatim - name: 'Upload Artifact' - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: full-source path: nominatim-src.tar.bz2 @@ -37,207 +37,106 @@ jobs: needs: create-archive strategy: matrix: - flavour: [oldstuff, "ubuntu-20", "ubuntu-22"] + flavour: ["ubuntu-20", "ubuntu-24"] include: - - flavour: oldstuff - ubuntu: 20 - postgresql: '9.6' - postgis: '2.5' - php: '7.3' - lua: '5.1' - flavour: ubuntu-20 ubuntu: 20 - postgresql: 13 - postgis: 3 - php: '7.4' - lua: '5.3' - - flavour: ubuntu-22 - ubuntu: 22 - postgresql: 15 - postgis: 3 - php: '8.1' + postgresql: 12 + lua: '5.1' + dependencies: pip + - flavour: ubuntu-24 + ubuntu: 24 + postgresql: 17 lua: '5.3' + dependencies: apt runs-on: ubuntu-${{ matrix.ubuntu }}.04 steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: full-source - name: Unpack Nominatim run: tar xf nominatim-src.tar.bz2 - - name: Setup PHP - uses: shivammathur/setup-php@v2 - with: - php-version: ${{ matrix.php }} - tools: phpunit:9, phpcs, composer - ini-values: opcache.jit=disable - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - - uses: actions/setup-python@v4 - with: - python-version: 3.7 - if: matrix.flavour == 'oldstuff' - - uses: ./Nominatim/.github/actions/setup-postgresql with: postgresql-version: ${{ matrix.postgresql }} - postgis-version: ${{ matrix.postgis }} - uses: ./Nominatim/.github/actions/build-nominatim with: - flavour: ${{ matrix.flavour }} - lua: ${{ matrix.lua }} - - - name: Install test prerequsites (behave from apt) - run: sudo apt-get install -y -qq python3-behave - if: matrix.flavour == 'ubuntu-20' - - - name: Install test prerequsites (behave from pip) - run: pip3 install behave==1.2.6 - if: (matrix.flavour == 'oldstuff') || (matrix.flavour == 'ubuntu-22') - - - name: Install test prerequsites (from apt for Ununtu 2x) - run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn - if: matrix.flavour != 'oldstuff' + dependencies: ${{ matrix.dependencies }} - - name: Install newer pytest-asyncio - run: pip3 install -U pytest-asyncio==0.21.1 - if: matrix.flavour == 'ubuntu-20' + - name: Compile osm2pgsql + run: | + sudo apt-get install -y -qq libboost-system-dev libboost-filesystem-dev libexpat1-dev zlib1g-dev libbz2-dev libpq-dev libproj-dev libicu-dev liblua${LUA_VERSION}-dev lua-dkjson nlohmann-json3-dev + mkdir osm2pgsql-build + cd osm2pgsql-build + git clone https://github.com/osm2pgsql-dev/osm2pgsql + mkdir build + cd build + cmake ../osm2pgsql + make + sudo make install + cd ../.. + rm -rf osm2pgsql-build + if: matrix.ubuntu == '20' + env: + LUA_VERSION: ${{ matrix.lua }} - - name: Install test prerequsites (from pip for Ubuntu 18) - run: pip3 install pytest pytest-asyncio uvicorn - if: matrix.flavour == 'oldstuff' + - name: Install test prerequisites + run: ./venv/bin/pip install behave==1.2.6 - - name: Install Python webservers - run: pip3 install falcon starlette asgi_lifespan + - name: Install test prerequisites (apt) + run: sudo apt-get install -y -qq python3-pytest python3-pytest-asyncio uvicorn python3-falcon python3-aiosqlite python3-pyosmium + if: matrix.dependencies == 'apt' - - name: Install latest pylint - run: pip3 install -U pylint - if: matrix.flavour != 'oldstuff' + - name: Install test prerequisites (pip) + run: ./venv/bin/pip install pytest-asyncio falcon starlette asgi_lifespan aiosqlite osmium uvicorn + if: matrix.dependencies == 'pip' - - name: PHP linting - run: phpcs --report-width=120 . - working-directory: Nominatim - if: matrix.flavour != 'oldstuff' + - name: Install latest flake8 + run: ./venv/bin/pip install -U flake8 - name: Python linting - run: python3 -m pylint nominatim - working-directory: Nominatim - if: matrix.flavour != 'oldstuff' - - - name: PHP unit tests - run: phpunit ./ - working-directory: Nominatim/test/php - - - name: Python unit tests - run: python3 -m pytest test/python + run: ../venv/bin/python -m flake8 src working-directory: Nominatim - - name: BDD tests - run: | - python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build --format=progress3 - working-directory: Nominatim/test/bdd - - name: Install mypy and typechecking info - run: pip3 install -U mypy osmium uvicorn types-PyYAML types-jinja2 types-psycopg2 types-psutil types-requests types-ujson types-Pygments typing-extensions - if: matrix.flavour != 'oldstuff' + run: ./venv/bin/pip install -U mypy types-PyYAML types-jinja2 types-psutil types-requests types-ujson types-Pygments typing-extensions + if: matrix.dependencies == 'pip' - name: Python static typechecking - run: python3 -m mypy --strict nominatim + run: ../venv/bin/python -m mypy --strict --python-version 3.8 src working-directory: Nominatim - if: matrix.flavour != 'oldstuff' - - legacy-test: - needs: create-archive - runs-on: ubuntu-20.04 + if: matrix.dependencies == 'pip' - steps: - - uses: actions/download-artifact@v3 - with: - name: full-source - - - name: Unpack Nominatim - run: tar xf nominatim-src.tar.bz2 - - - name: Setup PHP - uses: shivammathur/setup-php@v2 - with: - php-version: '7.4' - - - uses: ./Nominatim/.github/actions/setup-postgresql - with: - postgresql-version: 13 - postgis-version: 3 - - - name: Install Postgresql server dev - run: sudo apt-get install postgresql-server-dev-13 - - - uses: ./Nominatim/.github/actions/build-nominatim - with: - cmake-args: -DBUILD_MODULE=on - - - name: Install test prerequsites - run: sudo apt-get install -y -qq python3-behave - - - name: BDD tests (legacy tokenizer) - run: | - python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DTOKENIZER=legacy --format=progress3 - working-directory: Nominatim/test/bdd - - - python-api-test: - needs: create-archive - runs-on: ubuntu-22.04 - - steps: - - uses: actions/download-artifact@v3 - with: - name: full-source - - - name: Unpack Nominatim - run: tar xf nominatim-src.tar.bz2 - - - uses: ./Nominatim/.github/actions/setup-postgresql - with: - postgresql-version: 15 - postgis-version: 3 - - - uses: ./Nominatim/.github/actions/build-nominatim - with: - flavour: 'ubuntu-22' - - - name: Install test prerequsites - run: sudo apt-get install -y -qq python3-behave - - - name: Install Python webservers - run: pip3 install starlette asgi_lifespan httpx + - name: Python unit tests + run: ../venv/bin/python -m pytest test/python + working-directory: Nominatim - - name: BDD tests (starlette) + - name: BDD tests run: | - python3 -m behave -DREMOVE_TEMPLATE=1 -DBUILDDIR=$GITHUB_WORKSPACE/build -DAPI_ENGINE=starlette --format=progress3 + ../../../venv/bin/python -m behave -DREMOVE_TEMPLATE=1 --format=progress3 working-directory: Nominatim/test/bdd - install: runs-on: ubuntu-latest needs: create-archive strategy: matrix: - name: [Ubuntu-20, Ubuntu-22] + name: [Ubuntu-22, Ubuntu-24] include: - - name: Ubuntu-20 - image: "ubuntu:20.04" - ubuntu: 20 - install_mode: install-apache - name: Ubuntu-22 image: "ubuntu:22.04" ubuntu: 22 install_mode: install-apache + - name: Ubuntu-24 + image: "ubuntu:24.04" + ubuntu: 24 + install_mode: install-apache container: image: ${{ matrix.image }} @@ -268,7 +167,7 @@ jobs: OS: ${{ matrix.name }} INSTALL_MODE: ${{ matrix.install_mode }} - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: full-source path: /home/nominatim @@ -293,6 +192,14 @@ jobs: mkdir data-env-reverse working-directory: /home/nominatim + - name: Add nominatim to path + run: | + sudo ln -s /home/nominatim/nominatim-venv/bin/nominatim /usr/local/bin/nominatim + + - name: Need lua binary + run: | + sudo apt-get install -y lua5.4 lua-dkjson + - name: Print version run: nominatim --version working-directory: /home/nominatim/nominatim-project @@ -321,13 +228,12 @@ jobs: run: nominatim admin --warm working-directory: /home/nominatim/nominatim-project - - name: Prepare update (Ubuntu) - run: apt-get install -y python3-pip - shell: bash + - name: Install osmium + run: | + /home/nominatim/nominatim-venv/bin/pip install osmium - name: Run update run: | - pip3 install --user osmium nominatim replication --init NOMINATIM_REPLICATION_MAX_DIFF=1 nominatim replication --once working-directory: /home/nominatim/nominatim-project @@ -351,11 +257,11 @@ jobs: working-directory: /home/nominatim/nominatim-project install-no-superuser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: create-archive steps: - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: name: full-source @@ -365,12 +271,8 @@ jobs: - uses: ./Nominatim/.github/actions/setup-postgresql with: postgresql-version: 16 - postgis-version: 3 - uses: ./Nominatim/.github/actions/build-nominatim - with: - flavour: ubuntu-22 - lua: 5.3 - name: Prepare import environment run: | @@ -379,7 +281,7 @@ jobs: - name: Prepare Database run: | - nominatim import --prepare-database + ./venv/bin/nominatim import --prepare-database - name: Create import user run: | @@ -389,8 +291,55 @@ jobs: - name: Run import run: | - NOMINATIM_DATABASE_DSN="pgsql:host=127.0.0.1;dbname=nominatim;user=osm-import;password=osm-import" nominatim import --continue import-from-file --osm-file test.pbf + NOMINATIM_DATABASE_DSN="pgsql:host=127.0.0.1;dbname=nominatim;user=osm-import;password=osm-import" ./venv/bin/nominatim import --continue import-from-file --osm-file test.pbf - name: Check full import + run: ./venv/bin/nominatim admin --check-database + + migrate: + runs-on: ubuntu-24.04 + needs: create-archive + + steps: + - uses: actions/download-artifact@v4 + with: + name: full-source + + - name: Unpack Nominatim + run: tar xf nominatim-src.tar.bz2 + + - uses: ./Nominatim/.github/actions/setup-postgresql + with: + postgresql-version: 17 + + - name: Install Python dependencies run: | - nominatim admin --check-database + sudo apt-get install --no-install-recommends virtualenv osm2pgsql + + - name: Install Nominatim master version + run: | + virtualenv master + cd Nominatim + ../master/bin/pip install packaging/nominatim-db + + - name: Install Nominatim from pypi + run: | + virtualenv release + ./release/bin/pip install nominatim-db + + - name: Import Nominatim database using release + run: | + ./release/bin/nominatim import --osm-file Nominatim/test/testdb/apidb-test-data.pbf + ./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm + + - name: Migrate to master version + run: | + ./master/bin/nominatim admin --migrate + ./release/bin/nominatim add-data --file Nominatim/test/testdb/additional_api_test.data.osm + + codespell: + runs-on: ubuntu-latest + steps: + - uses: codespell-project/actions-codespell@v2 + with: + only_warn: 1