X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/c3788d765ed4e7ddf00794085af757714bc102cf..771be0e056047d3f5d0c878c77f20d14e0443d56:/test/python/cli/test_cli.py?ds=inline diff --git a/test/python/cli/test_cli.py b/test/python/cli/test_cli.py index 7743d601..d0e3307e 100644 --- a/test/python/cli/test_cli.py +++ b/test/python/cli/test_cli.py @@ -11,6 +11,7 @@ These tests just check that the various command line parameters route to the correct functionionality. They use a lot of monkeypatching to avoid executing the actual functions. """ +import importlib import pytest import nominatim.indexer.indexer @@ -26,6 +27,13 @@ def test_cli_help(cli_call, capsys): captured = capsys.readouterr() assert captured.out.startswith('usage:') +def test_cli_version(cli_call, capsys): + """ Running nominatim tool --version prints a version string. + """ + assert cli_call('--version') == 0 + + captured = capsys.readouterr() + assert captured.out.startswith('Nominatim version') @pytest.mark.parametrize("name,oid", [('file', 'foo.osm'), ('diff', 'foo.osc')]) def test_cli_add_data_file_command(cli_call, mock_func_factory, name, oid): @@ -52,7 +60,7 @@ def test_cli_add_data_tiger_data(cli_call, cli_tokenizer_mock, mock_func_factory assert mock.called == 1 -def test_cli_serve_command(cli_call, mock_func_factory): +def test_cli_serve_php(cli_call, mock_func_factory): func = mock_func_factory(nominatim.cli, 'run_php_server') cli_call('serve') == 0 @@ -60,6 +68,47 @@ def test_cli_serve_command(cli_call, mock_func_factory): assert func.called == 1 +def test_cli_serve_sanic(cli_call, mock_func_factory): + mod = pytest.importorskip("sanic") + func = mock_func_factory(mod.Sanic, "run") + + cli_call('serve', '--engine', 'sanic') == 0 + + assert func.called == 1 + + +def test_cli_serve_starlette_custom_server(cli_call, mock_func_factory): + pytest.importorskip("starlette") + mod = pytest.importorskip("uvicorn") + func = mock_func_factory(mod, "run") + + cli_call('serve', '--engine', 'starlette', '--server', 'foobar:4545') == 0 + + assert func.called == 1 + assert func.last_kwargs['host'] == 'foobar' + assert func.last_kwargs['port'] == 4545 + + +def test_cli_serve_starlette_custom_server_bad_port(cli_call, mock_func_factory): + pytest.importorskip("starlette") + mod = pytest.importorskip("uvicorn") + func = mock_func_factory(mod, "run") + + cli_call('serve', '--engine', 'starlette', '--server', 'foobar:45:45') == 1 + + +@pytest.mark.parametrize("engine", ['falcon', 'starlette']) +def test_cli_serve_uvicorn_based(cli_call, engine, mock_func_factory): + pytest.importorskip(engine) + mod = pytest.importorskip("uvicorn") + func = mock_func_factory(mod, "run") + + cli_call('serve', '--engine', engine) == 0 + + assert func.called == 1 + assert func.last_kwargs['host'] == '127.0.0.1' + assert func.last_kwargs['port'] == 8088 + def test_cli_export_command(cli_call, mock_run_legacy): assert cli_call('export', '--output-all-postcodes') == 0 @@ -75,19 +124,17 @@ def test_cli_export_command(cli_call, mock_run_legacy): ('restrict-to-osm-way', '727'), ('restrict-to-osm-relation', '197532') ]) -def test_export_parameters(src_dir, tmp_path, param, value): +def test_export_parameters(src_dir, tmp_path, param, value, monkeypatch): (tmp_path / 'admin').mkdir() (tmp_path / 'admin' / 'export.php').write_text(f"""= 0 ? 0 : 10); """) + monkeypatch.setattr(nominatim.paths, 'PHPLIB_DIR', tmp_path) + assert nominatim.cli.nominatim(module_dir='MODULE NOT AVAILABLE', osm2pgsql_path='OSM2PGSQL NOT AVAILABLE', - phplib_dir=str(tmp_path), - data_dir=str(src_dir / 'data'), phpcgi_path='/usr/bin/php-cgi', - sqllib_dir=str(src_dir / 'lib-sql'), - config_dir=str(src_dir / 'settings'), cli_args=['export', '--' + param, value]) == 0