X-Git-Url: https://git.openstreetmap.org./nominatim.git/blobdiff_plain/e94b667e16177916dc34d790df475a69fe01a7d9..7879ad44cd1e36ae1235c3dcdfd9e477491813e4:/lib/Geocode.php

diff --git a/lib/Geocode.php b/lib/Geocode.php
index 8eaa5402..620e0e50 100644
--- a/lib/Geocode.php
+++ b/lib/Geocode.php
@@ -399,7 +399,7 @@
 			$sLanguagePrefArraySQL = "ARRAY[".join(',',array_map("getDBQuoted",$this->aLangPrefOrder))."]";
 
 			// Get the details for display (is this a redundant extra step?)
-			$sPlaceIDs = join(',',array_keys($aPlaceIDs));
+			$sPlaceIDs = join(',', array_keys($aPlaceIDs));
 
 			$sImportanceSQL = '';
 			if ($this->sViewboxSmallSQL) $sImportanceSQL .= " case when ST_Contains($this->sViewboxSmallSQL, ST_Collect(centroid)) THEN 1 ELSE 0.75 END * ";
@@ -433,39 +433,66 @@
 
 			if (30 >= $this->iMinAddressRank && 30 <= $this->iMaxAddressRank)
 			{
-				//query also location_property_tiger and location_property_aux
+				//query also location_property_osmline and location_property_tiger and location_property_aux
 				//Tiger search only if a housenumber was searched and if it was found (i.e. aPlaceIDs[placeID] = housenumber != -1) (realized through a join)
 				//only Tiger housenumbers need to be interpolated, because they are saved as lines with start- and endnumber, the common osm housenumbers are usually saved as points
 				$sHousenumbers = "";
-				$i=0;
-				$length=count($aPlaceIDs);
-				foreach($aPlaceIDs as $placeID => $housenumber){
+				$i = 0;
+				$length = count($aPlaceIDs);
+				foreach($aPlaceIDs as $placeID => $housenumber)
+				{
 					$i++;
 					$sHousenumbers .= "(".$placeID.", ".$housenumber.")";
 					if($i<$length)
 						$sHousenumbers .= ", ";
 				}
+				// osmline, osm_type is 'I' for Interpolation Line
+				$sSQL .= " union ";
+				$sSQL .= "select 'I' as osm_type, place_id as osm_id, 'place' as class, 'house' as type, null as admin_level, 30 as rank_search, 30 as rank_address, min(place_id) as place_id, min(parent_place_id) as parent_place_id, calculated_country_code as country_code, ";
+				$sSQL .= "get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) as langaddress, ";
+				$sSQL .= "null as placename, ";
+				$sSQL .= "null as ref, ";
+				if ($this->bIncludeExtraTags) $sSQL .= "null as extra, ";
+				if ($this->bIncludeNameDetails) $sSQL .= "null as names, ";
+				$sSQL .= " avg(st_x(centroid)) as lon, avg(st_y(centroid)) as lat,";
+				$sSQL .= $sImportanceSQL."-0.1 as importance, ";  // slightly smaller than the importance for normal houses with rank 30, which is 0
+				$sSQL .= " (select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(blub.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance, ";
+				$sSQL .= " null as extra_place ";
+				$sSQL .= " from (select place_id, calculated_country_code ";
+				//interpolate the housenumbers here
+				$sSQL .= ", CASE WHEN startnumber != endnumber THEN ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) ";
+				$sSQL .= " ELSE ST_LineInterpolatePoint(linegeo, 0.5) END as centroid";
+				$sSQL .= ", parent_place_id, housenumber_for_place ";
+				$sSQL .= " from (location_property_osmline ";
+				$sSQL .= " join (values ".$sHousenumbers.") as housenumbers(place_id, housenumber_for_place) using(place_id)) ";
+				$sSQL .= " where housenumber_for_place>=0 and 30 between $this->iMinAddressRank and $this->iMaxAddressRank) as blub"; //postgres wants an alias here
+				$sSQL .= " group by place_id, housenumber_for_place, calculated_country_code "; //is this group by really needed?, place_id + housenumber (in combination) are unique
+				if (!$this->bDeDupe) $sSQL .= ", place_id ";
 
-				$sSQL .= "union ";
+				// tiger
+				$sSQL .= " union ";
 				$sSQL .= "select 'T' as osm_type, place_id as osm_id, 'place' as class, 'house' as type, null as admin_level, 30 as rank_search, 30 as rank_address, min(place_id) as place_id, min(parent_place_id) as parent_place_id, 'us' as country_code";
 				$sSQL .= ", get_address_by_language(place_id, housenumber_for_place, $sLanguagePrefArraySQL) as langaddress ";
 				$sSQL .= ", null as placename";
 				$sSQL .= ", null as ref";
 				if ($this->bIncludeExtraTags) $sSQL .= ", null as extra";
 				if ($this->bIncludeNameDetails) $sSQL .= ", null as names";
-				$sSQL .= ", avg(st_x(point)) as lon, avg(st_y(point)) as lat";
-				$sSQL .= $sImportanceSQL.", -1.15 as importance ";
+				$sSQL .= ", avg(st_x(centroid)) as lon, avg(st_y(centroid)) as lat,";
+				$sSQL .= $sImportanceSQL."-1.15 as importance ";
 				$sSQL .= ", (select max(p.importance*(p.rank_address+2)) from place_addressline s, placex p where s.place_id = min(blub.parent_place_id) and p.place_id = s.address_place_id and s.isaddress and p.importance is not null) as addressimportance ";
 				$sSQL .= ", null as extra_place ";
 				$sSQL .= " from (select place_id";
 				//interpolate the Tiger housenumbers here
-				$sSQL .= ", ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) as point, parent_place_id, housenumber_for_place ";
-				$sSQL .= "from (location_property_tiger ";
+				$sSQL .= ", CASE WHEN startnumber != endnumber THEN ST_LineInterpolatePoint(linegeo, (housenumber_for_place-startnumber::float)/(endnumber-startnumber)::float) ";
+				$sSQL .= " ELSE ST_LineInterpolatePoint(linegeo, 0.5) END as centroid";
+				$sSQL .= ", parent_place_id, housenumber_for_place ";
+				$sSQL .= " from (location_property_tiger ";
 				$sSQL .= " join (values ".$sHousenumbers.") as housenumbers(place_id, housenumber_for_place) using(place_id)) ";
 				$sSQL .= " where housenumber_for_place>=0 and 30 between $this->iMinAddressRank and $this->iMaxAddressRank) as blub"; //postgres wants an alias here
 				$sSQL .= " group by place_id, housenumber_for_place"; //is this group by really needed?, place_id + housenumber (in combination) are unique
 				if (!$this->bDeDupe) $sSQL .= ", place_id ";
 
+				// aux
 				$sSQL .= " union ";
 				$sSQL .= "select 'L' as osm_type, place_id as osm_id, 'place' as class, 'house' as type, null as admin_level, 0 as rank_search, 0 as rank_address, min(place_id) as place_id, min(parent_place_id) as parent_place_id, 'us' as country_code, ";
 				$sSQL .= "get_address_by_language(place_id, -1, $sLanguagePrefArraySQL) as langaddress, ";
@@ -873,7 +900,8 @@
 			}
 
 			// Do we have anything that looks like a lat/lon pair?
-			if ( $aLooksLike = looksLikeLatLonPair($sQuery) ){
+			if ( $aLooksLike = looksLikeLatLonPair($sQuery) )
+			{
 				$this->setNearPoint(array($aLooksLike['lat'], $aLooksLike['lon']));
 				$sQuery = $aLooksLike['query'];
 			}
@@ -1216,7 +1244,7 @@
 					foreach($aSearches as $aSearch)
 					{
 						$iQueryLoop++;
-						$searchedHousenumber=-1;
+						$searchedHousenumber = -1;
 
 						if (CONST_Debug) { echo "<hr><b>Search Loop, group $iGroupLoop, loop $iQueryLoop</b>"; }
 						if (CONST_Debug) _debugDumpGroupedSearches(array($iGroupedRank => array($aSearch)), $aValidTokens);
@@ -1301,7 +1329,11 @@
 							if ($aSearch['sHouseNumber'] && sizeof($aSearch['aAddress']))
 							{
 								$sHouseNumberRegex = '\\\\m'.$aSearch['sHouseNumber'].'\\\\M';
-								$aOrder[] = "exists(select place_id from placex where parent_place_id = search_name.place_id and transliteration(housenumber) ~* E'".$sHouseNumberRegex."' limit 1) desc";
+                                $aOrder[] = "";
+								$aOrder[0] = "exists(select place_id from placex where parent_place_id = search_name.place_id and transliteration(housenumber) ~* E'".$sHouseNumberRegex."' limit 1) ";
+								// also housenumbers from interpolation lines table are needed
+								$aOrder[0] .= " or exists(select place_id from location_property_osmline where parent_place_id = search_name.place_id and ".$aSearch['sHouseNumber'].">=startnumber and ".$aSearch['sHouseNumber']."<=endnumber limit 1)";
+								$aOrder[0] .= " desc";
 							}
 
 							// TODO: filter out the pointless search terms (2 letter name tokens and less)
@@ -1416,6 +1448,7 @@
 							//now search for housenumber, if housenumber provided
 							if ($aSearch['sHouseNumber'] && sizeof($aPlaceIDs))
 							{
+								$searchedHousenumber = intval($aSearch['sHouseNumber']);
 								$aRoadPlaceIDs = $aPlaceIDs;
 								$sPlaceIDs = join(',',$aPlaceIDs);
 
@@ -1429,25 +1462,47 @@
 								$sSQL .= " limit $this->iLimit";
 								if (CONST_Debug) var_dump($sSQL);
 								$aPlaceIDs = $this->oDB->getCol($sSQL);
+								
+								// if nothing found, search in the interpolation line table
+								if(!sizeof($aPlaceIDs))
+								{
+									// do we need to use transliteration and the regex for housenumbers???
+									//new query for lines, not housenumbers anymore
+									if($searchedHousenumber%2 == 0){
+										//if housenumber is even, look for housenumber in streets with interpolationtype even or all
+										$sSQL = "select distinct place_id from location_property_osmline where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='even' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
+									}else{
+										//look for housenumber in streets with interpolationtype odd or all
+										$sSQL = "select distinct place_id from location_property_osmline where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='odd' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
+									}
 
+									if (sizeof($this->aExcludePlaceIDs))
+									{
+										$sSQL .= " and parent_place_id not in (".join(',', $this->aExcludePlaceIDs).")";
+									}
+									//$sSQL .= " limit $this->iLimit";
+									if (CONST_Debug) var_dump($sSQL);
+									//get place IDs
+									$aPlaceIDs = $this->oDB->getCol($sSQL, 0);
+								}
+									
 								// If nothing found try the aux fallback table
 								if (!sizeof($aPlaceIDs))
 								{
 									$sSQL = "select place_id from location_property_aux where parent_place_id in (".$sPlaceIDs.") and housenumber = '".pg_escape_string($aSearch['sHouseNumber'])."'";
 									if (sizeof($this->aExcludePlaceIDs))
 									{
-										$sSQL .= " and place_id not in (".join(',',$this->aExcludePlaceIDs).")";
+										$sSQL .= " and parent_place_id not in (".join(',',$this->aExcludePlaceIDs).")";
 									}
 									//$sSQL .= " limit $this->iLimit";
 									if (CONST_Debug) var_dump($sSQL);
 									$aPlaceIDs = $this->oDB->getCol($sSQL);
 								}
-								//if nothing was found in placex or location_property_aux, then search in Tiger data for this housenumber(location_property_tiger)
-								$searchedHousenumber = intval($aSearch['sHouseNumber']);
+								//if nothing found search in Tiger data for this housenumber(location_property_tiger)
 								if (!sizeof($aPlaceIDs))
 								{
 									//new query for lines, not housenumbers anymore
-									if($searchedHousenumber%2==0){
+									if($searchedHousenumber%2 == 0){
 										//if housenumber is even, look for housenumber in streets with interpolationtype even or all
 										$sSQL = "select distinct place_id from location_property_tiger where parent_place_id in (".$sPlaceIDs.") and (interpolationtype='even' or interpolationtype='all') and ".$searchedHousenumber.">=startnumber and ".$searchedHousenumber."<=endnumber";
 									}else{
@@ -1470,16 +1525,15 @@
 								{
 									$aPlaceIDs = $aRoadPlaceIDs;
 									//set to -1, if no housenumbers were found
-									$searchedHousenumber=-1;
-								}else{
-									//housenumber was found, remains saved in searchedHousenumber
+									$searchedHousenumber = -1;
 								}
+                                //else: housenumber was found, remains saved in searchedHousenumber
 							}
 
 
 							if ($aSearch['sClass'] && sizeof($aPlaceIDs))
 							{
-								$sPlaceIDs = join(',', aPlaceIDs);
+								$sPlaceIDs = join(',', $aPlaceIDs);
 								$aClassPlaceIDs = array();
 
 								if (!$aSearch['sOperator'] || $aSearch['sOperator'] == 'name')
@@ -1613,6 +1667,7 @@
 					{
 						// Need to verify passes rank limits before dropping out of the loop (yuk!)
 						// reduces the number of place ids, like a filter
+						// rank_address is 30 for interpolated housenumbers
 						$sSQL = "select place_id from placex where place_id in (".join(',',array_keys($aResultPlaceIDs)).") ";
 						$sSQL .= "and (placex.rank_address between $this->iMinAddressRank and $this->iMaxAddressRank ";
 						if (14 >= $this->iMinAddressRank && 14 <= $this->iMaxAddressRank) $sSQL .= " OR (extratags->'place') = 'city'";
@@ -1620,14 +1675,16 @@
 						$sSQL .= ") UNION select place_id from location_property_tiger where place_id in (".join(',',array_keys($aResultPlaceIDs)).") ";
 						$sSQL .= "and (30 between $this->iMinAddressRank and $this->iMaxAddressRank ";
 						if ($this->aAddressRankList) $sSQL .= " OR 30 in (".join(',',$this->aAddressRankList).")";
-						$sSQL .= ")";
+						$sSQL .= ") UNION select place_id from location_property_osmline where place_id in (".join(',',array_keys($aResultPlaceIDs)).") ";
+						$sSQL .= "and (30 between $this->iMinAddressRank and $this->iMaxAddressRank)";
 						if (CONST_Debug) var_dump($sSQL);
 						$aFilteredPlaceIDs = $this->oDB->getCol($sSQL);
 						$tempIDs = array();
-						foreach($aFilteredPlaceIDs as $placeID){
-							$tempIDs[$placeID]= $aResultPlaceIDs[$placeID];  //assign housenumber to placeID
+						foreach($aFilteredPlaceIDs as $placeID)
+                        {
+							$tempIDs[$placeID] = $aResultPlaceIDs[$placeID];  //assign housenumber to placeID
 						}
-						$aResultPlaceIDs=$tempIDs;
+						$aResultPlaceIDs = $tempIDs;
 					}
 
 					//exit;