From: Simon Will <gorgor@gorgor.de>
Date: Tue, 5 May 2020 21:43:09 +0000 (+0200)
Subject: Use assertEqualsWithDelta for float comparisons
X-Git-Tag: v3.5.0~21^2~3
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/14dba3915725e0ff875656f5077945fdb1839017?hp=--cc

Use assertEqualsWithDelta for float comparisons

PHPUnit 7.3 introduced the functions assertEqualsWithDelta for comparing
floats with a delta. The old four-argument version of assertEquals is
deprecated in PHPUnit 8 and removed in PHPUnit 9.

This commit means that the tests will fail with PHPUnit < 7.3 because
assertEqualsWithDelta is not defined there.
---

14dba3915725e0ff875656f5077945fdb1839017
diff --git a/test/php/Nominatim/LibTest.php b/test/php/Nominatim/LibTest.php
index 7e8cbcc3..28cd9af0 100644
--- a/test/php/Nominatim/LibTest.php
+++ b/test/php/Nominatim/LibTest.php
@@ -98,8 +98,8 @@ class LibTest extends \PHPUnit\Framework\TestCase
 
         foreach ($aQueries as $sQuery) {
             $aRes = parseLatLon($sQuery);
-            $this->assertEquals(40.446, $aRes[1], 'degrees decimal ' . $sQuery, 0.01);
-            $this->assertEquals(-79.982, $aRes[2], 'degrees decimal ' . $sQuery, 0.01);
+            $this->assertEqualsWithDelta(40.446, $aRes[1], 0.01, 'degrees decimal ' . $sQuery);
+            $this->assertEqualsWithDelta(-79.982, $aRes[2], 0.01, 'degrees decimal ' . $sQuery);
             $this->assertEquals($sQuery, $aRes[0]);
         }
     }