From: Sarah Hoffmann <lonvia@denofr.de>
Date: Sun, 11 Jul 2021 16:23:42 +0000 (+0200)
Subject: avoid multiple returns of same value
X-Git-Tag: v4.0.0~52^2~15
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/3661f7a321ff3c0599a4808faff2a5dea67f6f18

avoid multiple returns of same value

Found by Sonarqube.
---

diff --git a/nominatim/tools/special_phrases/sp_importer.py b/nominatim/tools/special_phrases/sp_importer.py
index 48764518..e36b7439 100644
--- a/nominatim/tools/special_phrases/sp_importer.py
+++ b/nominatim/tools/special_phrases/sp_importer.py
@@ -274,9 +274,8 @@ class SPImporter():
                                 (self.phplib_dir / 'migration/PhraseSettingsToJson.php').resolve(),
                                 file_path], check=True)
                 LOG.warning('special_phrase configuration file has been converted to json.')
-                return json_file_path
             except subprocess.CalledProcessError:
                 LOG.error('Error while converting %s to json.', file_path)
                 raise
-        else:
-            return json_file_path
+
+        return json_file_path