From: Sarah Hoffmann <lonvia@denofr.de>
Date: Tue, 28 Mar 2023 12:53:45 +0000 (+0200)
Subject: disable prepared statements
X-Git-Tag: v4.3.0~86^2~6
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/36d068871da6921f6f2a7cd81df393f4fa3661a9?ds=inline;hp=6c67a4b500cf08b3cfce96e74b2658deb4696c05

disable prepared statements

Prepared statements do not work well with the partial indexes that
Nominatim uses because all Python constants are replaced with
parameters. A query like:

  placex.select().where(placex.c.rank_address.between(4, 25)

gets translated into a prepared query with two parameters:

  SELECT * FROM placex WHERE rank_address BETWEEN %s and %s

And this does not work with a partial index of:

  CREATE INDEX on placex(geometry) WHERE rank_address between 4 and 25
---

diff --git a/nominatim/api/core.py b/nominatim/api/core.py
index 116a2625..6d47d332 100644
--- a/nominatim/api/core.py
+++ b/nominatim/api/core.py
@@ -53,13 +53,16 @@ class NominatimAPIAsync:
 
             dsn = self.config.get_database_params()
 
+            query = {k: v for k, v in dsn.items()
+                      if k not in ('user', 'password', 'dbname', 'host', 'port')}
+            query['prepared_statement_cache_size'] = '0'
+
             dburl = sa.engine.URL.create(
                        'postgresql+asyncpg',
                        database=dsn.get('dbname'),
                        username=dsn.get('user'), password=dsn.get('password'),
                        host=dsn.get('host'), port=int(dsn['port']) if 'port' in dsn else None,
-                       query={k: v for k, v in dsn.items()
-                              if k not in ('user', 'password', 'dbname', 'host', 'port')})
+                       query=query)
             engine = sa_asyncio.create_async_engine(
                              dburl, future=True,
                              connect_args={'server_settings': {