From: Sarah Hoffmann <lonvia@denofr.de>
Date: Thu, 20 Apr 2017 18:56:44 +0000 (+0200)
Subject: Merge branch 'tetris' of https://github.com/roques/Nominatim into roques-tetris
X-Git-Tag: v3.0.0~36^2
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/4c7145c2938022d8355f49eb89a5ae1a68217a18?ds=inline;hp=-c

Merge branch 'tetris' of https://github.com/roques/Nominatim into roques-tetris
---

4c7145c2938022d8355f49eb89a5ae1a68217a18
diff --combined utils/setup.php
index fae200cc,c61c43e3..6a809c73
--- a/utils/setup.php
+++ b/utils/setup.php
@@@ -360,18 -360,16 +360,18 @@@ if ($aCMDResult['load-data'] || $aCMDRe
      }
  
      echo "Load Data\n";
+     $sColumns = 'osm_type, osm_id, class, type, name, admin_level, address, extratags, geometry';
+ 
      $aDBInstances = array();
      $iLoadThreads = max(1, $iInstances - 1);
      for ($i = 0; $i < $iLoadThreads; $i++) {
          $aDBInstances[$i] =& getDB(true);
-         $sSQL = 'insert into placex (osm_type, osm_id, class, type, name, admin_level, ';
-         $sSQL .= '                   address, extratags, geometry) ';
-         $sSQL .= 'select * from place where osm_id % '.$iLoadThreads.' = '.$i;
+         $sSQL = "INSERT INTO placex ($sColumns) SELECT $sColumns FROM place WHERE osm_id % $iLoadThreads = $i";
          $sSQL .= " and not (class='place' and type='houses' and osm_type='W' and ST_GeometryType(geometry) = 'ST_LineString')";
          if ($aCMDResult['verbose']) echo "$sSQL\n";
 -        if (!pg_send_query($aDBInstances[$i]->connection, $sSQL)) fail(pg_last_error($oDB->connection));
 +        if (!pg_send_query($aDBInstances[$i]->connection, $sSQL)) {
 +            fail(pg_last_error($aDBInstances[$i]->connection));
 +        }
      }
      // last thread for interpolation lines
      $aDBInstances[$iLoadThreads] =& getDB(true);
@@@ -380,9 -378,7 +380,9 @@@
      $sSQL .= ' SELECT osm_id, address, geometry from place where ';
      $sSQL .= "class='place' and type='houses' and osm_type='W' and ST_GeometryType(geometry) = 'ST_LineString'";
      if ($aCMDResult['verbose']) echo "$sSQL\n";
 -    if (!pg_send_query($aDBInstances[$i]->connection, $sSQL)) fail(pg_last_error($oDB->connection));
 +    if (!pg_send_query($aDBInstances[$iLoadThreads]->connection, $sSQL)) {
 +        fail(pg_last_error($aDBInstances[$iLoadThreads]->connection));
 +    }
  
      $bAnyBusy = true;
      while ($bAnyBusy) {