From: Sarah Hoffmann <lonvia@denofr.de>
Date: Sun, 3 Jul 2022 09:33:19 +0000 (+0200)
Subject: avoid issues with Python < 3.9 and linting
X-Git-Tag: v4.1.0~10^2~34
X-Git-Url: https://git.openstreetmap.org./nominatim.git/commitdiff_plain/681aad7e0dc099658eea15b769fdefd44cd8c484

avoid issues with Python < 3.9 and linting
---

diff --git a/.pylintrc b/.pylintrc
index 52d9fcf9..e8609407 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -11,6 +11,8 @@ ignored-modules=icu,datrie
 # 'with' statements.
 ignored-classes=NominatimArgs,closing
 # 'too-many-ancestors' is triggered already by deriving from UserDict
-disable=too-few-public-methods,duplicate-code,too-many-ancestors,bad-option-value,no-self-use
+# 'not-context-manager' disabled because it causes false positives once
+#   typed Python is enabled. See also https://github.com/PyCQA/pylint/issues/5273
+disable=too-few-public-methods,duplicate-code,too-many-ancestors,bad-option-value,no-self-use,not-context-manager
 
 good-names=i,x,y,fd,db,cc
diff --git a/nominatim/db/utils.py b/nominatim/db/utils.py
index e2b63e1d..461cb662 100644
--- a/nominatim/db/utils.py
+++ b/nominatim/db/utils.py
@@ -19,7 +19,7 @@ from nominatim.errors import UsageError
 
 LOG = logging.getLogger()
 
-def _pipe_to_proc(proc: subprocess.Popen[bytes],
+def _pipe_to_proc(proc: 'subprocess.Popen[bytes]',
                   fdesc: Union[IO[bytes], gzip.GzipFile]) -> int:
     assert proc.stdin is not None
     chunk = fdesc.read(2048)